From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: Request: Please add a prompt to read-event Date: Sun, 19 Dec 2021 06:46:13 -0800 Message-ID: <25023.17845.923708.608794@retriever.mtv.corp.google.com> References: <87o85exsyv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34536"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, emacs-devel@gnu.org To: larsi@gnus.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 19 15:47:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myxSt-0008pN-NT for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Dec 2021 15:47:07 +0100 Original-Received: from localhost ([::1]:53688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myxSs-0004e9-5e for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Dec 2021 09:47:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myxS8-0003wC-7Z for emacs-devel@gnu.org; Sun, 19 Dec 2021 09:46:20 -0500 Original-Received: from [2607:f8b0:4864:20::1034] (port=47090 helo=mail-pj1-x1034.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myxS6-0002Y4-L9 for emacs-devel@gnu.org; Sun, 19 Dec 2021 09:46:19 -0500 Original-Received: by mail-pj1-x1034.google.com with SMTP id rj2-20020a17090b3e8200b001b1944bad25so1963373pjb.5 for ; Sun, 19 Dec 2021 06:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=7qOpwX7lLx/saLcw5VQz4ZGePzZy9c9xMueaemr+/s8=; b=QJCdy4aUQju8ibh4P8eouodfM8DaPxPd4JTQcEsrYB6swqd/6lLwSmDEHMeLZ0qxoK mze1e0bNgRfbUdcJiplN0d7Nkcigq2O/NyItHnxhytJ+2k9soRdzgT0Uw7Z49W1jNC81 RCvitSeyCANaZ02JSP11ddu4bXzAmm1uMe7TCPcZ/RBmWqVqEKj7YX5bt0uSLqBE1q2b uUWIPmYFe4Iwv/yiNPB6uspmw/4H1b1l5BJNoNK8dsj+6A8AdUVqXzOj1xB7EXk4scJi BbOoe2OGGATQwiRs4ELybOMoeG9yitX6Gr88a1tdAkr30tSaYURy4IqJ2GJTe6XOog8P fQMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=7qOpwX7lLx/saLcw5VQz4ZGePzZy9c9xMueaemr+/s8=; b=L7Oc1+I/uSbV1iZUzx4kqC3a7iB9SG5Bmm4CR/1hj/EsexaxpwLXzKyqn2FVF3Fron NzxWFPC7W3k2JLpYDGrHqZ5upVgUVchs1MgvLurFdnGBIh/dLxQF43PHCErWKTb5X4Jw IoPeoifYNgLhK4pNhnaJAqaC3C0L83JvET3ogALzm4ksW0Kgk8XpYCS0yzVDH6hTIIco HSkL7OJi+7dQ8ttBipIfviLQmAnqj19amQveKxEoPWmxIBZO7bW2vl75x5ifyWmUUR2c tkbDMU7MB8rFhv1Sypeen6QLU1/WmqOCNUFmN52cnQLvUEwA/17M9wSpgUJoaliswWd1 dbjw== X-Gm-Message-State: AOAM531zVINpZwDEbMozbipVH9X0I6ujgElv2v++64fKWrysYglYK7u7 Dj/GyV1NKaOkE9FFzL+S3mS2K9pcVe+oqg== X-Google-Smtp-Source: ABdhPJzLlgVJI4tG161gpFLWyZx4SnDOl7N2QnNdMs7POr9DhmD0gY1IAwWFF+5TTiXxL0E98mNVvA== X-Received: by 2002:a17:90b:4b07:: with SMTP id lx7mr3982700pjb.122.1639925175683; Sun, 19 Dec 2021 06:46:15 -0800 (PST) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1510:3c5:7b95:ca15:b735]) by smtp.gmail.com with ESMTPSA id d3sm6038138pfv.192.2021.12.19.06.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Dec 2021 06:46:14 -0800 (PST) In-Reply-To: <87o85exsyv.fsf@gnus.org> X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1034 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=raman@google.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -173 X-Spam_score: -17.4 X-Spam_bar: ----------------- X-Spam_report: (-17.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.563, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282439 Archived-At: I didn't write the code in novice.el:-) Lars Ingebrigtsen writes: > "T.V Raman" writes: >=20 > > Emacspeak advices read-event and read-char to speak their > > prompt. There are a few places in Emacs where read-event and/or > > read-char are called without a prompt; e.g. disabled-command-func= tion > > > > Could we perhaps fix this=3F >=20 > [...] >=20 > > (message "Type y, n, ! or SPC (the space bar): ") > > (let ((cursor-in-echo-area t)) > > (while (progn (setq char (read-event)) > > =09=09 (or (not (numberp char)) > > =09=09=09 (not (memq (downcase char) > > =09=09=09=09 '(=3F! =3Fy =3Fn =3F\s =3F\C-g))))) > > =09 (ding) > > =09 (message "Please type y, n, ! or SPC (the space bar): ")))) >=20 > Hm... that is pretty odd. Why is it using `message' here instead o= f > just using that string as the prompt to `read-event'=3F >=20 > --=20 > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no --=20 Thanks, --Raman(I Search, I Find, I Misplace, I Research) =E2=99=89 Id: kg:/m/0285kf1 =F0=9F=A6=AE -- Thanks, --Raman(I Search, I Find, I Misplace, I Research) ♉ Id: kg:/m/0285kf1 🦮