From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Gitlab Migration Date: Fri, 27 Aug 2021 14:33:01 +0300 Message-ID: <24fd6052-c889-5ad1-4536-cd2e1053b0eb@yandex.ru> References: <87h7fcnmq0.fsf@posteo.net> <87o89kw0hl.fsf@gnus.org> <0c369b25-aedd-1fdf-4813-503f27e42c7c@yandex.ru> <877dg73ejo.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35082"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Cc: Lars Ingebrigtsen , Daniel Fleischer , Philip Kaludercic , emacs-devel@gnu.org To: Arthur Miller , Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 27 13:34:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJa7U-0008wP-Jg for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Aug 2021 13:34:00 +0200 Original-Received: from localhost ([::1]:35888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJa7T-0003ol-3d for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Aug 2021 07:33:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJa6c-00035Z-L3 for emacs-devel@gnu.org; Fri, 27 Aug 2021 07:33:06 -0400 Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:40473) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJa6b-0004Qb-4l for emacs-devel@gnu.org; Fri, 27 Aug 2021 07:33:06 -0400 Original-Received: by mail-wm1-x329.google.com with SMTP id x2-20020a1c7c02000000b002e6f1f69a1eso8975713wmc.5 for ; Fri, 27 Aug 2021 04:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WQbdAjZw9Il12Uf7dElRcDcG00Noqhs7rpUfPjZrAoE=; b=j9jy/fFLLnLz+Cgl6j/QZfpYSvF4CGVRpaUb/cPWFpLVunAWSgUEk8gCff1awamOKy Zr6D0onhs9/7I8b+9E7x7nAV7mzfbLGI+8nXCawMz8ByroNW2bQXz49NJjes03rZA1Dh NGJBDZdx0lbX63HScQLW06bNBwSysscn7SJ6T0MXeZQbFXfR789oqo8/Mff3kRUTbtxW e/XZFau366l8UuEKFjaw+pnOpOo+V9FzDxoGDosvtij/RnMSAZxx7CGq1ExWz9U6jIay Pd6zI/zpfj0iunoozdWucLdsKmPitPqiaaxH+lnPiB0Eu45flxKZ3HbNBEXU8LexDXNu EKeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WQbdAjZw9Il12Uf7dElRcDcG00Noqhs7rpUfPjZrAoE=; b=tZ/1sP/xWJPBt/DWc1mPHsq8OAchuoYp8FLqCNEer9JaT3NUCogqzjLmVUbtKBLdj/ uEWJCWWvgMNcfnFVPCUfyPMu3aw/UgoTCqCVjV1fI+PjWKCoSiwu1LCcgoOHBAL/K5qZ PQh9Uu0o3tAKOu0dLcXzDCehHjqYpRG7pCGB3g/07CSkvmm19NVaOUMW3DGA9D72IWre sD8Nt0NZZMytB0NqVKG9WXF66TCxJDNzGZMWU8dOqJ+bV1jyiGy3wV6WHH0a0DkDtJdy 5VNOsxQu9KDbkBR2jAZ81Wi6iit/HupMWYDNp404uCDfbKf66bCJXAPop/n2yZSknL2F wWAw== X-Gm-Message-State: AOAM531Qcr2mYumlifUqK/Gxf1zgOIhK3+0hP03zI2CSpWqw+2D6PnSR IIzDrr9BMVi2SX+EZehAE0c+Xz/hXb4= X-Google-Smtp-Source: ABdhPJxweXwWg9aX9hvI0XhRNUR0X74GnNJ5bvYLl8O8KtuNrBIRrO4TgePFmeG6BP8yjjDL/jDpeA== X-Received: by 2002:a05:600c:4f03:: with SMTP id l3mr19805660wmq.0.1630063983670; Fri, 27 Aug 2021 04:33:03 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id b15sm6832508wru.1.2021.08.27.04.33.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Aug 2021 04:33:03 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=raaahh@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.437, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273149 Archived-At: On 27.08.2021 04:31, Arthur Miller wrote: >>> We also have a bunch of formal rules for submissions which tend to >>> seem intimidating. A CI with an automated checker running against all >>> PRs can alleviate that problem. >> I don't know enough git to tell you exactly what it is, but perhaps >> whatever runs each time I check-in something to my local copy of the >> repository that checks for indentation and extraneous whitespace could >> also work for this? > Couldn't identation and extraneous space be solved by either running after save > hook in Emacs, or by running emacs in batch mode as a git hook? Yes, you're both talking about git hooks. A minor disadvantage is that a hook needs to be installed, and then a bug in a hook implementation can stop you from being able to make a commit (there are overrides, but those require more googling). CI is good because if its visibility: the list of checks on current PRs is visible to every newcomer, instead of being buried somewhere near the end of the CONTRIBUTE document.