From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?Jan_Dj=C3=A4rv?= Newsgroups: gmane.emacs.devel Subject: Re: State of NS port Date: Mon, 14 Jan 2013 10:35:14 +0100 Message-ID: <24F0B545-CA72-41D7-9CC7-A81EB9C73FE3@swipnet.se> References: <69E12347-B799-48E4-AE1A-115365CEA4C8@gmail.com> <22C1B7A8E2294F08983ACE6BA77A7346@gmail.com> <20AB1D9B-73FE-4B14-885E-95CFD2B5F8EB@swipnet.se> <2E1BB17A2D1E4793AEAA71C1B8AE1690@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (1.0) Content-Type: multipart/alternative; boundary=Apple-Mail-C4EB2AF6-FA13-468D-8100-B4C451F7BF70 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1358156139 18025 80.91.229.3 (14 Jan 2013 09:35:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Jan 2013 09:35:39 +0000 (UTC) Cc: Adrian Robert , "emacs-devel@gnu.org Development" To: Chris Zheng Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 14 10:35:56 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TugSO-0006zB-4D for ged-emacs-devel@m.gmane.org; Mon, 14 Jan 2013 10:35:52 +0100 Original-Received: from localhost ([::1]:47613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TugS7-00060Y-Ry for ged-emacs-devel@m.gmane.org; Mon, 14 Jan 2013 04:35:35 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TugRx-0005bk-KC for emacs-devel@gnu.org; Mon, 14 Jan 2013 04:35:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TugRr-0007np-Fh for emacs-devel@gnu.org; Mon, 14 Jan 2013 04:35:25 -0500 Original-Received: from mailout.melmac.se ([62.20.26.67]:48771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TugRr-0007nY-4H for emacs-devel@gnu.org; Mon, 14 Jan 2013 04:35:19 -0500 Original-Received: from mail01.melmac.se (mail01.melmac.se [62.20.26.80]) by mailout.melmac.se (Postfix) with ESMTP id 9F6B29873 for ; Mon, 14 Jan 2013 10:35:15 +0100 (CET) Original-Received: (qmail 19397 invoked by uid 89); 14 Jan 2013 09:35:15 -0000 Original-Received: from h-46-59-42-18.na.cust.bahnhof.se (HELO coolsville.localdomain) (boel.djarv@bdtv.se@46.59.42.18) by mail01.melmac.se with ESMTPA; 14 Jan 2013 09:35:15 -0000 Original-Received: from [172.20.199.240] (unknown [172.20.199.240]) by coolsville.localdomain (Postfix) with ESMTPSA id 052437FA06C; Mon, 14 Jan 2013 10:35:15 +0100 (CET) In-Reply-To: <2E1BB17A2D1E4793AEAA71C1B8AE1690@gmail.com> X-Mailer: iPhone Mail (10A551) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 62.20.26.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156337 Archived-At: --Apple-Mail-C4EB2AF6-FA13-468D-8100-B4C451F7BF70 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable This is fixed in the trunk.=20 Jan D. 14 jan 2013 kl. 03:44 skrev Chris Zheng : > But the second one (which seems a reasonable fix) makes Emacs unable to di= splay any non-western characters. >=20 > - if ([fkeys count] > 0) > - matchingDescs =3D [fdesc matchingFontDescriptorsWithMandatoryKeys: f= keys]; > - else > - matchingDescs =3D [NSMutableArray array]; > + matchingDescs =3D [fdesc matchingFontDescriptorsWithMandatoryKeys: fk= eys]; >=20 > --=20 > Best regards, > Chris >=20 > On Saturday, January 12, 2013 at 6:09 PM, Jan Dj=C3=A4rv wrote: >=20 >> Hello. >>=20 >> 12 jan 2013 kl. 04:49 skrev Chris Zheng : >>=20 >>> I suffered this problem too, and it's because of two bug fixes after I d= ig it awhile. >>>=20 >>> bug#11484: 23.4; Scrolling leaves traces of old text behind >>>=20 >>> http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-05/msg00383.html >>>=20 >>> LCD-smoothing was turned off to fix this bug, >>>=20 >>> and >>>=20 >>> bug#11541: - Another reproduction - Emacs 24.2; Null pointer on OSX= with >>>=20 >>> http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-09/msg01293.html >>>=20 >>> I simply revert these two fixes, and problem you mentioned is gone. >>>=20 >>> So, maybe there are more deeper things around of these two bugs. >>=20 >> Yes there are. The first one is due to the fact that the font code miscal= culates the font metrics when lcd-smoothing is on. It may be related to some= premature optimizations such as caching of font metrics in the font code. >>=20 >> The second one is because the memory handling in the font code is incorre= ct and leads to crashes for some people (may depend on font and/or OS versio= n and/or compiler version/settings). The second one does not happen when run= in gdb. But when it does happen, as it does for me right now, Emacs crashes= . >>=20 >> Jan D. >=20 --Apple-Mail-C4EB2AF6-FA13-468D-8100-B4C451F7BF70 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
This is fixed in the trunk. 

    Jan D.

14 jan 2013 kl. 03:44 skrev= Chris Zheng <chrisdcheng@gmail.= com>:

But the second one (which seems a reasonable fix) makes Emacs unable to di= splay any non-western characters.

-    if= ([fkeys count] > 0)
-      matchingDescs =3D [f= desc matchingFontDescriptorsWithMandatoryKeys: fkeys];
-   &n= bsp;else
-      matchingDescs =3D [NSMutableArray a= rray];
+    matchingDescs =3D [fdesc matchingFontDescrip= torsWithMandatoryKeys: fkeys];

-- 
Best regards,
Chris

=20

On Saturday, January 12, 2013 a= t 6:09 PM, Jan Dj=C3=A4rv wrote:

Hello.

12 j= an 2013 kl. 04:49 skrev Chris Zheng <chrisdcheng@gmail.com>:

I suffered this problem too, and it's because of two bug fix= es after I dig it awhile.

bug#11484: 23.4; Scrollin= g leaves traces of old text behind

LCD-smoothing was turned off to fix this bug,

and

bug#11541: - Another reproduction - Em= acs 24.2; Null pointer on OSX with

<= div>
I simply revert these two fixes, and problem you mentione= d is gone.

So, maybe there are more deeper things a= round of these two bugs.

Yes the= re are. The first one is due to the fact that the font code miscalculates t= he font metrics when lcd-smoothing is on. It may be related to some prematur= e optimizations such as caching of font metrics in the font code.
=
The second one is because the memory handling in the font cod= e is incorrect and leads to crashes for some people (may depend on font and/= or OS version and/or compiler version/settings). The second one does not ha= ppen when run in gdb. But when it does happen, as it does for me right now,= Emacs crashes.

Jan D.
=20 =20 =20 =20
=20

= --Apple-Mail-C4EB2AF6-FA13-468D-8100-B4C451F7BF70--