From: Bob Rogers <rogers-emacs@rgrjr.homedns.org>
To: Emacs developers <emacs-devel@gnu.org>
Subject: Re: The new keymap functions
Date: Wed, 17 Nov 2021 15:57:26 -0500 [thread overview]
Message-ID: <24981.27830.730338.79875@orion.rgrjr.com> (raw)
In-Reply-To: <87r1bfp72g.fsf@gnus.org>
From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Wed, 17 Nov 2021 08:36:23 +0100
Juri Linkov <juri@linkov.net> writes:
> Whereas the name `defvar-keymap' is nice since it's a top-level macro,
> `define-keymap' looks out of place in the same group of functions.
> And indeed, such mismatch looks odd:
>
> (define-keymap "C-c C-c" #'quit-buffer)
> (keymap-set map "C-c C-c" #'quit-buffer)
>
> What about renaming it to `keymap-define'? Then:
>
> (keymap-define "C-c C-c" #'quit-buffer)
> (keymap-set map "C-c C-c" #'quit-buffer)
I like that all the `keymap-*' functions take a map as the first
parameter (except the commands that have the map "in the name", like
`keymap-global-set'). And using `define-*' for a form that defines
something (and has a (potentially) long body) is a very long-standing
tradition in Emacs, so I'd prefer to keep it as is.
The purist in me can't resist pointing out that these are not so much
defining something as making a binding between an existing command and a
given key sequence. But using binding in the naming may be too geeky
even for the average Emacs user, so FWIW I agree "keymap-" is a good
choice, but "define-" is too grand.
-- Bob Rogers
http://www.rgrjr.com/
next prev parent reply other threads:[~2021-11-17 20:57 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 6:56 The new keymap functions Lars Ingebrigtsen
2021-11-13 7:31 ` Stefan Kangas
2021-11-13 7:50 ` Lars Ingebrigtsen
2021-11-13 11:36 ` Joost Kremers
2021-11-13 12:07 ` Lars Ingebrigtsen
2021-11-15 13:01 ` Dmitry Gutov
2021-11-15 16:53 ` Lars Ingebrigtsen
2021-11-16 7:28 ` Lars Ingebrigtsen
2021-11-16 14:08 ` Eli Zaretskii
2021-11-16 14:24 ` Lars Ingebrigtsen
2021-11-16 15:13 ` Eli Zaretskii
2021-11-16 15:19 ` Lars Ingebrigtsen
2021-11-16 17:16 ` Eli Zaretskii
2021-11-17 7:30 ` Lars Ingebrigtsen
2021-11-13 15:09 ` Stefan Monnier
2021-11-13 15:24 ` Lars Ingebrigtsen
2021-11-14 3:17 ` Lars Ingebrigtsen
2021-11-14 5:05 ` Phil Sainty
2021-11-14 5:14 ` Lars Ingebrigtsen
2021-11-14 7:15 ` Eli Zaretskii
2021-11-14 10:53 ` Lars Ingebrigtsen
2021-11-14 11:01 ` Lars Ingebrigtsen
2021-11-14 7:41 ` Yuri Khan
2021-11-15 4:52 ` Richard Stallman
2021-11-15 5:14 ` Lars Ingebrigtsen
2021-11-16 4:05 ` Richard Stallman
2021-11-16 7:38 ` Lars Ingebrigtsen
2021-11-16 16:25 ` [External] : " Drew Adams
2021-11-17 4:16 ` Richard Stallman
2021-11-17 7:55 ` Lars Ingebrigtsen
2021-11-17 16:06 ` [External] : " Drew Adams
2021-11-16 16:24 ` Drew Adams
2021-11-16 20:14 ` Juri Linkov
2021-11-17 4:16 ` Richard Stallman
2021-11-17 7:36 ` Lars Ingebrigtsen
2021-11-17 8:10 ` Juri Linkov
2021-11-17 9:42 ` Robert Pluim
2021-11-17 17:03 ` Juri Linkov
2021-11-18 9:15 ` Lars Ingebrigtsen
2021-11-18 10:25 ` Robert Pluim
2021-11-18 10:33 ` Lars Ingebrigtsen
2021-11-18 10:37 ` Lars Ingebrigtsen
2021-11-18 10:54 ` Robert Pluim
2021-11-18 10:59 ` Lars Ingebrigtsen
2022-11-15 18:38 ` Juri Linkov
2022-11-17 7:31 ` Juri Linkov
2022-11-17 8:35 ` Robert Pluim
2022-11-17 15:04 ` Robert Pluim
2022-11-17 17:29 ` Juri Linkov
2022-11-18 8:33 ` Robert Pluim
2022-11-18 15:41 ` Robert Pluim
2023-03-17 14:48 ` Robert Pluim
2023-03-18 18:04 ` Juri Linkov
2023-03-20 8:54 ` Robert Pluim
2021-11-17 20:57 ` Bob Rogers [this message]
2021-11-18 3:53 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2021-11-13 18:59 xenodasein--- via Emacs development discussions.
2021-11-14 0:42 ` Lars Ingebrigtsen
2021-11-14 4:56 ` Lars Ingebrigtsen
2021-11-14 15:41 ` Stefan Monnier
2021-11-14 18:00 ` Lars Ingebrigtsen
2021-11-14 12:04 ` xenodasein--- via Emacs development discussions.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24981.27830.730338.79875@orion.rgrjr.com \
--to=rogers-emacs@rgrjr.homedns.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).