From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Wed, 13 Oct 2021 08:11:54 -0700 Message-ID: <24934.63290.767826.796975@retriever.mtv.corp.google.com> References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <831r4pp0ms.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, monnier@iro.umontreal.ca, eliz@gnu.org, larsi@gnus.org, emacs-devel@gnu.org To: stefan@marxist.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 13 17:13:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mafwc-000AXk-70 for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 17:13:26 +0200 Original-Received: from localhost ([::1]:44582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mafwb-0000FG-6q for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 11:13:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mafvN-0007ag-VS for emacs-devel@gnu.org; Wed, 13 Oct 2021 11:12:10 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:33700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mafvE-0003yw-BF for emacs-devel@gnu.org; Wed, 13 Oct 2021 11:12:09 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id y4so2061429plb.0 for ; Wed, 13 Oct 2021 08:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=from:message-id:date:mime-version:content-transfer-encoding:to:cc :subject:in-reply-to:references; bh=ej1fGVyCPfhSNN7X3Gc0aUfpeoNgbK0TgA3ZjT6xOpM=; b=hGqc4eFkG2oREkaTiKxugoJR02xgs1npfp4VRR97YUK6w2QrjL7ASGg6rA+Cn7sDho nijoZETh1OEQWn92CqbYslYDgAaeNhno3+45BzkhdUmHlj3LB8shBJlA1j9gUiScS5vk uH6WYtDdnrQSbjDDNmlhdG87sjJ8b9QfqBfQEHTupB8TLs4UsTyOzNdgE9SSxbHUrtT1 YOeFSmuqCSElkEUQMgkd9XWtPxVq1FwpwAg7HIy3FyJv4YXWJggS4B91ETVMyIqgmKKB HfMvDCodL+wM8nkazgtrCu2pA3aZ2eqt/0H7jDL3jEtniDf/SJm/bha9tEiMW19Axv2O x1dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:date:mime-version :content-transfer-encoding:to:cc:subject:in-reply-to:references; bh=ej1fGVyCPfhSNN7X3Gc0aUfpeoNgbK0TgA3ZjT6xOpM=; b=6bi0MmGJXSLTk/+RIyC47j3yUwbghcXCgYWOm5PvFeDXD/i+Tz2eQGKwDjQ9Nc8oRY rgrERDKkTXHx46T8Uvh1QmfP7Ca73yFXoQeB47qLzdlRZa5d/SC1lBdriO5UiUtv9GuM NEolwf618Qmg/5Wz5OYhvbnBxtrLCC3/ye/X+aGD6u9d8jvJBXZsVdb+hts77kuCI8is OG8Z8zXqdoWOJjDNcLCOdWMGRAqK3KF6HMLOGWfXM5ZvbOu23cLy8lhwC4W4B7t6RXup azR6Nnui+s2elgdbWk+vIhsTQ2WSlofyYpxDxat4OyDkKWa8vICX4E1zAfYDuQ3gWpPk 9i0A== X-Gm-Message-State: AOAM531x/AHOVw6UAmDBqpIP6xVtcVWZdAxF97xjPpyW/Z9LukgPeyRN HZq/PQw+RqmJMcfuAGgjURScfI7XII9uCA== X-Google-Smtp-Source: ABdhPJxsdbxTpDY0xRtcD/9U4PBrXQOymNyaDgp55Ro4LmKCy0WubygcMUpoKIMQzGDvi43YipAcug== X-Received: by 2002:a17:90b:4d0b:: with SMTP id mw11mr14160726pjb.135.1634137918047; Wed, 13 Oct 2021 08:11:58 -0700 (PDT) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1510:47d5:c9eb:ae14:2922]) by smtp.gmail.com with ESMTPSA id w13sm13437938pfc.10.2021.10.13.08.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 08:11:56 -0700 (PDT) In-Reply-To: X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=raman@google.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276916 Archived-At: See the associated set of tests -- I intended it to be completely compatible, but from memory someone on the emacs-devel list pointed out one diff -- it was an extreme corner case that I didn't fix. I use ems-kbd in emacspeak instead of 'kbd because it avoids pulling in all of the keyboard macro code and speeds up startup a bit Stefan Kangas writes: > T.V Raman writes: >=20 > > Related: see > > https://emacspeak.blogspot.com/2020/10/extracted-light-weight-key-= reader-by.html > > and some follow-up discussion probably on this list. >=20 > Thanks, that's useful. I will most likely "borrow" some ideas from > your tests for the test suite. There seems to be some opportunities= > for simplifying the code as well, something that I avoided in my > version. >=20 > Is your 'new-kbd' intended to be bug-for-bug compatible with 'kbd', = or > have there been any functional changes along the way=3F Are you > suggesting that we could perhaps just replace 'kbd' with your new > version=3F (One observation is that your version still uses the cl-= > functions, so it would need adjusting for subr.el.) --=20 Thanks, --Raman(I Search, I Find, I Misplace, I Research) =E2=99=89 Id: kg:/m/0285kf1 =F0=9F=A6=AE -- Thanks, --Raman(I Search, I Find, I Misplace, I Research) ♉ Id: kg:/m/0285kf1 🦮 -- Thanks, --Raman(I Search, I Find, I Misplace, I Research) ♉ Id: kg:/m/0285kf1 🦮