From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: gnus-group-read-ephemeral-search-group -- Something Changed? Date: Fri, 6 Nov 2020 10:29:07 -0800 Message-ID: <24485.38387.21886.155163@retriever.mtv.corp.google.com> References: <20201106162239.1E8ECC20DCB@raman-glaptop.localdomain> <87wnyy5rkh.fsf@ericabrahamsen.net> <24485.36148.78621.877205@retriever.mtv.corp.google.com> <87o8ka5p7y.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, emacs-devel@gnu.org To: eric@ericabrahamsen.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 19:29:59 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kb6Up-0006qt-6d for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 19:29:59 +0100 Original-Received: from localhost ([::1]:33074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb6Uo-0000RM-8W for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 13:29:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb6U5-0008As-QV for emacs-devel@gnu.org; Fri, 06 Nov 2020 13:29:13 -0500 Original-Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:46743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kb6U2-0005PX-Ny for emacs-devel@gnu.org; Fri, 06 Nov 2020 13:29:12 -0500 Original-Received: by mail-pf1-x42d.google.com with SMTP id v12so2103201pfm.13 for ; Fri, 06 Nov 2020 10:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=C9u2LAg5bbI8vXwDjsrlPCiTUn+0OYjjP9nL4G+eQrI=; b=UuVGazm4O+OZx86w3kLKFLvkC249j+uxD3qbr0DjL8cRZIZHmzIyVdqIgyD2F9Jz4f 3yZ8vQCojnDMm18+W5BJhMYAPnFqVIFmlM+niORsmG2bINSQf2QqVtJd/5LVKHkd9UeG YJsuzJlzFpMqhOmxMp2LIvBn6sAPz4WAUBOFGq0l+0iGKycZ0k8UxQRcNeCFq4CFC5Kh mUsmyP/pMsnyBL5LlO9mr9J+n7j+uAMx2eQdbXJnxwTgfxDIbKbU+Doikxq+XmfH11Du SsPoLNl8gXYelC9Yd+B02CLdxiPFnrLvX1kA2H8eEaaEW1HgpYD4Vlw5sUnDJ82+ip7u VbAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=C9u2LAg5bbI8vXwDjsrlPCiTUn+0OYjjP9nL4G+eQrI=; b=CJHahJtvsdUJ11ov/t+e/X7hFIMQGwStOp+QbmwG4yd/qdwB0BXmfnIhsR8ki9FO7+ yl1pyycHP3dDzfv0Z2YsiE9Hfb2FukcRviJo0fikYLdY/2EhXfm3UBYxVoyDh9l6RNHu tG33bXa55TVUO5nV0LZI/foZ3dWi3g150X/sLfm6FEPNOelbr33vR5/R2a9KQzGXu6an Q2p0J8TGxHX6FNJGeuDGoFHaF5/NiZMnLUEpD048vVTl1R1Y6eaM3NGDSdUYJchGYdBU oV7T0ITnp/y3QI0WjxAmAcrAzLPNwtrBwkoX4f0eYS5I0fPWfnLdhmF/E4PFICnYQRDO m8wg== X-Gm-Message-State: AOAM532JFn94nx4Q1PIuHpkncYO2iZ3XRgnmuoykcH/boq33zfUi5j2b fNR9u+Uijhr8sOpJ/ydPExnHcw== X-Google-Smtp-Source: ABdhPJzGTtRaaLWj+7Sh8JbY5GTFh8fo4i7xw+sHMr4eXX/wNydJprjeb/DdLX0ogf3Qdhej5ZLFiQ== X-Received: by 2002:a17:90a:bc4c:: with SMTP id t12mr821551pjv.163.1604687348873; Fri, 06 Nov 2020 10:29:08 -0800 (PST) Original-Received: from retriever.mtv.corp.google.com ([172.22.80.201]) by smtp.gmail.com with ESMTPSA id w4sm3335972pjh.14.2020.11.06.10.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 10:29:07 -0800 (PST) Original-Received: by retriever.mtv.corp.google.com (Postfix, from userid 13930) id 0F62718003FB; Fri, 6 Nov 2020 10:29:07 -0800 (PST) In-Reply-To: <87o8ka5p7y.fsf@ericabrahamsen.net> X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=raman@google.com; helo=mail-pf1-x42d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258841 Archived-At: Not sure, will need to try it once you've added the check for the older keyEric Abrahamsen writes: > "T.V Raman" writes: >=20 > > you're correct. But please keep the backward compatibility, since = I > > need emacspeak to work with both the released emacs 27, as well as= > > emacs-28 built from head which I use --- that latter is what helps= me > > make sure that when Emacs-28 does get released, emacspeak works ou= t of > > the box with it. >=20 > Okay, will do. Are you sure that checking for the nnir key symbol is= > enough to make everything work correctly=3F >=20 > > > Eric Abrahamsen writes: > > > "T.V Raman" writes: > > >=20 > > > > I use gnus-group-read-ephemeral-search-group to search GMail = via imap, > > > > see details in this blog article: > > > > https://emacspeak.blogspot.com/2020/09/searching-gmail-from-g= nus.html > > > > > > > > About 8 weeks or so, that function > > > > gnus-group-read-ephemeral-search-group was declared obsolete = but its > > > > replacement was supposed to be backward compatible and everyt= hing > > > > worked until about 2 days ago --- or from memory I updated/re= built > > > > emacs yesterday and it's broken today. > > > > > > > > Broken: How, > > > > > > > > Now, when I invoke the afore-mentioned function > > > > I get an additional prompt after supplying the query and cal= ling it > > > > with the imap-search spec it expects. A quick look in git log= s didn't > > > > show anything suspicious, other than the file was changed wit= h > > > > comments to the effect that that function is obsolete. > > >=20 > > > Yes, this function has changed in the past couple of days, as n= nir.el > > > has been obsoleted. I'm guessing you're calling > > > `gnus-gorup-read-ephemeral-search-group' with a spec that conta= ins an > > > `nnir-search-spec' key=3F That key is now called `gnus-search-s= pec'. > > >=20 > > > I can provide better backwards compatibility by continuing to c= heck for > > > the `nnir-search-spec' and `nnir-group-spec' keys, I guess I di= dn't > > > think people would be using that function programmatically in t= his way. > > >=20 > > > Would you be willing to show me exactly how you're calling this= > > > function=3F I can be more certain about providing backwards com= patibility > > > that way, and might be able to suggest some alterations. > > >=20 > > > Sorry for the roadbump, > > >=20 > > > Eric > > > > --=20 > > =E2=99=89Id: kg:/m/0285kf1 =F0=9F=A6=AE=E2=99=89 >=20 > "T.V Raman" writes: >=20 > > P.S. how am calling that function was documented in the blog artic= le I > > mentioned; here is a pointer to the code in Git to make it easier.= > > https://github.com/tvraman/emacspeak/blob/master/lisp/gm-nnir.el#L= 133 >=20 > I'll take a look at this over the weekend. Maybe I can suggest some = more > changes to take advantage of the new gnus-search.el library. >=20 > Thanks for the report, > Eric --=20 =E2=99=89Id: kg:/m/0285kf1 =F0=9F=A6=AE=E2=99=89 -- ♉Id: kg:/m/0285kf1 🦮♉