From: Stefan Merten <stefan@merten-home.de>
To: emacs-devel@gnu.org, Daniel Colascione <dancol@dancol.org>
Cc: Wei-Wei Guo <wwguocn@gmail.com>, Martin Blais <blais@furius.ca>,
David Goodger <goodger@python.org>
Subject: Re: rst-mode deprecated keybindings: okay to remove? During freeze?
Date: Fri, 10 Jan 2014 13:09:25 +0100 [thread overview]
Message-ID: <2444.1389355765@eskebo.homelinux.merten-home.de> (raw)
In-Reply-To: <22645.1389173701@eskebo.homelinux.merten-home.de>
[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]
Hi Daniel!
2 days ago Stefan Merten wrote:
> 2 days ago Daniel Colascione wrote:
>> On 01/06/2014 12:35 PM, Stefan Merten wrote:
>>> Today Stefan Monnier wrote:
>>>>> Would anyone mind terribly if I removed rst-mode's support for its
>>>>> "deprecated" keybindings? If not, can I do it before the next release?
>>>
>>> Please keep them once more. But you are right: They should be removed
>>> at some point.
>>>
>>>>> These
>>>>> bindings (e.g., C-c 3) have emitted warnings for years, and right now, they
>>>>> show up as ugly "??" entries in describe-mode output. I have a patch that
>>>>> makes the presentation nicer, but it'd be better to just kill these
>>>>> bindings entirely.
>>>
>>> Thanks for the patch. But I think it's better to remove them in the
>>> next release.
>>>
>>> I'll do this.
>>
>> Wait, I'm confused --- are you removing the deprecated bindings for
>> 24.4 or not?
>
> Sorry for being unclear: I meant in the next release (> 24.4) - not
> now. I'm too busy with other things at the moment. At the same time
> there are bigger changes in the whole code which are still brewing
> though.
>
>> If we're keeping them for this release, we should at
>> least apply my patch so that C-h m is less confusing for users.
>
> That may be a good move - though I doubt that anyone has a problem
> with that. Please do the patch. I'll look at it later.
I now checked your patch. In general I like your patch.
However, at this time I refuse using `lexical-let' in `rst.el' for
backward compatibility. If your patch works without `lexical-let' then
go ahead. Otherwise please do not commit the patch to the Emacs main
line.
PS: The Emacs development seems to be moving to GIT. For me this would
be yet another VCS I need to learn (sigh). When this happens I
might be unable to use the Emacs VCS for some time.
Grüße
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 307 bytes --]
next prev parent reply other threads:[~2014-01-10 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 3:32 rst-mode deprecated keybindings: okay to remove? During freeze? Daniel Colascione
2014-01-06 4:30 ` Stefan Monnier
2014-01-06 20:35 ` Stefan Merten
2014-01-06 20:43 ` Daniel Colascione
2014-01-08 9:35 ` Stefan Merten
2014-01-10 12:09 ` Stefan Merten [this message]
2014-01-10 12:36 ` David Kastrup
2014-01-10 13:55 ` Stefan Monnier
2014-01-10 14:56 ` Thierry Volpiatto
2014-01-10 17:09 ` Stefan Monnier
2014-01-10 14:12 ` Stefan Merten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2444.1389355765@eskebo.homelinux.merten-home.de \
--to=stefan@merten-home.de \
--cc=blais@furius.ca \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=goodger@python.org \
--cc=wwguocn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).