From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: advice.el and bytecomp: Did something change recently? Date: Fri, 17 Apr 2020 12:46:41 -0700 Message-ID: <24218.1953.511534.341569@retriever.mtv.corp.google.com> References: <20200417165037.87CC5C22B24@raman-glaptop.localdomain> <24217.58861.727647.633990@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="12504"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 17 21:47:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPWxi-00038T-Rq for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 21:47:42 +0200 Original-Received: from localhost ([::1]:51304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPWxh-0007Ms-Eq for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 15:47:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40689) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPWwo-0006Uv-FL for emacs-devel@gnu.org; Fri, 17 Apr 2020 15:46:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPWwn-000891-DW for emacs-devel@gnu.org; Fri, 17 Apr 2020 15:46:46 -0400 Original-Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:44305) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPWwn-00086p-5t for emacs-devel@gnu.org; Fri, 17 Apr 2020 15:46:45 -0400 Original-Received: by mail-pf1-x42b.google.com with SMTP id p25so1523143pfn.11 for ; Fri, 17 Apr 2020 12:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=DR8n+dKIasrMotPKODnjTgjuoxhzssPBuPM5ahUevM4=; b=XFMeSGSIZ6ZvaHFPuIKsAKkGx3D3uSsTgTa4oeTSgUji/kx9E19PC1BLC9Gfo2HYGq uxmgkoyAls3K7sAbOYE1Wg/fxA0KrPJThDyfdIDVa2pyBzqL3+kP6Az4QQdBHIBDOKcL PLqskZR9nKSEuU1FmzpyoAQkmJDrhOKCkr38o2vqLhhRDOX2EwnCE80t5xM/vfav6ign 8AQ5agY7nU74wt1acmbtyyKGaJfm0gfanv5E28o9+5KZ7Ovi3qvBS8MY4L3nRvEAoYdb ucGA/kkmP9udrVnnSY08W8oNrQJ1hz66mKKfDBLnUGJE0ZLu4BLcJhYTEKDfaLaK6i99 9LFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=DR8n+dKIasrMotPKODnjTgjuoxhzssPBuPM5ahUevM4=; b=KeHanoqi751PuWWHYQIIJAh3jYfEvIP5LtyM9w48MQws60e28drQoNsblFR0kaJuVa 7gO4McyUq+acC5S4JkXqtyfVb4aw91+uMbPFVWhLYlAzFlKhP2uLvOE8HP/QNB35wN3Y U0AkBhHm4oblcVajjV1PYS2bAX258WAUaqVbF8hTvwbiHa92wI2JSvWEOgfVOZQA63b9 VkJeUWuc+m9cUMSaSc/0c222F73pphhZ+NMgAWG1qolaqUMRjWnZ376owyVSMGJb5/eM pWJhAahgD/eIBVR62IHmbiiFinUiR28+Ajs1b1GnIYDATx0HplaMQ2d08tDB/yb0mNK6 wKgw== X-Gm-Message-State: AGi0PuY/UuqG3o1vpNfOC4jNUnETAn0VmwGZGaVie2x9kmvGX4auT97V gf6iVHrM5OGza7HmkcnOkry0zOegkkE= X-Google-Smtp-Source: APiQypIgLb35OVSICIyGhX+3k8oVFrbJute4lZfz06WZ0WoK9owa0q71+9U8iY6CyTlejaR1ppZzMA== X-Received: by 2002:a62:4ed7:: with SMTP id c206mr4957267pfb.90.1587152803349; Fri, 17 Apr 2020 12:46:43 -0700 (PDT) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1510:1031:34f3:35d5:596f]) by smtp.gmail.com with ESMTPSA id a23sm14468406pfo.145.2020.04.17.12.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 12:46:42 -0700 (PDT) Original-Received: by retriever.mtv.corp.google.com (Postfix, from userid 13930) id 85EB618002E8; Fri, 17 Apr 2020 12:46:41 -0700 (PDT) In-Reply-To: X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247198 Archived-At: p.s. perhaps byte compilation has something to do with it --- all of emacspeak's modules are bytecompiled. Stefan Monnier writes: > > Is there any additional information that I can provide > > A reproduceable test case? > When I try > > M-: (defadvice sm-foo (before test activate) (message "before-advice")) RET > M-: (defun sm-foo () (message "body")) RET > M-: (sm-foo) RET > > the advice works just fine. > > > Stefan -- Id: kg:/m/0285kf1 -- Id: kg:/m/0285kf1