From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: master@head: completing-read behavior change? Date: Wed, 22 Jan 2020 16:03:33 -0800 Message-ID: <24104.58069.333584.189273@retriever.mtv.corp.google.com> References: <24104.57455.730537.220936@retriever.mtv.corp.google.com> <24104.57963.869782.597096@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="37786"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, emacs-devel@gnu.org To: raman@google.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 23 01:12:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuQ6q-0009nh-Sm for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 01:12:32 +0100 Original-Received: from localhost ([::1]:48766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuQ6p-0002Qb-Bk for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Jan 2020 19:12:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54663) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuPzM-0002B1-Mx for emacs-devel@gnu.org; Wed, 22 Jan 2020 19:04:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuPzB-00024u-2U for emacs-devel@gnu.org; Wed, 22 Jan 2020 19:04:43 -0500 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:38578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iuPzA-000249-SK for emacs-devel@gnu.org; Wed, 22 Jan 2020 19:04:37 -0500 Original-Received: by mail-pf1-f176.google.com with SMTP id x185so614800pfc.5 for ; Wed, 22 Jan 2020 16:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=U8EWA1Mvgst2oWen46bpLI+cTL2wVMl8PtWTcnhDz/M=; b=fQ3Ode9rYHXvsiV5x2ekBBSTSxoOdJZ6w+soxngZp9JPjbEEg3aNYPhhlXIIxAdm/i geV+rgdj1OWJIZxX5XrAQjILuKdIBttFM4odMFN8J3iGgpT0W9sgoluaJCrC0wHFNOPZ kxj4JWe3/r9HIJkuPe+8luZWJUeuU3rotZLWRH2g7Ph2WgyZivYzetXf//87XxGXLEnw 9kVqOuj3HXL5vqbNezbrjxyNlndyDEdjbpvnsjU6pJudvAptGj2A+hsIA0qrQWDgy9oU JfJjVb/2tBaBdjOEi2q1AVnn0YbyiU4AAKoH0WtWdfasWWVIdp4Qtg6Ip31cxfdu5Y0m uBZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=U8EWA1Mvgst2oWen46bpLI+cTL2wVMl8PtWTcnhDz/M=; b=PDkjbXdbv7Dvq+OesBm9/zfu5R9B1VuStXWRz2r5adu/HkqR8wBlJzVQxnVHP2AAGo Ej2x21yUSI8PbiuCtTVvH0SVGkTS5Dlki4bfJUQdADd3yq15Ki+opHdY5d/hrSC/FaW6 5BVOau75PCUFVmrW0AHrU5SwapT9UTzwO+pFW+2YS1diNda3D0u/LnDBt1lvz06SUnuz trappL55HWKp5IKcnFEFinsQgM9KsT9efQ/pm/T+ax8PXvgLSXjEzg15XfcEXK225oiH ebjG15fJGhl9nzktM8UA/w1xKaM9oCMkFCaxtZXhJ4g1wQ7rhCycIIyGgV/lXZ4rpMRJ In4g== X-Gm-Message-State: APjAAAUWlyCUn7gVZVVruuaZbnRUEc5og3oHwE/YmdQmDyBf4y0J+zBM J56y9HDwK4F2OZibvrppv7PrcjWY91Nhkg== X-Google-Smtp-Source: APXvYqzv2Fgp4gMoCUbPOs91zPw/0tE0NSA4IouRRtrTQcAVJeZfFsLAAn/1HN6roDqW5+Ogl1Kf3g== X-Received: by 2002:a63:554c:: with SMTP id f12mr926226pgm.23.1579737815288; Wed, 22 Jan 2020 16:03:35 -0800 (PST) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1510:1031:34f3:35d5:596f]) by smtp.gmail.com with ESMTPSA id x132sm64692pfc.148.2020.01.22.16.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2020 16:03:34 -0800 (PST) Original-Received: by retriever.mtv.corp.google.com (Postfix, from userid 13930) id 65280180039B; Wed, 22 Jan 2020 16:03:33 -0800 (PST) In-Reply-To: <24104.57963.869782.597096@retriever.mtv.corp.google.com> X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.210.176 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244527 Archived-At: Fix is here for the curious:-) https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ido.el#L85 T.V Raman writes: > Found it -- ido--overlay (apologies) > > I was looking at the wrong branch earlier. Now have it working in both > emacs 27 and emacs 28 > T.V Raman writes: > > Yes, you nailed the problem. I need to update how I handle ido-exhibit > > in my after advice. Thanks for the prompt help and pointer. > > Dmitry Gutov writes: > > > Hi T.V., > > > > > > On 23.01.2020 0:42, T.V Raman wrote: > > > > Could anyone tell me what changed in the behavior of completing-read > > > > between > > > > * (HEAD detached at 561ba2633e) > > > > and HEAD on master branch? > > > > > > I can't find the revision 561ba2633e, but it could be commit > > > 3b0938c0420de2b845e7e8f8fbbb57ddc61718f2. > > > > > > > From what I observe, something low-level appears to have changed how > > > > completing-read produces its final minibuffer prompt when ido is active. > > > > > > The aforementioned commit changed the way Ido's suggestions are > > > displayed: instead of being plainly 'insert'-ed, they are now an > > > 'after-string' property on an overlay placed at the end of the prompt > > > and input. > > > > > > > From emacspeak, I used to be able to speak the ido choices > > > > intelligently, now I just get the number of available choices spoken > > > > -- and the code on the emacspeak end hasn't changed. > > > > > > Does emacspeak work okay with icomplete-mode? The above is how the > > > latter has been displaying its suggestions for some time. > > > > > > This change has been made for better compatibility with the new way > > > messages are displayed while minibuffer is active (they are displayed > > > using the same mechanism). So I think emacspeak should learn to > > > understand this kind of rendering either way. > > > > > > Sorry for the inconvenience, though. > > > > -- > > Id: kg:/m/0285kf1 > > > > -- > > Id: kg:/m/0285kf1 > > -- > Id: kg:/m/0285kf1 > > -- > Id: kg:/m/0285kf1 -- Id: kg:/m/0285kf1 -- Id: kg:/m/0285kf1