From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: master@head: completing-read behavior change? Date: Wed, 22 Jan 2020 16:01:47 -0800 Message-ID: <24104.57963.869782.597096@retriever.mtv.corp.google.com> References: <24104.57455.730537.220936@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="1542"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, emacs-devel@gnu.org To: raman@google.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 23 01:04:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuPym-0000NN-7Z for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 01:04:12 +0100 Original-Received: from localhost ([::1]:48476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuPyl-0001Wk-6F for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Jan 2020 19:04:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53774) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuPxt-0000as-K1 for emacs-devel@gnu.org; Wed, 22 Jan 2020 19:03:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuPxW-00016v-JR for emacs-devel@gnu.org; Wed, 22 Jan 2020 19:03:14 -0500 Original-Received: from mail-pf1-f180.google.com ([209.85.210.180]:47021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iuPxW-00015H-Db for emacs-devel@gnu.org; Wed, 22 Jan 2020 19:02:54 -0500 Original-Received: by mail-pf1-f180.google.com with SMTP id n9so592231pff.13 for ; Wed, 22 Jan 2020 16:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=YgaB/7LgBOrfodxBdDCx29yBjaGYHOyn8vnEzZnOSX8=; b=BtEbX+J4Lb5fpzgF8MTIyXj+cDS0PLTq74B/GDVp2Qz9FxpSflXCGy0mZq+TIlWUAT F9LirVSkIbmIt25kLC2Yg2KBrwnfnxgNUQDQ7cyQ3Ra7i4AwbfW+v25YhVD2XsLNSc8F z1OXVb/ISzDe4Mq37CugNoFEoTUEdoJ33TjN+V1ewRBfCaeCfXT3uX2NQ2Dl28om0eWW EDdb7Ue2k+0lNeSlVW3maMK/ZeF3nEOm14UuNhZ31hAvs8g8/j+OsSKgZNmMQGgRhJ2R x7v+Gh2954FzBQ5GLeFtxQUq4W7cXhkQPGvgB8fVux/REZUQPVA71y5OUQftj8ZyxTmN E5Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=YgaB/7LgBOrfodxBdDCx29yBjaGYHOyn8vnEzZnOSX8=; b=ctsKxaufa+NazipPhNYQbANlEmOOq6T+fWXFlkZ+oiOX8PkhxGmcvdcztbbMmPstPR 9jeBU32PbXx4jP0fvYR9NtYyVE3OGp1pIv3hX2mGuUTD7Lj6ouhiiveO5kWxF7/cuo5a TMetBxwD3IbzZhy8rAznlqe9GapMWyxwB9gov/XXuz0ovBy++wtS/CyFOtYbgi6P6BeL PS1ril55ekWnDIylvnfVryT6RQVT8+U7NaWy4DFNCZUBbyb/OsjEez2n6LnajpX5u49x aEIRjsYNvPmdqN9Zldr9zdPS8VSphfT5i3ZdyPo0my59p75lcklQAr0nfaery2EgfvPJ GBmg== X-Gm-Message-State: APjAAAXFSQca+Ay3YN1q2cm5ympDbr92ES5wmuLNn6O+GRhqp4C6tqk4 0Km3W9Hnv82ieTCteADyS0ZM54F3d01euA== X-Google-Smtp-Source: APXvYqyqSwhwuegpgnTxsxT4mx4inAkYR2Op0vJLiWjBJn34bkPdwa0kj2xmEerVEYhPG4SJV/dbmw== X-Received: by 2002:a63:5a23:: with SMTP id o35mr870386pgb.4.1579737709989; Wed, 22 Jan 2020 16:01:49 -0800 (PST) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1510:1031:34f3:35d5:596f]) by smtp.gmail.com with ESMTPSA id z16sm64870pff.125.2020.01.22.16.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2020 16:01:48 -0800 (PST) Original-Received: by retriever.mtv.corp.google.com (Postfix, from userid 13930) id 047F1180039B; Wed, 22 Jan 2020 16:01:47 -0800 (PST) In-Reply-To: <24104.57455.730537.220936@retriever.mtv.corp.google.com> X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.210.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244526 Archived-At: Found it -- ido--overlay (apologies) I was looking at the wrong branch earlier. Now have it working in both emacs 27 and emacs 28 T.V Raman writes: > Yes, you nailed the problem. I need to update how I handle ido-exhibit > in my after advice. Thanks for the prompt help and pointer. > Dmitry Gutov writes: > > Hi T.V., > > > > On 23.01.2020 0:42, T.V Raman wrote: > > > Could anyone tell me what changed in the behavior of completing-read > > > between > > > * (HEAD detached at 561ba2633e) > > > and HEAD on master branch? > > > > I can't find the revision 561ba2633e, but it could be commit > > 3b0938c0420de2b845e7e8f8fbbb57ddc61718f2. > > > > > From what I observe, something low-level appears to have changed how > > > completing-read produces its final minibuffer prompt when ido is active. > > > > The aforementioned commit changed the way Ido's suggestions are > > displayed: instead of being plainly 'insert'-ed, they are now an > > 'after-string' property on an overlay placed at the end of the prompt > > and input. > > > > > From emacspeak, I used to be able to speak the ido choices > > > intelligently, now I just get the number of available choices spoken > > > -- and the code on the emacspeak end hasn't changed. > > > > Does emacspeak work okay with icomplete-mode? The above is how the > > latter has been displaying its suggestions for some time. > > > > This change has been made for better compatibility with the new way > > messages are displayed while minibuffer is active (they are displayed > > using the same mechanism). So I think emacspeak should learn to > > understand this kind of rendering either way. > > > > Sorry for the inconvenience, though. > > -- > Id: kg:/m/0285kf1 > > -- > Id: kg:/m/0285kf1 -- Id: kg:/m/0285kf1 -- Id: kg:/m/0285kf1