From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: delete-windows-on Date: Fri, 2 Oct 2009 13:31:38 -0700 Message-ID: <240EE4A03D004CFAA04A4B9AAC3EAD70@us.oracle.com> References: <8EA9172832C04915909AE7B506260481@us.oracle.com><4AC637A3.3070305@gmx.at> <47CD9C0ADBDC44CDA748F4978DF90DFE@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1254517831 22943 80.91.229.12 (2 Oct 2009 21:10:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Oct 2009 21:10:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'martin rudalics'" , "'Juanma Barranquero'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 02 23:10:24 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MtpOR-0001db-2S for ged-emacs-devel@m.gmane.org; Fri, 02 Oct 2009 23:10:23 +0200 Original-Received: from localhost ([127.0.0.1]:38075 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtpOQ-000584-C0 for ged-emacs-devel@m.gmane.org; Fri, 02 Oct 2009 17:10:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtonI-0002np-DH for emacs-devel@gnu.org; Fri, 02 Oct 2009 16:32:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtonD-0002l2-Bj for emacs-devel@gnu.org; Fri, 02 Oct 2009 16:31:59 -0400 Original-Received: from [199.232.76.173] (port=41182 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtonD-0002ku-0K for emacs-devel@gnu.org; Fri, 02 Oct 2009 16:31:55 -0400 Original-Received: from rcsinet12.oracle.com ([148.87.113.124]:27207 helo=rgminet12.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MtonC-0002c9-G6 for emacs-devel@gnu.org; Fri, 02 Oct 2009 16:31:54 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n92KVMjZ024865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 2 Oct 2009 20:31:24 GMT Original-Received: from abhmt003.oracle.com (abhmt003.oracle.com [141.146.116.12]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n92KWNJ4020338; Fri, 2 Oct 2009 20:32:23 GMT Original-Received: from dradamslap1 (/24.5.184.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 02 Oct 2009 13:31:38 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <47CD9C0ADBDC44CDA748F4978DF90DFE@us.oracle.com> Thread-Index: AcpDhXLYvqfggGu0TV2R4Fa5gj997QAAePZQAAJWLRA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt003.oracle.com [141.146.116.12] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4AC6632B.0105:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115871 Archived-At: Let me summarize the current state of the discussion and my questions/suggestions: 1. I suggested moving `delete-windows-on' to Lisp. Apparently, Martin already plans to do this, and the performance hit is expected to be negligible. 2. In Emacs 23, arg BUFFER is optional. Prior to Emacs 23, it is required. So the treatment of a nil BUFFER has changed. My objection was with the pre-23 approach; I was unaware of the new treatment. Dunno if this behavior change breaks any code - we'll find out, I guess. It is a user-visible change, in any case, so it should probably be in NEWS (it is not, so far). 3. Emacs 23 always returns nil. Dunno what the case was before 23. I don't have a problem with it always returning nil. I did suggest that we might instead return something indicating whether a window was actually deleted, similarly to how `kill-buffer' lets you know whether it killed the buffer. But this suggestion is not so important. 4. Raising an error for a non-string, non-buffer BUFFER arg is consistent with other functions. OK, I have no problem with that. 5. Raising an error for a string that does not name an existing buffer is wrong, IMO. No other opinions expressed about this, so far. 6. I suggested that for interactive use the completion candidates be limited to buffers that actually have windows. No other opinions expressed about this, so far.