unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'martin rudalics'" <rudalics@gmx.at>,
	"'Juanma Barranquero'" <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: RE: delete-windows-on
Date: Fri, 2 Oct 2009 13:31:38 -0700	[thread overview]
Message-ID: <240EE4A03D004CFAA04A4B9AAC3EAD70@us.oracle.com> (raw)
In-Reply-To: <47CD9C0ADBDC44CDA748F4978DF90DFE@us.oracle.com>

Let me summarize the current state of the discussion and my
questions/suggestions:

1. I suggested moving `delete-windows-on' to Lisp. Apparently, Martin already
plans to do this, and the performance hit is expected to be negligible.

2. In Emacs 23, arg BUFFER is optional. Prior to Emacs 23, it is required. So
the treatment of a nil BUFFER has changed. My objection was with the pre-23
approach; I was unaware of the new treatment. Dunno if this behavior change
breaks any code - we'll find out, I guess. It is a user-visible change, in any
case, so it should probably be in NEWS (it is not, so far).

3. Emacs 23 always returns nil. Dunno what the case was before 23. I don't have
a problem with it always returning nil.

I did suggest that we might instead return something indicating whether a window
was actually deleted, similarly to how `kill-buffer' lets you know whether it
killed the buffer. But this suggestion is not so important.

4. Raising an error for a non-string, non-buffer BUFFER arg is consistent with
other functions. OK, I have no problem with that.

5. Raising an error for a string that does not name an existing buffer is wrong,
IMO. No other opinions expressed about this, so far.

6. I suggested that for interactive use the completion candidates be limited to
buffers that actually have windows. No other opinions expressed about this, so
far.

 





  reply	other threads:[~2009-10-02 20:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 16:16 delete-windows-on Drew Adams
2009-10-02 16:30 ` delete-windows-on Juanma Barranquero
2009-10-02 16:47   ` delete-windows-on Drew Adams
2009-10-02 16:51     ` delete-windows-on Juanma Barranquero
2009-10-02 17:25       ` delete-windows-on martin rudalics
2009-10-02 17:55         ` delete-windows-on Drew Adams
2009-10-02 20:31           ` Drew Adams [this message]
2009-10-03  5:52             ` delete-windows-on Stephen J. Turnbull
2009-10-02 17:37       ` delete-windows-on Drew Adams
2009-10-02 18:27         ` delete-windows-on Stephen J. Turnbull
2009-10-02 17:25 ` delete-windows-on martin rudalics
2009-10-02 17:39   ` delete-windows-on Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=240EE4A03D004CFAA04A4B9AAC3EAD70@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).