From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 70477be3e3: Add treesit-sentence-type-regexp Date: Mon, 16 Jan 2023 01:11:45 +0200 Message-ID: <2400ad68-feba-6ca5-f9a8-d1c3fba361d7@yandex.ru> References: <167381756429.3910.17256789883608704168@vcs2.savannah.gnu.org> <20230115211924.B4D26C00A7F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19615"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: emacs-devel@gnu.org, Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 16 00:12:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHCB1-0004zp-7s for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Jan 2023 00:12:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHCAL-0004h9-Hd; Sun, 15 Jan 2023 18:11:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHCAJ-0004gg-5s for emacs-devel@gnu.org; Sun, 15 Jan 2023 18:11:51 -0500 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHCAH-0001VX-88 for emacs-devel@gnu.org; Sun, 15 Jan 2023 18:11:50 -0500 Original-Received: by mail-ej1-x62c.google.com with SMTP id ud5so64317892ejc.4 for ; Sun, 15 Jan 2023 15:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=h+jxrBQsenrUTQTXr6OLYIJgTOoBJHou/DMAIDiy+I8=; b=EPEmJj3T8ztWSEZ/g0CIRrzfzQpswl26Q4bn7SUT+vp3G384Of+ZHcCgbiXO2CF4WA dMpA5uHTiIT7S5O14RNg7Hp0g7irWL8feo+Iviv7Yx8wFCtOM4ZVGZarGuowUomRx/5q +oU1yR5rzzNWs5KjYEjcRj3N+IMa1ejTIYNArGlUojD4T1tSWGBMQOL3EWQoVZsnMhVT JHE+egnUBtMwVKdF9BC0+F2JQOhRW4Ynu9oOKyXrckqXFIXwHO19PrX79qBCC0K+IxCO i9rUAfMDKQgkXbfbRxhYgLFYiWsVAGrpA65Bd3q0uIUDfrc8Ap+57QhRKwkxlllYv1We L4xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h+jxrBQsenrUTQTXr6OLYIJgTOoBJHou/DMAIDiy+I8=; b=L8u6FmaKQwO3bWrwOP5U5xLZA+CMugiWuKP0ozNIypiQVss+m7kvxV5OaU66Gn5JUB TrXMy7XjKWaj1IorhXMReNc1RC82oJTd/Cb1nXUvGatJNg+vTXR4GKZfs4jkpTtQkwOh eqfZrURKsi0WWBksjNQFGv4W1hVkvmJeQojcWA42PqTxyN34IWA1iztle2u18DPprYpW WV0fGamiATg9JlY5RhlBeGEt60z3WyU4TkbqhN+Ixhi1wJr3JASgxQc4Rw7RWVIak/BN J6ZcdDMyFJc9Wl8LAMUQqCsmMLZP6L/DupqbT9rq9ubXcStE9uMX0ZhoJcvLj5Oy9oO8 mIWg== X-Gm-Message-State: AFqh2kqh3yAPXrRbCe4JduKDmXSIgM07JFVX9pBLdMPM6pnERVt4x0Sn KwvnJsxBu12+Cqq9x0MOfj3wYEjLr0Q= X-Google-Smtp-Source: AMrXdXucDK6WlyyKgTar2eagNE8IxxQuHXWY7aJU+W0iL4Si/SfW6alJhoRr0E78D0XkjJl74xzUmQ== X-Received: by 2002:a17:907:3a09:b0:867:ef3f:dd89 with SMTP id fb9-20020a1709073a0900b00867ef3fdd89mr9611739ejc.13.1673824307440; Sun, 15 Jan 2023 15:11:47 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l1-20020a1709063d2100b0086d70b9c023sm2024692ejf.63.2023.01.15.15.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 15:11:46 -0800 (PST) Content-Language: en-US In-Reply-To: <20230115211924.B4D26C00A7F@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=raaahh@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302438 Archived-At: On 15/01/2023 23:19, Theodor Thornhill via Mailing list for Emacs changes wrote: > +(defvar js--treesit-sentence-type-regexp If the variable is called -regexp, the value should already be put through the 'regexp-opt' call, rather than have it called inside the major mode body. Or we could call the vars differently.