unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Theodor Thornhill <theo@thornhill.no>
Subject: Re: master 70477be3e3: Add treesit-sentence-type-regexp
Date: Mon, 16 Jan 2023 01:11:45 +0200	[thread overview]
Message-ID: <2400ad68-feba-6ca5-f9a8-d1c3fba361d7@yandex.ru> (raw)
In-Reply-To: <20230115211924.B4D26C00A7F@vcs2.savannah.gnu.org>

On 15/01/2023 23:19, Theodor Thornhill via Mailing list for Emacs 
changes wrote:
> +(defvar js--treesit-sentence-type-regexp

If the variable is called -regexp, the value should already be put 
through the 'regexp-opt' call, rather than have it called inside the 
major mode body.

Or we could call the vars differently.



       reply	other threads:[~2023-01-15 23:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167381756429.3910.17256789883608704168@vcs2.savannah.gnu.org>
     [not found] ` <20230115211924.B4D26C00A7F@vcs2.savannah.gnu.org>
2023-01-15 23:11   ` Dmitry Gutov [this message]
2023-01-16  6:04     ` master 70477be3e3: Add treesit-sentence-type-regexp Theodor Thornhill
2023-01-16 11:30       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2400ad68-feba-6ca5-f9a8-d1c3fba361d7@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).