From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: RE: Please add comments to isearch.el
Date: Sun, 29 Nov 2015 08:54:39 -0800 (PST) [thread overview]
Message-ID: <23d71522-5e32-4fff-b8ae-369716c2dbb2@default> (raw)
In-Reply-To: <<83fuzoojcn.fsf@gnu.org>>
> Would someone "in the know" please add commentary to isearch.el to
> explain how the various options are passed to the commands defined
> there and affect or not affect them?
>
> The isearch.el commands are implemented using complex multi-layered
> system of functions and macros that make it very hard to figure out,
> just by looking at the code, which options affect what commands and in
> what ways. About the only way to find that out is by trying each
> command, which is very inefficient. I think it will help make this
> file much more maintainable if commentary were added there explaining
> how all of this works. Thanks in advance.
+1
Particularly as regards the state structure and updating it.
next parent reply other threads:[~2015-11-29 16:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<83fuzoojcn.fsf@gnu.org>
2015-11-29 16:54 ` Drew Adams [this message]
2015-11-29 16:34 Please add comments to isearch.el Eli Zaretskii
2015-12-11 8:13 ` Eli Zaretskii
2015-12-11 12:16 ` Alan Mackenzie
2015-12-11 12:39 ` Eli Zaretskii
2015-12-11 16:00 ` Artur Malabarba
2015-12-11 16:20 ` Eli Zaretskii
2015-12-11 16:54 ` Artur Malabarba
2015-12-11 16:56 ` Drew Adams
2015-12-11 18:33 ` Eli Zaretskii
2015-12-11 22:59 ` Juri Linkov
2015-12-11 23:24 ` Artur Malabarba
2015-12-11 23:55 ` Juri Linkov
2015-12-12 7:25 ` Eli Zaretskii
2015-12-12 23:27 ` Juri Linkov
2015-12-13 1:01 ` Artur Malabarba
2015-12-14 0:16 ` Juri Linkov
2015-12-14 1:19 ` Artur Malabarba
2015-12-14 23:51 ` Juri Linkov
2015-12-15 10:26 ` Artur Malabarba
2015-12-16 0:51 ` Juri Linkov
2015-12-16 9:06 ` Artur Malabarba
2015-12-17 0:55 ` Juri Linkov
2015-12-17 10:19 ` Artur Malabarba
2015-12-13 3:38 ` Eli Zaretskii
[not found] ` <<83d1uc6sdq.fsf@gnu.org>
2015-12-12 16:20 ` Drew Adams
2015-12-12 23:04 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d71522-5e32-4fff-b8ae-369716c2dbb2@default \
--to=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).