From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: master 05705454d5: Don't transfer window attributes trying to find the XM drag window Date: Mon, 19 Sep 2022 18:14:30 +0200 Message-ID: <238cda45-7aec-59be-d032-ef29e5dd5bf0@gmx.at> References: <0850989a-ce12-5b35-8dfd-51c244a2b407@gmx.at> <87pmfsrvqp.fsf@yahoo.com> <93a7c78d-efef-d69d-b70c-6dc9ac1f7d8e@gmx.at> <87tu53rfjx.fsf@yahoo.com> <91cb7982-ef2a-3338-78c9-534f0712dc1e@gmx.at> <87y1ufpzei.fsf@yahoo.com> <5421ac1b-f40c-7a80-5908-b6facca037d3@gmx.at> <87tu53oef8.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39655"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 19 18:19:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaJUe-000ADB-HW for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 18:19:36 +0200 Original-Received: from localhost ([::1]:56262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaJUd-0001TP-IX for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 12:19:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaJQ4-0006TP-0H for emacs-devel@gnu.org; Mon, 19 Sep 2022 12:14:53 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:47083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaJPo-0004qC-Cj for emacs-devel@gnu.org; Mon, 19 Sep 2022 12:14:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663604071; bh=HcFz417koTURO9YTzmwR6LAxfKuGmMnYS1i7ARVpuwc=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=dLNIpc91Ixv9S2ytbjJix8/O8NFtluYl61tUmiiyI2nrh4AlSHJu+8zULpVmdw3nP MTq6mqvtxtHctAlm3g+07Co84lp32WmOdm0h/N3gb67Frdepv56lz0rJ7yWM/Td6la J3G0U4J64yDESYUMK5wInbJwhj7vlVCxLkYz+moo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.29]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M5QF5-1obgKA2adJ-001RLY; Mon, 19 Sep 2022 18:14:31 +0200 Content-Language: en-US In-Reply-To: <87tu53oef8.fsf@yahoo.com> X-Provags-ID: V03:K1:umBM9SlGIwR1S69dck24ZWMeRahay01wc3EQomiAzFXABgWGiwl 7ffi1XnblsjRUVL4eCefsp3Ar/sfL6DaNy2x2L+dvXt3mUysEBozArp57QBpchEJEpH6A29 VAv9sHWLweX9ce/7rEpANOf93AVoo94QlNt2xes1pqyK8uKsAasxYqV9KOXnP4YKcqEkt3J 9OillUJ2D/dLp7kVUAitA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZI5Kw2Ow3jc=:piPiqvN8TM16Ast2RT+wEQ 6+9T6ixiniZJgPB33uxhWv5Gjt7JH/snfQuW6QsZNu+YRVBYXiYlIslJFddoV9Ste1Qi0NPBL KJh1b6AKoyCFUdPI/38HycCQi3BqTEiR9gOfh7GGji+Se0VHqn5HIud01dFTguQoMo8PLMZ0w JkcNNAK29oIv0GSilD9QVAOi1Q6w7N0X5OnEp/ZHhS1gYF+mxMpa9fEfFrCh8aZZRkH3s/249 3E1vOTZ/mdE9CTGJWBBpB3t9WasZ6f74mJS04ZGkMHcrgbShuEWQ4CLN2b/jBUScEcQZWSy3z brSqS4j8L0xfRMUn0TQEjl0OH0oPSDKfjogjS8VNhcDsWQItm5l8KT+PXFdJAn20YXRAbxGLm dxDC9yTHUesKdiSDc4cHFk5/LxkQy4eYkSHKQuCQ8WCDbBZnj+k0uoaRRlHUnrs55iual/Bxt en7he6WqvQFeqU2/oUtI1+Wm0Pd12ejmBvsNToLuiEY+BL18LE60/OGvfmSLNueRebpRrozGF 16OYQu4m+hHel7GBROlSkpMb/2ibz+jhF6ZoVOlilE579zE+H21vu/mLgQ0hT/YVjPZ4OXTsM 7VW75HKC8lM4R4UPnPzX6XJvR3SnsIiG0WZQFAvSOd+WQS4ocLJe1+q4yBNNiSyjO5iKYInbg KvX0q3IfGO32IaZfgmChVPJuZ6/ONKxcgqWcbddA1ih96QTqryhpDc8J0WItjzlVfI9nSa0gV BdWfkfELDIC11TIwvl+MUDgPpsP8NsiRw/r+nBplnps1l1oM2jpOEjvrM6i2boUxHUeZoYm6 Received-SPF: pass client-ip=212.227.15.15; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295717 Archived-At: > I'm thinking of the place where keyboard.c calls handle-focus-in, namely > here: ... > call4 (Qcommand_execute, tem, Qnil, Fvector (1, &last_input_event), Qt); <=== What would you want to do here? Bow out if the first element is a dead frame or window? That still doesn't protect us from having two functions on such a hook where the one running first deletes the frame. So while I think that your suggestion probably won't harm, it might still not catch us all use cases. We could invent things like 'run-frame-hook-with-args' that checks whether the frame is still live before calling the next function on the hook. But ultimately my first proposal to have 'x-dnd-after-move-frame' check whether the frame is live might still be the safest solution. Plus adding some text that all functions on any of these hooks should check whether their frame, window, ... argument is live. In particular when they are installed by default as 'x-dnd-after-move-frame'. Incidentally, the problem I see seems to show up because I'm using a stand-alone minibuffer frame and when that is made in 'frame-notice-user-settings', master kills the initial frame. I haven't tried to find out who moves that initial frame before that though. martin