From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: empty-directory predicate, native implementation Date: Sat, 17 Oct 2020 13:03:35 -0700 (PDT) Message-ID: <237bd21b-96c7-4433-a5bc-34b64a9f4250@default> References: <83y2ka18t7.fsf@gnu.org> <87y2kaj799.fsf@gmx.de> <83blh60wgr.fsf@gnu.org> <87h7qxjh7g.fsf@gmx.de> <878sc8kgy8.fsf@gmx.de> <87imbcls71.fsf@gmx.de> <83eem0zt0b.fsf@gnu.org> <87k0vsrd6m.fsf@gmx.de> <83a6wozs7h.fsf@gnu.org> <87sgafq2e2.fsf@gmx.de> <87h7qvptm3.fsf@gmx.de> <871rhxp8we.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23115"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Arthur Miller , Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 17 22:05:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTsSG-0005u9-1h for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Oct 2020 22:05:28 +0200 Original-Received: from localhost ([::1]:53822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTsSF-0008Jt-3Y for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Oct 2020 16:05:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTsR0-0007mZ-7I for emacs-devel@gnu.org; Sat, 17 Oct 2020 16:04:10 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:44172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTsQx-00017m-R0; Sat, 17 Oct 2020 16:04:09 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09HJtNkl079764; Sat, 17 Oct 2020 20:03:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=LvNyjhs/Ph565y83U15xCh4NNiI52DFO4A8UUjV7lfE=; b=Nd33I+IL+mGeVALHWXWs/HTBLBa2AsvTcMJVReq1HXFVZ5/xcWEbpdKLJ7A7NFkPXmBZ ZNc0bhMnZoUje76EUXCluvxepUlOTgTVXtx+3AvehEChHFWi5w4r67YhkvoddBgL5kXp qdRWn8kHsqA15rq9LuFWNVFKqo1ur1R+wYRmfbd8WX40wZayupp5TWes+pcvyPnZQPfU kQw3+b1IYxngMTaHUf+SPmeno4ReYkY8cJ5sVYR9JywHR7E4qUjqFIt+gX8NdH3E6U5k sxoJ4EGkn4zkWkZaLzNHncdDAYn77iahM13qPjqVETuOmUxFFGEBOBplDPacsjMO9ONT MQ== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 347rjkh8hp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 17 Oct 2020 20:03:40 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09HJxqmO184452; Sat, 17 Oct 2020 20:03:40 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 347pn8tcjb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 17 Oct 2020 20:03:40 +0000 Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 09HK3ars019269; Sat, 17 Oct 2020 20:03:36 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9777 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010170143 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9777 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 clxscore=1015 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010170142 Received-SPF: pass client-ip=141.146.126.78; envelope-from=drew.adams@oracle.com; helo=aserp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/17 13:11:31 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257969 Archived-At: Sorry I'm coming to this late. It's a long thread, and I've only checked your patch, not the messages. I don't understand why we would do this. Is the real aim to be able to have an empty-directory predicate, i.e., to be able to see if there are no files in a directory? If so, then why not do just that, witout bothering (changing the signature of) `directory-files'? Is there really some use case for getting only the first N files in a directory? I can understand wanting to test whether a dir is empty. I can't see why someone would want the first N files (however "first" might be defined). The doc string itself seems to suggest that the (only?) use case is to test for emptiness: You can use this function to short circuit evaluation in case you are just interested to find if a directory is empty or not (request one file and tell it to ignore dot-files). That need is clear enough. But what else is COUNT useful for? How about having the doc string also tell us what we can use a COUNT value > 1 for? That's the case that really needs pointing out, not the empty-dir-p case. And what is the order that defines which file is first, second, etc.? Without knowing that, what use is getting the "first" N? If this has already been raised, discussed, and dismissed, fine - apologies for the noise. If not, what's the raison d'etre for adding optional parameter COUNT? Why not just add a predicate `directory-empty-p'?