From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 06:54:10 -0700 Message-ID: <230e1b8e13eed00f47c1119ec6d619e4.squirrel@dancol.org> References: <87imsvuvnr.fsf@wavexx.thregr.org> <20190624111050.jindvg6j4hr5j226@Ergus> <20190624122841.vfezkecaxjqwzjy3@Ergus> <20190624135046.x4r54hwj4yzfea5t@Ergus> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204377"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.23 [SVN] Cc: Yuri D'Elia , Yuri Khan , Daniel Colascione , Emacs developers To: "Ergus" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 15:57:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfPTY-000r3R-Af for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 15:57:40 +0200 Original-Received: from localhost ([::1]:51388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPTX-0002ET-8Y for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 09:57:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44176) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPQM-0007F8-Fz for emacs-devel@gnu.org; Mon, 24 Jun 2019 09:54:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfPQG-0002AL-S8 for emacs-devel@gnu.org; Mon, 24 Jun 2019 09:54:19 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:37174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfPQF-00027M-8b for emacs-devel@gnu.org; Mon, 24 Jun 2019 09:54:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=T4wCQf6SFA4CW1XhsWpBTMxBbMEOztkdMdaC1l0Q6ic=; b=qDFJBmKKE4rwzS3ryXvcePeoUgVJhQzjTvAWVmKCnQMjkpFJsDYKVyZ+SNaTQpfKDMbKULx2UtlpQWg2hSRj93y7FKP9iu+W45BphJVLGrZYb2lbT4ty38UqPQz4cMbU4T39d1+J+L59YZ4bOl1rl7+H9TAYOlRQvBIxfOcjwmlo9CqEBBrvAYE8MBuTAwPAemXNYQ+5RPmgDm5nBupNcRCSHd9ljQHHuiMFKFIko+exNr2efnzLKxLuQTP+05WywJE8gE2yFixhLN7gGhSkp1kIhC28EAdevffU3bSzRvxL5L93APqohJkpU7sDHD4tLQfzpqXJ6rEnfpSXYoWk4A==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfPQA-0008UZ-5F; Mon, 24 Jun 2019 06:54:10 -0700 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Mon, 24 Jun 2019 06:54:10 -0700 In-Reply-To: <20190624135046.x4r54hwj4yzfea5t@Ergus> X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238096 Archived-At: > On Mon, Jun 24, 2019 at 06:21:12AM -0700, Daniel Colascione wrote: >>> On Mon, Jun 24, 2019 at 06:57:32PM +0700, Yuri Khan wrote: >>>>On Mon, Jun 24, 2019 at 6:12 PM Ergus wrote: >>>> >>>>> 750| char* argv0 = realpath (argv[0], NULL); >>>>> 751| if (!argv0) >>>>> 752| fatal ("could not resolve realpath of \"%s\": %s", >>>>> 752| argv0, strerror (errno)); >>>> >>>>This looks wrong. If we called realpath and it returned null, we???d >>>>probably want the original argv[0] in the error message, not the null >>>>result. >>>> >>> >>> This also produces problems when using emacs from an alias like em o >>> emc >>> which is a very common practice. >>> >>> So there should be actually other conditions to try if the first >>> realpath call fails and not abort (call fatal) in the first try. >> >>Try it now. Sorry about the botched change. >> >> > Hi Daniel: > > Did you pushed any change too savannah/master? Graph. Of course the push failed. *Now* try it. :-)