From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Phillip Lord" Newsgroups: gmane.emacs.devel Subject: Re: Reformat all of src/ Date: Wed, 28 Dec 2016 12:58:51 -0000 Message-ID: <228ccc55affe1320a030a5652c63e005.squirrel@cloud103.planethippo.com> References: <87h95olvg0.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1482930034 25693 195.159.176.226 (28 Dec 2016 13:00:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Dec 2016 13:00:34 +0000 (UTC) User-Agent: SquirrelMail/1.5.2 [SVN] To: "Chris Gregory" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 28 14:00:27 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMDq6-0004WE-Ew for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2016 14:00:18 +0100 Original-Received: from localhost ([::1]:58944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMDq8-0006aa-2b for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2016 08:00:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMDpW-0006aS-DI for emacs-devel@gnu.org; Wed, 28 Dec 2016 07:59:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMDpT-0005Ee-7H for emacs-devel@gnu.org; Wed, 28 Dec 2016 07:59:42 -0500 Original-Received: from mailgw.mycpanelcloud.co.uk ([185.116.214.205]:50464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cMDpS-0004tR-PX for emacs-devel@gnu.org; Wed, 28 Dec 2016 07:59:39 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id 627C7C42F3 for ; Wed, 28 Dec 2016 12:58:32 +0000 (GMT) X-Virus-Scanned: by SpamTitan at mycpanelcloud.co.uk Original-Received: from mailgw.mycpanelcloud.co.uk (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id B4468C4174 for ; Wed, 28 Dec 2016 12:58:29 +0000 (GMT) Original-Received: from cloud103.planethippo.com (cloud103.planethippo.com [31.216.48.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTPS id A8CE3C415D for ; Wed, 28 Dec 2016 12:58:29 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:To:From:Subject:Date:References:In-Reply-To:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=C7NFzir89vHa+Wobpz28aWlh8619kDcGKeLX93tCc8Q=; b=hGdU0hdnR19/JIHRw1vN1otzdq V5fKWXZ7uTBa0tgy0MrwRRsd6ozMzyHhx/hvycDyTtKRXy/CLDX68s98cmV0gkr7oQFD6GefN3A0l Z/ukyB8ncEPvkDVgzXS1kDGiXhhjwjE9LXl7pcqG5EPwwdbxVyjF2gwpnVD4grc83pRsDFp4WsxmI xcgy8I9Ky+BUpSlgTEv8mB2u0ye0Btfd7f8dVMXIgMcNr2d3vfvBqDyQ5QZe9aNuTuKzOhJK5X9Q3 Nip06fvDQgAcav08rJiXb0KkUrrBQskYhZB1VgUpkUcjlteccdTJ7SckyYNk5gRhPHg7yHtZcC3Uo UoGq3l1Q==; Original-Received: from [127.0.0.1] (port=52558 helo=cloud103.planethippo.com) by cloud103.planethippo.com with esmtpa (Exim 4.87) (envelope-from ) id 1cMDoh-000LHh-Rz; Wed, 28 Dec 2016 12:58:51 +0000 Original-Received: from 151.65.192.198 ([151.65.192.198]) (SquirrelMail authenticated user phillip.lord@russet.org.uk) by cloud103.planethippo.com with HTTP; Wed, 28 Dec 2016 12:58:51 -0000 In-Reply-To: X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x [fuzzy] X-Received-From: 185.116.214.205 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210882 Archived-At: On Wed, December 28, 2016 4:45 am, John Wiegley wrote: >>>>>> "CG" =3D=3D Chris Gregory writes: >>>>>> > > CG> I found it irritating that there was inconsistent usage of tabs and > spaces CG> at the beginning of lines. So I reformatted the entirety of = the > src CG> directory such that all lines that begin with 8 spaces now begi= n > with CG> tabs, and all lines that begin with 1 tab and 8 spaces now beg= in > with 2 CG> tabs, and so on. > > > Hi Chris, > > > I appreciate the other cleanup changes you've made, but I must reject > this one. Feel free to fix whitespace along with other changes you make= to > a given area of code, but bulk changes like this do nothing but cure a > problem people aren't having, while hurting our history and blame tools= . Why not patch up dir-locals.el to switch on whitespace.el, and highlight bad spacing? At the moment, the spacing is inconsistent enough that I don't know which spacing is considered correct and highlighting would hel= p to define this. As Chris says, it's somewhat inconsistent at the moment, so copying nearb= y lines doesn't really help. FWIW (not very much) I think tabs suck...