From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Sun, 6 Jun 2021 14:01:26 +1000 Message-ID: <228099F1-BAB6-4E3A-AD0F-FB4282817CEB@bydasein.com> References: <9cdf9d6dc55ccd4894d758d3237b0be2@purelymail.com> <03FB7137-A02D-4B94-AF1F-8B7E84DEF5DB@bydasein.com> <39fa782b82e274d3e9c40e934df89d68@purelymail.com> <4cf0b73bcefc7d159881d368b3a4b7f5@purelymail.com> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Apple-Mail=_B53D715F-D5D4-4174-A719-9B548E5FB6AA" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19665"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 06 06:03:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpk01-0004nx-32 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 06:02:57 +0200 Original-Received: from localhost ([::1]:45784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpjzz-0000Wi-NC for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 00:02:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpjzC-0008FI-1B for emacs-devel@gnu.org; Sun, 06 Jun 2021 00:02:06 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:40602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpjz9-0002EF-1m for emacs-devel@gnu.org; Sun, 06 Jun 2021 00:02:05 -0400 DKIM-Signature: a=rsa-sha256; b=zA+Kxk9kHA64jSwx6iQSGfjgoLDf4dg5Vmpj9JeTfb7YmsRAJYwtPWYMlm8ee0eQ2HVkHI9eN7UOsixavrU1IflczIYzAegfkjIxLmuc4u9Y0AQZ3T1SNco2QBqvey8Xaa0jubiCG0Y4pK0y3peTKFt0M86HhSM3F+gYLYqJ9VS4r71qbyeNkq/U8ZBeiro8KXeljnaTycJpvlJ++p5aGJDbj37DzOCfo1jOHzNzq7M0FmCbQ1h7dkG4j52FGQ8DAyy7YaMocYV+NRFd/OmnocvTEIWSEvYjyTvRIpRiBHMT8FNWGnpu7+8h/Jl0sqDSJliCjDw0uSIxZkOhV0nD9g==; s=purelymail3; d=bydasein.com; v=1; bh=hUAUegLDEnK0UI7ItfaMMPgRMlS+EndyT/Hmf78TN2Q=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=ecr9Wg+gH7tgv3yqLPe15RXxNC1ZeHPPluZVqP2yfkISYqIF9bLLjzqGH2popj+9uD+6U+8pTtoq5MK2cgX7yniHIV2P8b5HS3Ll7KOHGezFRb7lU2IfW1qlA7UZ+VthZvNAX1Ikri5sjqroQrvbWO6O884T9iA/tXl0UUFMQPDAYAnmlTsqcO8yvNuFvAsmxzz4vKvhrrUMaxIQo39y+8Yz+a6LR86l7NUTH11vRTmB4VSCHYnNpZPdAlvJRFoRHnQycu1O+iM2SQZkpJfSuKdvbho7+/Yy6Bq/ADee+OeW/v96frFLdHYmShznxAzWgk5Gqyvb8rQle4FJ9oI9Sg==; s=purelymail3; d=purelymail.com; v=1; bh=hUAUegLDEnK0UI7ItfaMMPgRMlS+EndyT/Hmf78TN2Q=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-164.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -2098115302; Sun, 06 Jun 2021 04:01:32 +0000 (UTC) In-Reply-To: X-Mailer: Apple Mail (2.3654.100.0.2.22) Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270457 Archived-At: --Apple-Mail=_B53D715F-D5D4-4174-A719-9B548E5FB6AA Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On 6 Jun 2021, at 6:58 am, Alan Third wrote: > > On Wed, May 26, 2021 at 08:56:19PM +0100, Alan Third wrote: >> On Sun, May 16, 2021 at 07:16:54PM +1000, Paul W. Rankin wrote: >>> >>> I've attached two patches: 0001 is to remove the explicit setting of >>> NSWindowTabbingModeDisallowed; >> >> If you write up a wee NEWS entry, I'll be happy to push this change to >> master and we can see is anyone shouts. :) >> >> Please make sure to mention where to go to turn off tabbing. > > Hi Paul, did you get a chance to add a NEWS entry? If you don't have > the time (or feel confident enough), please send a small > description of what's changed and how to disable the tab-bar and I'll > finish it up. Hi Alan, Sorry I was just being lazy. Attached! --Apple-Mail=_B53D715F-D5D4-4174-A719-9B548E5FB6AA Content-Disposition: attachment; filename=0001-src-nsterm.m-fix-window-tabbing-on-macOS.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-src-nsterm.m-fix-window-tabbing-on-macOS.patch" Content-Transfer-Encoding: quoted-printable =46rom=2041fafc79a7371be9244460fca0c6b8d3c053de8c=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Paul=20W.=20Rankin"=20=0A= Date:=20Sat,=208=20May=202021=2019:09:59=20+1000=0ASubject:=20[PATCH]=20= src/nsterm.m:=20fix=20window=20tabbing=20on=20macOS=0A=0A*=20= src/nsterm.m:=20remove=20NSWindowTabbingModeDisallowed=20to=20respect=0A=20= =20system-wide=20preferences=0A*=20etc/NEWS:=20add=20mention=20of=20= native=20tab=20support=20in=20macOS=20and=20where=0A=20=20to=20specify=20= system-wide=20setting=0A---=0A=20etc/NEWS=20=20=20=20=20|=208=20++++++++=0A= =20src/nsterm.m=20|=208=20--------=0A=202=20files=20changed,=208=20= insertions(+),=208=20deletions(-)=0A=0Adiff=20--git=20a/etc/NEWS=20= b/etc/NEWS=0Aindex=2032d7c4fe18..a3073d2033=20100644=0A---=20a/etc/NEWS=0A= +++=20b/etc/NEWS=0A@@=20-3110,6=20+3110,14=20@@=20The=20new=20variable=20= 'xwidget-webkit-download-dir'=20says=20where=20to=20download=20to.=0A=20= 'module-file-suffix'=20now=20has=20the=20value=20".dylib"=20on=20macOS,=20= but=20the=0A=20".so"=20suffix=20is=20supported=20as=20well.=0A=20=0A++++=0A= +**=20On=20macOS,=20Emacs=20now=20supports=20native=20tabs=20(available=20= in=20macOS=2010.12=0A+and=20later).=20=20Native=20tabbing=20behavior=20= is=20specified=20system-wide=20via=0A+System=20Preferences,=20under=20= under=20General=20>=20'Prefer=20tabs=20when=20opening=0A+documents'.=20= In=20macOS=20versions=2010.15=20and=20earlier,=20this=20option=20is=0A= +located=20under=20Dock=20instead.=20Note=20that=20this=20feature=20is=20= unrelated=20to=20the=0A+Emacs=20'tab-bar-mode'.=0A+=0A=20+++=0A=20**=20= On=20MS-Windows,=20Emacs=20can=20now=20toggle=20the=20IME.=0A=20A=20new=20= function=20'w32-set-ime-open-status'=20can=20now=20be=20used=20to=20= disable=0Adiff=20--git=20a/src/nsterm.m=20b/src/nsterm.m=0Aindex=20= bb20886ab1..5fd4885801=20100644=0A---=20a/src/nsterm.m=0A+++=20= b/src/nsterm.m=0A@@=20-7628,14=20+7628,6=20@@=20-=20(instancetype)=20= initFrameFromEmacs:=20(struct=20frame=20*)f=0A=20=20=20=20=20=20=20=20=20= =20selector:@selector=20(viewDidResize:)=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20name:NSViewFrameDidChangeNotification=20object:nil];=0A=20=0A= -=20=20/*=20macOS=20Sierra=20automatically=20enables=20tabbed=20windows.=20= =20We=20can't=0A-=20=20=20=20=20allow=20this=20to=20be=20enabled=20until=20= it's=20available=20on=20a=20Free=20system.=0A-=20=20=20=20=20Currently=20= it=20only=20happens=20by=20accident=20and=20is=20buggy=20anyway.=20=20*/=0A= -#ifdef=20NS_IMPL_COCOA=0A-=20=20if=20([win=20respondsToSelector:=20= @selector(setTabbingMode:)])=0A-=20=20=20=20[win=20setTabbingMode:=20= NSWindowTabbingModeDisallowed];=0A-#endif=0A-=0A=20=20=20= ns_window_num++;=0A=20=20=20return=20self;=0A=20}=0A--=20=0A2.30.1=0A=0A= --Apple-Mail=_B53D715F-D5D4-4174-A719-9B548E5FB6AA--