Re: src/nsterm.m: fix window tabbing on macOS

["Paul W. Rankin" via "Emacs development discussions." <emacs-devel@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]


> On 6 Jun 2021, at 6:58 am, Alan Third <alan@idiocy.org> wrote:
> 
> On Wed, May 26, 2021 at 08:56:19PM +0100, Alan Third wrote:
>> On Sun, May 16, 2021 at 07:16:54PM +1000, Paul W. Rankin wrote:
>>> 
>>> I've attached two patches: 0001 is to remove the explicit setting of
>>> NSWindowTabbingModeDisallowed;
>> 
>> If you write up a wee NEWS entry, I'll be happy to push this change to
>> master and we can see is anyone shouts. :)
>> 
>> Please make sure to mention where to go to turn off tabbing.
> 
> Hi Paul, did you get a chance to add a NEWS entry? If you don't have
> the time (or feel confident enough), please send a small
> description of what's changed and how to disable the tab-bar and I'll
> finish it up.

Hi Alan,

Sorry I was just being lazy. Attached!


[-- Attachment #2: 0001-src-nsterm.m-fix-window-tabbing-on-macOS.patch --]
[-- Type: application/octet-stream, Size: 2074 bytes --]

From 41fafc79a7371be9244460fca0c6b8d3c053de8c Mon Sep 17 00:00:00 2001
From: "Paul W. Rankin" <pwr@bydasein.com>
Date: Sat, 8 May 2021 19:09:59 +1000
Subject: [PATCH] src/nsterm.m: fix window tabbing on macOS

* src/nsterm.m: remove NSWindowTabbingModeDisallowed to respect
  system-wide preferences
* etc/NEWS: add mention of native tab support in macOS and where
  to specify system-wide setting
---
 etc/NEWS     | 8 ++++++++
 src/nsterm.m | 8 --------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 32d7c4fe18..a3073d2033 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -3110,6 +3110,14 @@ The new variable 'xwidget-webkit-download-dir' says where to download to.
 'module-file-suffix' now has the value ".dylib" on macOS, but the
 ".so" suffix is supported as well.
 
++++
+** On macOS, Emacs now supports native tabs (available in macOS 10.12
+and later).  Native tabbing behavior is specified system-wide via
+System Preferences, under under General > 'Prefer tabs when opening
+documents'. In macOS versions 10.15 and earlier, this option is
+located under Dock instead. Note that this feature is unrelated to the
+Emacs 'tab-bar-mode'.
+
 +++
 ** On MS-Windows, Emacs can now toggle the IME.
 A new function 'w32-set-ime-open-status' can now be used to disable
diff --git a/src/nsterm.m b/src/nsterm.m
index bb20886ab1..5fd4885801 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7628,14 +7628,6 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f
          selector:@selector (viewDidResize:)
              name:NSViewFrameDidChangeNotification object:nil];
 
-  /* macOS Sierra automatically enables tabbed windows.  We can't
-     allow this to be enabled until it's available on a Free system.
-     Currently it only happens by accident and is buggy anyway.  */
-#ifdef NS_IMPL_COCOA
-  if ([win respondsToSelector: @selector(setTabbingMode:)])
-    [win setTabbingMode: NSWindowTabbingModeDisallowed];
-#endif
-
   ns_window_num++;
   return self;
 }
-- 
2.30.1