From: "Stephen J. Turnbull" <stephen@xemacs.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen_leake@stephe-leake.org,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 4d3a595: `load-path' should contain only directory names
Date: Mon, 26 Oct 2015 18:56:13 +0900 [thread overview]
Message-ID: <22061.63677.9850.406539@turnbull.sk.tsukuba.ac.jp> (raw)
In-Reply-To: <83611ucngl.fsf@gnu.org>
Eli Zaretskii writes:
> IMO, it just looks sloppy on our part if we are inconsistent in
> setting the value of that list. The solution was easy, so I think it
> was a good cleanup.
+1.
XEmacs is pretty careful about using directory names (ie, with
trailing slash) in variables named like "foo-path". I do think it
looks better to be consistent.
Perhaps it would be useful to have
(defun prepend-to-directory-path (path-variable &rest directories)
;; don't use add-to-list because it won't reorder the path for
;; directories already present
(set path-variable (nconc (nreverse (mapcar (lambda (dir)
(file-name-as-directory
(expand-file-name dir)))))
(symbol-value path-variable))))
Of course the `file-name-as-directory' could be replaced by
`directory-file-name' if preferred (yes, it's needed for consistency,
in XEmacs at least: `expand-file-name' doesn't strip trailing slashes).
I hereby relinquish all claim to the above defun. Ie, it's now in the
public domain AFAIK. Even if it does qualify as a small change. :-)
next prev parent reply other threads:[~2015-10-26 9:56 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151023135532.11512.53356@vcs.savannah.gnu.org>
[not found] ` <E1Zpcoe-00030Q-LS@vcs.savannah.gnu.org>
2015-10-24 13:49 ` [Emacs-diffs] master 4d3a595: `load-path' should contain only directory names Stefan Monnier
2015-10-24 14:02 ` Eli Zaretskii
2015-10-24 21:15 ` Stefan Monnier
2015-10-25 3:35 ` Eli Zaretskii
2015-10-26 2:04 ` Stefan Monnier
2015-10-26 3:34 ` Eli Zaretskii
2015-10-26 9:56 ` Stephen J. Turnbull [this message]
2015-10-24 21:37 ` Stephen Leake
2015-10-25 18:38 ` Eli Zaretskii
2015-10-26 13:19 ` Stephen Leake
2015-10-26 13:28 ` Dmitry Gutov
2015-10-26 16:24 ` Eli Zaretskii
2015-10-26 17:47 ` Stefan Monnier
2015-10-26 18:30 ` Eli Zaretskii
2015-10-26 18:47 ` Dmitry Gutov
2015-10-26 18:58 ` Eli Zaretskii
2015-10-26 19:01 ` Dmitry Gutov
2015-10-27 13:49 ` Stefan Monnier
2015-10-27 18:25 ` Eli Zaretskii
2015-10-27 19:00 ` Stefan Monnier
2015-10-27 19:17 ` Eli Zaretskii
2015-10-27 22:18 ` Stefan Monnier
2015-10-28 3:42 ` Eli Zaretskii
2015-10-28 4:21 ` Stephen J. Turnbull
2015-10-26 18:37 ` Dmitry Gutov
2015-10-27 13:52 ` Stefan Monnier
2015-10-28 0:24 ` Dmitry Gutov
2015-10-28 2:53 ` Stefan Monnier
2015-10-29 1:04 ` Dmitry Gutov
2015-10-26 20:02 ` Stephen Leake
2015-10-26 20:17 ` Dmitry Gutov
2015-10-27 13:59 ` Stefan Monnier
2015-10-27 18:27 ` Eli Zaretskii
2015-10-27 19:01 ` Stefan Monnier
2015-10-27 19:20 ` Eli Zaretskii
2015-10-27 22:25 ` Stefan Monnier
2015-10-28 7:34 ` David Kastrup
2015-10-28 15:49 ` Davis Herring
2015-10-28 15:59 ` Eli Zaretskii
2015-10-28 16:30 ` Stefan Monnier
2015-10-28 16:53 ` Eli Zaretskii
2015-10-28 18:22 ` Stefan Monnier
2015-10-28 18:48 ` Eli Zaretskii
2015-10-28 19:25 ` Stefan Monnier
2015-10-28 20:15 ` Eli Zaretskii
2015-10-28 20:18 ` Dmitry Gutov
2015-10-28 20:44 ` Eli Zaretskii
2015-10-29 1:18 ` Stefan Monnier
2015-10-29 8:24 ` David Kastrup
2015-10-29 16:20 ` Eli Zaretskii
2015-10-28 21:02 ` Drew Adams
2015-10-29 1:18 ` Stefan Monnier
2015-10-29 3:40 ` Eli Zaretskii
2015-10-29 5:50 ` Stefan Monnier
2015-11-23 14:14 ` Nicolas Richard
2015-11-23 16:26 ` Eli Zaretskii
2015-10-28 18:19 ` Random832
2015-10-28 22:04 ` Random832
2015-10-29 2:34 ` Richard Stallman
2015-10-29 13:30 ` Wolfgang Jenkner
2015-10-29 2:32 ` Richard Stallman
2015-10-29 4:33 ` Random832
2015-10-29 16:21 ` Eli Zaretskii
2015-10-29 16:31 ` Dmitry Gutov
2015-10-29 16:42 ` Eli Zaretskii
2015-10-29 18:24 ` Dmitry Gutov
2015-10-30 1:10 ` Stefan Monnier
2015-10-30 1:09 ` Stefan Monnier
2015-10-30 8:00 ` Eli Zaretskii
2015-10-30 13:30 ` Stefan Monnier
2015-10-30 13:54 ` Eli Zaretskii
2015-10-30 1:34 ` Richard Stallman
2015-10-30 8:05 ` Eli Zaretskii
2015-10-28 1:31 ` Stephen Leake
2015-10-26 16:21 ` Eli Zaretskii
2015-10-26 17:55 ` Stephen Leake
2015-10-26 18:33 ` Eli Zaretskii
2015-10-26 19:49 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22061.63677.9850.406539@turnbull.sk.tsukuba.ac.jp \
--to=stephen@xemacs.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).