From: "Roland Winkler" <winkler@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: "Glenn Morris" <rgm@gnu.org>,
"Francesco Potort�=AC" <pot@gnu.org>,
emacs-devel@gnu.org
Subject: Re: master 45a1653: ; Fix last change to bibtex.el
Date: Wed, 18 Nov 2020 11:11:43 -0600 [thread overview]
Message-ID: <21967.72026.373783.24501@gargle.gargle.HOWL> (raw)
In-Reply-To: <877dqizkpn.fsf@tcd.ie>
On Wed Nov 18 2020 Basil L. Contovounesios wrote:
> > From a different perspective, if bibtex-unify-case-convert was a
> > variable holding a function name, the variable name should be
> > something like bibtex-unify-case-convert-function.
>
> Instead of marking the user option as :risky, why not give it a :safe
> predicate that checks whether it's one of the predefined values?
I believe the philosophy is "better safe than sorry".
See the elisp section on file-local variables:
In addition, any variable whose name ends in any of
‘-command’, ‘-frame-alist’, ‘-function’, ‘-functions’, ‘-hook’,
‘-hooks’, ‘-form’, ‘-forms’, ‘-map’, ‘-map-alist’, ‘-mode-alist’,
‘-program’, or ‘-predicate’ is automatically considered risky.
The problem is really about allowing user-defined functions. If one
excludes user-defined functions and allows only predefined
functions, the entire 'funcall ...-function' thing is not needed,
that is, the variable can hold a symbol that triggers a hard-coded call
of a predefined function.
next prev parent reply other threads:[~2020-11-18 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201116233108.21940.22514@vcs0.savannah.gnu.org>
[not found] ` <20201116233110.4E83E209DE@vcs0.savannah.gnu.org>
2020-11-18 1:42 ` master 45a1653: ; Fix last change to bibtex.el Glenn Morris
2020-11-18 4:19 ` Roland Winkler
2020-11-18 12:30 ` Basil L. Contovounesios
2020-11-18 14:13 ` Roland Winkler
2020-11-18 14:36 ` Roland Winkler
2020-11-18 16:35 ` Basil L. Contovounesios
2020-11-18 17:11 ` Roland Winkler [this message]
2020-11-18 21:31 ` Stefan Monnier
2020-11-18 21:56 ` Roland Winkler
2020-11-28 22:32 ` Roland Winkler
2020-11-19 5:23 ` Richard Stallman
2020-11-19 8:25 ` Roland Winkler
2020-11-18 11:47 ` Basil L. Contovounesios
2020-11-18 16:18 ` Basil L. Contovounesios
2020-11-24 6:31 ` Lars Ingebrigtsen
2020-11-24 15:35 ` Eli Zaretskii
2020-11-24 19:26 ` Basil L. Contovounesios
2020-11-24 19:58 ` Eli Zaretskii
2020-11-24 20:25 ` Eli Zaretskii
2020-11-24 21:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21967.72026.373783.24501@gargle.gargle.HOWL \
--to=winkler@gnu.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=pot@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).