Trunk: eww: loses title

Trunk: eww: loses title

[T. V. Raman]

eww-render in trunk appears to incorrectly set title to url.
Here's the function, with the suspect line commented out:
With it commented out title does get set correctly.

(defun eww-render (status url &optional point buffer)
  (let ((redirect (plist-get status :redirect)))
    (when redirect
      (setq url redirect)))
  (let* ((headers (eww-parse-headers))
	 (content-type
	  (mail-header-parse-content-type
	   (or (cdr (assoc "content-type" headers))
	       "text/plain")))
	 (charset (intern
		   (downcase
		    (or (cdr (assq 'charset (cdr content-type)))
			(eww-detect-charset (equal (car content-type)
						   "text/html"))
			"utf8"))))
	 (data-buffer (current-buffer)))
    (unwind-protect
	(progn
          (plist-put eww-data :title "")
	  (cond
           ((and eww-use-external-browser-for-content-type
                 (string-match-p eww-use-external-browser-for-content-type
                                 (car content-type)))
            (eww-browse-with-external-browser url))
	   ((equal (car content-type) "text/html")
	    (eww-display-html charset url nil point buffer))
	   ((equal (car content-type) "application/pdf")
	    (eww-display-pdf))
	   ((string-match-p "\\`image/" (car content-type))
	    (eww-display-image buffer)
	    (eww-update-header-line-format))
	   (t
	    (eww-display-raw buffer)
	    (eww-update-header-line-format)))
        ; this line looks suspect.
	  ;(plist-put eww-data :title url)
	  (setq eww-history-position 0)
	  (run-hooks 'eww-after-render-hook))
      (kill-buffer data-buffer))))

Re: Trunk: eww: loses title

[Lars Magne Ingebrigtsen]

"T. V. Raman" <raman@google.com> writes:

> eww-render in trunk appears to incorrectly set title to url.
> Here's the function, with the suspect line commented out:
> With it commented out title does get set correctly.

Yup.  Fixed on trunk now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no