From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Barzilay Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117340: * lisp/calculator.el: Lots of revisions Date: Wed, 18 Jun 2014 06:08:37 -0400 Message-ID: <21409.25893.932208.110667@home.barzilay.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1403086143 6251 80.91.229.3 (18 Jun 2014 10:09:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Jun 2014 10:09:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 18 12:08:58 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WxCnX-0006To-BA for ged-emacs-devel@m.gmane.org; Wed, 18 Jun 2014 12:08:55 +0200 Original-Received: from localhost ([::1]:56195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxCnW-0007np-R9 for ged-emacs-devel@m.gmane.org; Wed, 18 Jun 2014 06:08:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxCnO-0007nX-HA for emacs-devel@gnu.org; Wed, 18 Jun 2014 06:08:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxCnJ-0006s4-4g for emacs-devel@gnu.org; Wed, 18 Jun 2014 06:08:46 -0400 Original-Received: from mail-qc0-f178.google.com ([209.85.216.178]:64704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxCnJ-0006ry-0n for emacs-devel@gnu.org; Wed, 18 Jun 2014 06:08:41 -0400 Original-Received: by mail-qc0-f178.google.com with SMTP id c9so513300qcz.23 for ; Wed, 18 Jun 2014 03:08:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=iKBTM0k99Lb3qBhAL+0RptmRgnpFzE7rcMBDKOWGWRQ=; b=QzhBEo4pETXxXRxkAKTHvqIob/C+4C01cfXyR0IPfCv1n8neBPr4n6QGp1r48FHHjC ABLL9HJqell/dSBg17ZQv1rkKVJ2RDuL0Y324ulXgU8X4OUumPVExcVLokwTfDTfrSJt 91Im9psgeh6UZkC4RiNcUDqnPDxwCsfxVQj9oguH25AoNz56Kz80dTN2Fea0r1IS7aNX I9ybxxK/yCtRY+xsdpr3LeMnaGiBROflZTjlk6kzYUXdGx8CGpH1pDLP7xJDKdixsTsq XRbbMYrO3ckJR8KhpkYMmEHi572dJrfwAgN6J2RL9TdXNbzlXIl2IP0wKtIleqv6X1lN CgDg== X-Gm-Message-State: ALoCoQkgTbxfj4/eFBBjwcXMLsDVsvJFiTQA/YlTRLMibi3mDHGv3M+XYM2udRflwmHrVeCe1SV5 X-Received: by 10.140.95.23 with SMTP id h23mr1344215qge.12.1403086120045; Wed, 18 Jun 2014 03:08:40 -0700 (PDT) Original-Received: from home.barzilay.org (c-24-60-254-179.hsd1.ma.comcast.net. [24.60.254.179]) by mx.google.com with ESMTPSA id v20sm958174qge.11.2014.06.18.03.08.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jun 2014 03:08:39 -0700 (PDT) In-Reply-To: X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-redhat-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.216.178 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172500 Archived-At: Yesterday, Stefan Monnier wrote: > > * lisp/calculator.el: Lots of revisions > > - Kill the calculator buffer after electric mode too. > > - Make decimal mode have "," groups, so it's more fitting for > > use in money calculations. > > - Factorial works with non-integer inputs. > > - Swallow less errors. > > - Lots of other improvements, but no changes to custom > > variables, or other user visible changes (except the above). > > The above description is the kind of thing that should go into > etc/NEWS. Shouldn't the NEWS entry list only user-visible changes? (That is, only the first three items in the above.) I also have a small bug fix to commit, which also seems like something that shouldn't be mentioned in the NEWS --? > But you forgot to include a ChangeLog entry for that commit. Should I add it now? (I have a small bug fix in the new code, so maybe I can add the previous text with this commit?) > For the ChangeLog entry, you should instead include details about > which parts of the code you changed (see > https://www.gnu.org/prep/standards/html_node/Change-Logs.html). You > can use "C-x 4 a" (both from the calculator.el and the *vc-diff* > buffers) to help you write that. (AFAICT, it doesn't help with the actual log message, right?) > And the commit message should be a textual copy of the ChangeLog > entry just with the leading TABs stripped (you can use C-c C-a from > the *vc-log* buffer to let Emacs fetch that ChangeLog text for you). (I should obviously follow whatever is the convention, but as a sidenote, this requirement is implicitly saying "I'm obsolete", since if it's always followed, then it is identical to the commit log, and therefore the changelog file can be auto-generated. Similarly for the log message contents -- which is specified rigidly to the point where it can be done better with a VCS. But I'll repeat to avoid flaming followups: I will try to follow whatever the convention are.) -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life!