From: Paul Eggert <eggert@cs.ucla.edu>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: master 3139551: Don’t attempt to modify constant strings
Date: Sun, 17 May 2020 16:16:56 -0700 [thread overview]
Message-ID: <213ab8c4-dd38-19ef-bd8a-87855238df1a@cs.ucla.edu> (raw)
In-Reply-To: <edb1f6a4-db8b-824d-1615-e7205ea90989@yandex.ru>
On 5/17/20 2:54 PM, Dmitry Gutov wrote:
> On 18.05.2020 00:36, Paul Eggert wrote:
>>> A cache normally doesn't mutate the values, it only holds on to them.
>> This cache mutates its values, unfortunately.
>
> Perhaps it should call (copy-sequence val) itself, then? That would be a good
> development practice.
That would run afoul of the whole idea of clearing the string in the first
place, which was to avoid having one's password lying around in memory for a bad
actor to grab it.
next prev parent reply other threads:[~2020-05-17 23:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200517052512.20679.37725@vcs0.savannah.gnu.org>
[not found] ` <20200517052513.C95BC20A2C@vcs0.savannah.gnu.org>
2020-05-17 11:22 ` master 3139551: Don’t attempt to modify constant strings Dmitry Gutov
2020-05-17 17:01 ` Paul Eggert
2020-05-17 11:24 ` Dmitry Gutov
2020-05-17 17:10 ` Paul Eggert
2020-05-17 18:02 ` Dmitry Gutov
2020-05-17 21:36 ` Paul Eggert
2020-05-17 21:54 ` Dmitry Gutov
2020-05-17 23:16 ` Paul Eggert [this message]
2020-05-17 23:24 ` Dmitry Gutov
2020-05-18 7:03 ` Andreas Schwab
2020-05-18 22:49 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213ab8c4-dd38-19ef-bd8a-87855238df1a@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).