From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.devel Subject: Re: buffer-offer-save, gnus and mh-e Date: Sun, 17 Apr 2005 10:44:49 -0700 Organization: Newt Software Message-ID: <21194.1113759889@olgas.newt.com> References: <200504171500.j3HF0Ha22225@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1113764319 2206 80.91.229.2 (17 Apr 2005 18:58:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 17 Apr 2005 18:58:39 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 17 20:58:34 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DNEyG-00006S-Ud for ged-emacs-devel@m.gmane.org; Sun, 17 Apr 2005 20:58:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DNF2E-00041M-Ch for ged-emacs-devel@m.gmane.org; Sun, 17 Apr 2005 15:02:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DNEzm-0003Fl-7m for emacs-devel@gnu.org; Sun, 17 Apr 2005 14:59:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DNEzd-0003Al-QE for emacs-devel@gnu.org; Sun, 17 Apr 2005 14:59:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DNEzY-00032g-Pg for emacs-devel@gnu.org; Sun, 17 Apr 2005 14:59:36 -0400 Original-Received: from [207.217.120.131] (helo=fallback-aspen.pas.sa.earthlink.net) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DNEon-0000jo-2b for emacs-devel@gnu.org; Sun, 17 Apr 2005 14:48:29 -0400 Original-Received: from pop07.sprintmail.com ([207.217.120.177] helo=pop-a065c32.pas.sa.earthlink.net) by fallback-aspen.pas.sa.earthlink.net with esmtp (Exim 3.36 #4) id 1DNDuv-00049H-00 for emacs-devel@gnu.org; Sun, 17 Apr 2005 10:50:45 -0700 Original-Received: from h-68-165-7-167.snvacaid.dynamic.covad.net ([68.165.7.167] helo=olgas.newt.com) by pop-a065c32.pas.sa.earthlink.net with esmtp (Exim 3.36 #10) id 1DNDpC-0002C6-00; Sun, 17 Apr 2005 10:44:50 -0700 Original-Received: by olgas.newt.com (Postfix, from userid 1000) id 0FACB16F9E; Sun, 17 Apr 2005 10:44:49 -0700 (PDT) Original-Received: from olgas.newt.com (localhost [127.0.0.1]) by olgas.newt.com (Postfix) with ESMTP id 0C7C516F9D; Sun, 17 Apr 2005 10:44:49 -0700 (PDT) Original-To: Luc Teirlinck In-Reply-To: Luc Teirlinck's message of Sun, 17 Apr 2005 10:00:17 CDT. <200504171500.j3HF0Ha22225@raven.dms.auburn.edu> X-Mailer: MH-E 7.82+cvs; nmh 1.1; GNU Emacs 21.4.1 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36056 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36056 Luc Teirlinck wrote: > I plan to make buffer-offer-save a permanent local. Luc Teirlinck wrote: > The solution for that is to set buffer-offer-save to t in > `compose-mail' and no longer set it in the individual mail modes. I > checked that this works for mail-mode and message-mode. I could not > check it for mh-folder-mode, but I guess that it must work, since it > works through `compose-mail'. Luc, I'm a little confused by this since mh-folder-mode extends fundamental-mode. > For mh-e, I have no idea whatsoever how it > is supposed to be handled. We support Emacs 20.7, 21, and if CVS Emacs is to be 22, then we support that too. We also support XEmacs 21. See http://mh-e.sourceforge.net/prereq/, although I notice I need to update this information with the content of https://sourceforge.net/project/shownotes.php?release_id=263080. > If conditionals would be required, things might look somewhat strange, > because setting buffer-offer-save would still be harmless, even in > Emacs 22. The only problem is that major modes are not supposed to > touch permanent locals. At least when we no longer support a particular version of Emacs that the conditional covers, then we can remove the conditional. Just to be sure I'm understanding correctly, you'd like to see the following code in mh-e.el:(mh-folder-mode), right? (if (or mh-xemacs-flag (< emacs-major-version 22)) (setq buffer-offer-save t)) Also, is the setting of buffer-offer-save to nil in mh-utils.el:(mh-find-path) still appropriate? I'll make the change above and check it into CVS Emacs soon. I'll let you know if I have additional questions or run into problems. -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane.