From: kifer@cs.sunysb.edu (Michael Kifer)
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Chong Yidong <cyd@stupidchicken.com>, emacs-devel@gnu.org
Subject: Re: Ediff regression
Date: Thu, 14 Jun 2007 13:43:03 -0400 [thread overview]
Message-ID: <20835.1181842983@cs.sunysb.edu> (raw)
In-Reply-To: Message from Stefan Monnier <monnier@iro.umontreal.ca> of "Thu, 14 Jun 2007 10:40:03 EDT." <jwv7iq6vbxz.fsf-monnier+emacs@gnu.org>
> > Sorry, I did not touch diff-mode.el intentionally. I see that the log
> > points the finger in my direction, but I do not know how it happened. :-(
> > The expression to which you changed diff-font-lock-keywords is similar to
> > one in ediff, but I do not know if it is what you wanted in
> > diff-mode.el. It seems ok, but if you are not sure then it is better to
> > revert to version 1.100. Sorry for the mixup.
>
> You changed "\\S-" into "[^\t]" which was obviously meant to be "[^ \t]".
> So I fixed the obvious. I don't have much preference between the two, so
> I left "[^ \t]" there. Maybe if you could say why you preferred "[^ \t]"
> over "\\S-" in ediff, I can make up a good reason to do the same change in
> diff-mode.el ;-)?
It was [^ \t] in ediff from the beginning. I changed it to [^\t] in ediff
because I wanted to take care of files that have spaces in their names. But
this was wrong and I reverted the change back to [^ \t].
I am not sure how that same change got into diff-mode.el. Maybe I did
something mechanically and did not notice.
--michael
next prev parent reply other threads:[~2007-06-14 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 18:59 Ediff regression Chong Yidong
2007-06-13 20:26 ` Michael Kifer
2007-06-13 21:05 ` Chong Yidong
2007-06-13 21:12 ` Stefan Monnier
2007-06-14 7:48 ` Michael Kifer
2007-06-14 14:40 ` Stefan Monnier
2007-06-14 17:43 ` Michael Kifer [this message]
2007-06-14 19:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20835.1181842983@cs.sunysb.edu \
--to=kifer@cs.sunysb.edu \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).