From: "Jakub T. Jankiewicz" <jcubic@onet.pl>
To: "Toshi Umehara" <toshi@niceume.com>
Cc: "Stefan Monnier" <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org, "Eli Zaretskii" <eliz@gnu.org>
Subject: Re: [PATCH] Scheme-mode: Add support for regular expression literal
Date: Thu, 28 Mar 2024 12:33:54 +0100 [thread overview]
Message-ID: <20240328123354.17588d57@jcubic> (raw)
In-Reply-To: <fffdcd65-8a76-4b62-a18a-ddee2b1dc04c@app.fastmail.com>
One note about original solution in .emacs file that I used. It doesn't
correctly handle #; it works only till the end of the line (it should comment
out whole S-Expression). I hope that the code that was proposed for the
scheme.el was tested and handle this correctly.
On Sun, 24 Mar 2024 13:33:19 +0900
"Toshi Umehara" <toshi@niceume.com> wrote:
> Thank you very much for reviewing the patch, Stefan.
>
> The patch is updated.
>
> - Subexpression 1 is now used for regular expression rule in
> syntax-propertize-rules
>
> - Unused arguments are removed from caller and callee of
> scheme-syntax-propertize-regexp
>
> - Changing the third argument of re-search-forward from t to 'move moves
> the point to end if the search does not find closing slash, which is
> ideal.
>
> Attached patches are separated into three. The first one changes only
> regular expression part mentioned above. The second one is NEWS update.
> The third one removes unused arguments also for
> scheme-syntax-propertize-sexp-comment . Please use them as you want.
>
> Also about copyright assignment, this is the first commitment to GNU,
> and I have filled out the form and have emailed it to assign@gnu.org .
>
> Thanks
>
--
Jakub T. Jankiewicz, Senior Front-End Developer
https://jcubic.pl/me
https://lips.js.org
https://koduj.org
next prev parent reply other threads:[~2024-03-28 11:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 2:40 [PATCH] Scheme-mode: Add support for regular expression literal Toshi Umehara
2024-03-23 14:28 ` Jakub T. Jankiewicz
2024-03-23 20:57 ` Stefan Monnier
2024-03-24 4:33 ` Toshi Umehara
2024-03-28 11:33 ` Jakub T. Jankiewicz [this message]
2024-03-28 12:40 ` Toshi Umehara
2024-03-28 23:43 ` Jakub T. Jankiewicz
2024-03-29 6:48 ` Eli Zaretskii
2024-03-29 11:09 ` Jakub T. Jankiewicz
2024-03-29 15:02 ` Toshi Umehara
2024-03-29 15:38 ` Eli Zaretskii
2024-03-30 0:48 ` Toshi Umehara
2024-04-01 6:17 ` Stefan Monnier
2024-03-30 7:59 ` Eli Zaretskii
2024-04-01 5:31 ` Stefan Monnier
2024-04-01 5:24 ` Stefan Monnier
2024-04-02 8:48 ` Toshi Umehara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328123354.17588d57@jcubic \
--to=jcubic@onet.pl \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=toshi@niceume.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).