From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tatsuya Kinoshita Newsgroups: gmane.linux.debian.devel.bugs.general,gmane.emacs.devel Subject: Bug#1021842: Finalizing 'inhibit-automatic-native-compilation' Date: Sat, 18 Feb 2023 06:13:35 +0900 (JST) Message-ID: <20230218.061335.1468428093197134401.tats%nobody@tats.iris.ne.jp> References: <166586215062.368699.18398270685158383578.reportbug@convex> Reply-To: Tatsuya Kinoshita , 1021842@bugs.debian.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, spwhitton@spwhitton.name, 1021842@bugs.debian.org To: akrl@sdf.org Original-X-From: bounce-debian-bugs-dist=glddb-debian-bugs-dist2=m.gmane-mx.org@lists.debian.org Fri Feb 17 22:21:13 2023 Return-path: Envelope-to: glddb-debian-bugs-dist2@m.gmane-mx.org Original-Received: from bendel.debian.org ([82.195.75.100]) by ciao.gmane.io with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pT8AJ-00010m-P4 for glddb-debian-bugs-dist2@m.gmane-mx.org; Fri, 17 Feb 2023 22:21:11 +0100 Original-Received: from localhost (localhost [127.0.0.1]) by bendel.debian.org (Postfix) with QMQP id 8532C21ABE; Fri, 17 Feb 2023 21:21:11 +0000 (UTC) X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Fri Feb 17 21:21:11 2023 Old-Return-Path: Original-Received: from localhost (localhost [127.0.0.1]) by bendel.debian.org (Postfix) with ESMTP id 67AFF21ABC for ; Fri, 17 Feb 2023 21:21:11 +0000 (UTC) X-Virus-Scanned: at lists.debian.org with policy bank bug Original-Received: from bendel.debian.org ([127.0.0.1]) by localhost (lists.debian.org [127.0.0.1]) (amavisd-new, port 2525) with ESMTP id hhabirok55ez for ; Fri, 17 Feb 2023 21:21:07 +0000 (UTC) Original-Received: from buxtehude.debian.org (buxtehude.debian.org [IPv6:2607:f8f0:614:1::1274:39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "buxtehude.debian.org", Issuer "Debian SMTP CA" (not verified)) by bendel.debian.org (Postfix) with ESMTPS id 063AF21AB5; Fri, 17 Feb 2023 21:21:07 +0000 (UTC) Original-Received: from debbugs by buxtehude.debian.org with local (Exim 4.94.2) (envelope-from ) id 1pT8AA-00HaRK-VN; Fri, 17 Feb 2023 21:21:02 +0000 X-Loop: owner@bugs.debian.org Resent-From: Tatsuya Kinoshita Original-Sender: Tatsuya Kinoshita Resent-To: debian-bugs-dist@lists.debian.org Resent-CC: Rob Browning X-Loop: owner@bugs.debian.org Resent-Date: Fri, 17 Feb 2023 21:21:01 +0000 Resent-Message-ID: X-Debian-PR-Message: followup 1021842 X-Debian-PR-Package: emacsen-common X-Debian-PR-Source: emacsen-common Original-Received: via spool by 1021842-submit@bugs.debian.org id=B1021842.16766686054188343 (code B ref 1021842); Fri, 17 Feb 2023 21:21:01 +0000 Original-Received: (at 1021842) by bugs.debian.org; 17 Feb 2023 21:16:45 +0000 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:40724) by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim 4.94.2) (envelope-from ) id 1pT861-00HZZi-JI for 1021842@bugs.debian.org; Fri, 17 Feb 2023 21:16:45 +0000 Original-Received: by mail-pl1-x62d.google.com with SMTP id 19so2973667plo.7 for <1021842@bugs.debian.org>; Fri, 17 Feb 2023 13:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to:from :subject:cc:to:message-id:date:sender:from:to:cc:subject:date :message-id:reply-to; bh=K0ie8+oAHAYohG/u6PGUigcEmNSDhH1mSmd8Zp6O4Qc=; b=QK9RYpRL3MhKCHC+2PawqMCfCPpKsGFLTM+AwcyS/NWX/wjtgg4smq4SXU86BVjWvI nnxPS7aAXnXb88oxQ9DC470d8t/W9H7RzJC5igT+upRydVWeui/uGuM2Cskk3v/y6uvo DOn9DylptOTtn9x7etBPgDBF0g1KlpJUuY3Fb3A92t9Nd6YKVfp/kDy3XHGwuZewRm/E Wrg3BpGZbQjHRKFFCAup3NMbbuJmVaM/q26pFdAD2gSZLTyTQEbMdLwjD67uGT+YM3PS FJNjdl4K9ARX/PnVoSwm96YtZ8Kv1vQCCoWtvjQSxvf2V4q7a4WIibozgePJ02tmiDgb efbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to:from :subject:cc:to:message-id:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K0ie8+oAHAYohG/u6PGUigcEmNSDhH1mSmd8Zp6O4Qc=; b=nfRncibNC7re1grlkuDuGyJaKe0iXfhnqSLSsl2aYbJBkZ1ES0Uw0vRYOnplKAukYk qQ48B6DR5Teo2cgbdIrtbu+XazRFX8DzNtoxwWFHm3QeU3BTeNeCWgdv0Ac0xrN+ixMT v0Z73z3Rs2Wjg/Sn+0ryYJowVX+b1Mj3G93JSu/Jx/4MMCsGn1ESpRqRHut8VPn3PwRZ xKR9qg9rXS2G+yTXUCXm4n76vKlwiU8sRhyUPyJVKGsZVc20loRDRkm3c+RQgRE5hU41 RyjGMij1cxegal6Y9EcJ+202HQmmwO4JHKqj6bIEmraXNT+yT72sCPvVH/oqOMS7q+4U g+SA== X-Gm-Message-State: AO0yUKWr2uphzENrfhMXlVIwQ7YSWSNEFEWE6ikiwyDZS0NRzPGFN8VZ WYTfvNwPQasZj2AYwSVbvVc= X-Google-Smtp-Source: AK7set+pD8hHDD/eqcubMjMzccxPNAj6HXftXNxpTewDRE8j481SGKUFiwPFwACt/WfhovoxjmmMWg== X-Received: by 2002:a17:902:f682:b0:199:2ee:6238 with SMTP id l2-20020a170902f68200b0019902ee6238mr2815456plg.16.1676668603126; Fri, 17 Feb 2023 13:16:43 -0800 (PST) Original-Received: from localhost ([2400:4150:4060:4700:d7d:e203:2a35:eaec]) by smtp.gmail.com with ESMTPSA id l13-20020a170902d34d00b00198dd432329sm3553097plk.51.2023.02.17.13.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 13:16:42 -0800 (PST) Original-Sender: Tatsuya Kinoshita In-Reply-To: <87edqo451m.fsf@melete.silentflame.com> X-Debian-Message: from BTS X-Mailing-List: archive/latest/1760646 X-Loop: debian-bugs-dist@lists.debian.org List-Id: List-URL: List-Post: List-Help: List-Subscribe: List-Unsubscribe: Precedence: list Resent-Sender: debian-bugs-dist-request@lists.debian.org Xref: news.gmane.io gmane.linux.debian.devel.bugs.general:1838290 gmane.emacs.devel:303514 Archived-At: On 2023-02-17 at 09:42 -0700, Sean Whitton wrote: > So: commit ce4a066ed1e fixes Debian bug #1021842 without the env var. On 2023-02-14 at 11:32 +0000, Andrea Corallo wrote: > Stefan Monnier writes: > > `temporary-file-directory' may point to a world-writable directory, so > > it's vulnerable to the usual race condition where someone manages to > > predict the name of the file you're going to write and places there > > a symlink to some "interesting" place, so you end up overwriting some > > other file unwittingly. > > Okay, ce4a066ed1e generates trampolines in a temporary directory if no > other option is viable (using the make-temp-file machinery to generate > the unpredictable name). > + finally (cl-return > + (expand-file-name > + (make-temp-file-internal (file-name-sans-extension rel-filename) > + 0 ".eln" nil) > + temporary-file-directory)))) Hmm, it seems using make-temp-file-internal with DIR-FLAG=0 which just constructs a name and do not create the file like make-temp-name, so there is a race condition as Stefan mentioned. Is that really OK? Thanks,