From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Madhu Newsgroups: gmane.emacs.devel Subject: Re: undo-auto--undoable-change infloop Date: Sun, 09 Oct 2022 08:02:27 +0530 (IST) Message-ID: <20221009.080227.2266845120078877974.enometh@meer.net> References: <87y1vwq0su.fsf@web.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1943"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 09 04:34:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohM93-0000LZ-PW for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Oct 2022 04:34:25 +0200 Original-Received: from localhost ([::1]:52056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohM92-0000CV-O7 for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 22:34:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohM7f-0007B5-Eg for emacs-devel@gnu.org; Sat, 08 Oct 2022 22:32:59 -0400 Original-Received: from smtp6.ctinetworks.com ([205.166.61.199]:53986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohM7e-0007G4-1J for emacs-devel@gnu.org; Sat, 08 Oct 2022 22:32:59 -0400 Original-Received: from localhost (unknown [117.254.34.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp6.ctinetworks.com (Postfix) with ESMTPSA id F23948ABE9; Sat, 8 Oct 2022 22:32:46 -0400 (EDT) In-Reply-To: X-Mailer: Mew version 6.8 on Emacs 29.0.50 X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: F23948ABE9.ABAC0 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-Watermark: 1666146769.3402@nDll1fW1Nqe+ramDl1kkOw Received-SPF: pass client-ip=205.166.61.199; envelope-from=enometh@meer.net; helo=smtp6.ctinetworks.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297232 Archived-At: * Stefan Monnier Wrote on Fri, 07 Oct 2022 16:50:54 -0400 >> After this commit the last line of respool has to look like >> >> (timer-activate $current-search-timer nil (cancel-timer-internal >> $current-search-timer)) >> >> Which uses an internal function, > > Just call `cancel-timer` instead of `cancel-timer-internal` and the > problem is solved. (CANCEL-TIMER returns NIL) Earlier it was possible to avoid unnecessary consing, which is now imposed on the user by the new API. The new API may still be usable but is gratuitously inefficient: I think the public/private API purity fixation which motivated it is misguided here.