From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: etags name collision. Date: Mon, 11 Apr 2022 21:53:50 +0200 Message-ID: <20220411195350.7jhugti3e3vng6yx@Ergus> References: <20220411124736.3qijvtearh6wlen7@Ergus> <83pmln69n0.fsf@gnu.org> <20220411134749.ps6g5ulpbamzm6ot@Ergus> <83k0bv679q.fsf@gnu.org> <20220411154635.qfw2ijpdahiv5ctl@Ergus> <83fsmj62jl.fsf@gnu.org> <20220411161942.xsqr3ekorpm6jf6y@Ergus> <83ee2360aq.fsf@gnu.org> <20220411191933.wyxvmgpyd4hnpfc2@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15790"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 21:54:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ne07V-0003ui-B9 for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 21:54:41 +0200 Original-Received: from localhost ([::1]:60332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ne07U-0005P2-5h for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 15:54:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ne06u-0004iz-W5 for emacs-devel@gnu.org; Mon, 11 Apr 2022 15:54:05 -0400 Original-Received: from sonic316-11.consmr.mail.bf2.yahoo.com ([74.6.130.121]:35571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ne06s-0007I7-Nu for emacs-devel@gnu.org; Mon, 11 Apr 2022 15:54:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649706840; bh=HQHGLGH/j6QFH4V2eYMOA5+j9nvzAlKWqQqMN8eI2AE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=j+PlO0Puepz7qF7ygJN0S2bEj61GfbjstYwUvYJUalZEso59x/xP42Go1bEt6CyN0fuRvOcUgZLHJBsWgCMZ2rCNtT8XMdCGEWY2Pc1v5q41obPzXMwMvJ1VdesccZfgJfmGgwI5vNZvnVgCcoCFo3x312t7WmOBBJfeElT0xtYAq+OG0LE0J2ychfZKr25CWy+WjJKQcQY22zKxy3jistHZ+LmBL+/hh/WGyrr3/6nxUS3tOZzSQQ5sQEdOgCgiIp7IZlnt+Hv2UzVgMsQXlMbQezy7xY2Gqavo8NIVTqtkXyZq2WSbC6qiWorrcLxu9Lq3mD/1xpks/aa24rm0YQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649706840; bh=WN3/FqtjN5bm2bNiehVav81l7a+rO27wNlCTDaaPmUr=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=G3mcIiPaVEqI+yydjRNS748bBOsNlEGjvUhcZOknMR7NUYMKUOJJsNSsjaeLVATt03X5t1PdpOYbiJkxNFrPRMAPVdjwts05ILfP/8qjAbJp4QLuI07Rw0MProcKhfoOEVdmB2DkyvPsKUmVG+Zz7VKVBRjW6m0mO2F9cSWOtgBLw1b6HspwqCI+qLFQjdYo7rP5LnO+XrAb3q7cS3crrlj58DnVs6mGwTpf0r/d+fyCJwoQ6fFT3KUptatc0jy1L/wSykTc1uAjS1C7IIGmzh62/jdGM3l58LeBFzHOxHt0eE7Yro9MjqwEGra5fpGnrQw6nWBQD0BKpLlh07TMGw== X-YMail-OSG: K99g22QVM1lVANyHgGt6FPhpHDNcV6JQb1aR95.IAsB1MGvyIPD5HSzqd0fNyBE VfizAhCF0Ln2amxKH.GxMPbFvPxZtqR2dsE4ffxynWA4s5PMIBjJq1MuHLgH1iILwxiLgc69zCbH 58lNT8SnKUynWadhbIpyybjGdD11RztXhMJFRjA0iNBv1cX3aLnwtca19g9dX20n8JfWueBAsE_D OuA99juexi12NdJn29VilErnaPd9t6ioGfkqZN8AIIhc8C6xtyqks7lpPOm7SeKF8.gBBn17aIXp jFUZtr8rpTTKLUf_y8BTYf8LmA2ug7FgIn2qorVFAnOyvgI7VUbVRlH31ferrFLUxHdaUz93NcHM RimVaLogZ0f3EWgT0I_eNsudgNwH4_9jv6NAtNiZ7WAE1fDBo_OVwHtgtCjBvagLabdZXRla5TcZ kskPVYJBp2sLBrqXdWBtSlIxanJgTIeAssOaQ4iTHuZvyDH.bgDhLJ2Tke7s_OOAdcBdPr68drEG Ye9h9CxenvnzwFinzQgAcVJJ8VeLf83SGJvhIbASHdpF0xDrOskdPzEkGNGXQwNG6fFvXB3.DQst 8UxrcQDrGhzgnuSLpUb5TJYnvnu145fYSDBVXQJmnctVuTo7f0sill3ba0fVZJx9JiEMMmQrNVKT nSwwjaCeIqRwY5kIjfNM_Y3nFCpY3GvChMEhWHxa.fkJQwYOsiYyhM_sjh1mg2UWlmKkUKSpKYmn 7K33QR5Ott2Nor6_4OCnA8yz3083uK5ZCpUBq1t4wPDOTnN0B8Zd.OnW2O.S6S9pRQUc3Thssq8_ fdF0i9HB67JeFyyyz9F.BRwzH2rgBGcJZtMoLEj1.S X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.bf2.yahoo.com with HTTP; Mon, 11 Apr 2022 19:54:00 +0000 Original-Received: by kubenode504.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8bb1341bc7fc5804b58152adf07c4126; Mon, 11 Apr 2022 19:53:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.130.121; envelope-from=spacibba@aol.com; helo=sonic316-11.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288245 Archived-At: On Mon, Apr 11, 2022 at 09:39:36PM +0200, Ulrich Mueller wrote: >>>>>> On Mon, 11 Apr 2022, Ergus wrote: > >> Now? > >> diff --git a/configure.ac b/configure.ac >> index 185e4d0862..ace80aed56 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -267,6 +267,19 @@ AC_DEFUN >> fi >> AC_SUBST([with_mailutils]) > >> +AC_ARG_WITH([ctags], >> + [AS_HELP_STRING([--with-ctags], >> + [rely on System ctags; this is the default if Universal ctags or >> + Exuberant ctags is installed])], >> + [], >> + [with_ctags=$with_features >> + if test "$with_ctags" = yes; then >> + (ctags --version | grep "GNU Emacs") 2>/dev/null || with_ctags=no > >Shouldn't this use the actual name under which Emacs will install ctags? >That is, respect AC_ARG_PROGRAM? > Not needed, if it uses a different name there is no collision, so the test is not needed. >In its current form, it would break installation of the Gentoo package >(or require us adding an explicit --without-ctags). > The option --with-ctags means rely on System ctags. I don't think you need anything new. >> + fi]) >> +if test "$with_ctags" = no; then >> + with_ctags= >> +fi > >I still think that any test for an installed binary is a bad idea, from >a distro point of view. Note that distros typically build packages in an >environment that is different from the one of the final target system. > Here I agree