From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: etags name collision. Date: Mon, 11 Apr 2022 21:19:33 +0200 Message-ID: <20220411191933.wyxvmgpyd4hnpfc2@Ergus> References: <20220411124736.3qijvtearh6wlen7.ref@Ergus> <20220411124736.3qijvtearh6wlen7@Ergus> <83pmln69n0.fsf@gnu.org> <20220411134749.ps6g5ulpbamzm6ot@Ergus> <83k0bv679q.fsf@gnu.org> <20220411154635.qfw2ijpdahiv5ctl@Ergus> <83fsmj62jl.fsf@gnu.org> <20220411161942.xsqr3ekorpm6jf6y@Ergus> <83ee2360aq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="fadts4yjf3xki6fi" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9697"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 21:21:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndzaz-0002Gr-9U for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 21:21:05 +0200 Original-Received: from localhost ([::1]:46290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndzax-0000Lp-PU for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 15:21:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndzZl-00083a-U9 for emacs-devel@gnu.org; Mon, 11 Apr 2022 15:19:49 -0400 Original-Received: from sonic317-26.consmr.mail.bf2.yahoo.com ([74.6.129.81]:32881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndzZg-0001o6-Do for emacs-devel@gnu.org; Mon, 11 Apr 2022 15:19:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649704782; bh=N3VEATcNkOQ907BEbuUTJdNqZEwFztkNChJnRcBgCiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=jwuKC/1QeDM2+lW9zqz4DVQfI2uUhl0Qus61Vq9dItzryFEAZSWSd/aZTRyByqTQ461s/1SLKMDGZ0/JhNmuJKS1JtmHOyhuAWyvywXzlVFqex3Pd4Vik3wwXMVqQjdcLVD0CqI5xkNJys2HyqwUx+5PsGSWw7sR/IGkcMI6lSUKxbDh/E9fqkETGa8GcTytMTXXOAtWyEAWBEH+vH16CmQ/W/kqMZlSGcO074SR9xq/Ou1UtwKQg3OCiAbM/LAqAN6R1EbwUWeXkDmuAaiefm8waWMrgY3g2Y1fY+0Q4G0Ur+L5sNAUdFGd7A0M4I8zF7mXdiFMzipqe49ToMOHBQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649704782; bh=MU3oyKl0ogVcMeU9E9QmMKqe7BfFZtoie7tKApg+OB2=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=LcrCcujCBw2mY5ZAuqqaVwsldbRakEW8skUvGNeJhLCQ9UTX40iegwd3vPYhOq7+CHdOKvOxmH4oPRuwDsShWDl6mmm0CoZ6NgNC9fVJubyIRII9wwTnxDfaLKRcnQjrEcKaDp/2jQinh7UKrkNpB53vbN1ebdqPWpbeIkLqj9fEJnlwgqp62lfA1qlRujo7rJSlGRpEinqTj5eyR6qMShh5PGIalgJ5n9ebkXkhmtd4INIgRDCd5GN099+F/o2ObDf64uln3O5FFkzlMEYSt5Mt9424yGrYKeh0uxTnDCndnyv3G9Q1yFClq1sa8arZ7uFjMakmKbohYkqUhsnMcQ== X-YMail-OSG: zyAO.VUVM1k7p9MCWVv4FK3vpaJk4NxFhQcQxCwHqPp_P1CEVN691M3DdOtetja SWToBXJ9.m5K0rnLTKeNdQM1iSxewccMXxSKBHmPwtmcXzwipGy5DHg7_GI2aVeuVg43UKtzwIAN U7Fzmz03WsIiuoRtKhfXKeuohxpRbvij4PxkdPuDgMSskBuCjbF96XZIghrosfw7Ojb8YXnrqeyu 5PIwoeYsyLYcmR17R4EDGshmrw_d2_sgkEi4Gu8teltZ.3_.HlXdFZvHpPBDm8j35ikZeuD5w1tK Z.i1H.RiqaI5IbjAijF4dVV6eEwKUqRx0bP64C.5AeLcCex8qLn0vgTbN3zpkIvvzxAjlU8u5EGV DZlgSDEsxr4DuxBhLYg3ziZyNHzKaJYNaMF9y_WXXQgS1Gzp2Gh_VahrKqDl_ERhUP3unVCkCFKB 4ohBDmNevSvGZX0irP7odBV8ZStO6fudKAP29X.erLBX11D.CHDI4UbyofnR4fjQRuthqR4g7nb. rOfkK_dqgBNU4_39lnqSxprHdtC_2Hn1BG1neFgNHZh8OEGfnsQJRzlcbY820KyA9HOE7mboRosm HPZ1AzaBgvxjKhYjgVI4j4EhncLOCSE0ibqbmUDFJgu7k4hAgV1kRJfgYS2FFyj8mHfgQIUu1P6U FYh.roor1M_X2L9YNIrnNX3Yp8eldGOgNi5mZXxg.pmkLLD2tP71OYOkpVzYYvUdJSSN1Fj_diO3 KpDOVS4Pz5GSUrXjFKseBpzptiXPb87f.yTsh3zmCHiTqCO7reQ6bagqvz1QrH7kVaO7Ic1F4c8g hlg04mXaUWRsPu0E9BXpo8uT4.PA1jJVNX06WpVfHs X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.bf2.yahoo.com with HTTP; Mon, 11 Apr 2022 19:19:42 +0000 Original-Received: by kubenode501.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 811d0ba4e4f68bb9e44030772cedbcac; Mon, 11 Apr 2022 19:19:38 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83ee2360aq.fsf@gnu.org> X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.129.81; envelope-from=spacibba@aol.com; helo=sonic317-26.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288242 Archived-At: --fadts4yjf3xki6fi Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Mon, Apr 11, 2022 at 07:40:29PM +0300, Eli Zaretskii wrote: >> Date: Mon, 11 Apr 2022 18:19:42 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> On Mon, Apr 11, 2022 at 06:51:58PM +0300, Eli Zaretskii wrote: >> >> >The code should test whether another version of 'ctags' is already >> >installed, and if so, that it isn't our 'ctags'. _Then_ we could >> >default to not installing our 'ctags'. Your proposal doesn't make >> >that test, so please add it. >> > >> >Thanks. >> > >> I do this tests like with mailutils and movemail: >> >> (ctags --version) >/dev/null 2>&1 || with_ctags=no >> >> Isn't this enough? > >No, because AFAIU this test will succeed also if the installed ctags >is (an older version) of the program that came with (an older version) >of Emacs. You need to make sure the text emitted by --version does >NOT include "GNU Emacs". > Now? --fadts4yjf3xki6fi Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ctags.patch" diff --git a/configure.ac b/configure.ac index 185e4d0862..ace80aed56 100644 --- a/configure.ac +++ b/configure.ac @@ -267,6 +267,19 @@ AC_DEFUN fi AC_SUBST([with_mailutils]) +AC_ARG_WITH([ctags], + [AS_HELP_STRING([--with-ctags], + [rely on System ctags; this is the default if Universal ctags or + Exuberant ctags is installed])], + [], + [with_ctags=$with_features + if test "$with_ctags" = yes; then + (ctags --version | grep "GNU Emacs") 2>/dev/null || with_ctags=no + fi]) +if test "$with_ctags" = no; then + with_ctags= +fi + AC_ARG_WITH([pop], [AS_HELP_STRING([--with-pop], [Support POP mail retrieval if Emacs movemail is used (not recommended, diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in index 0453b93506..ee17576686 100644 --- a/lib-src/Makefile.in +++ b/lib-src/Makefile.in @@ -84,6 +84,9 @@ libexecdir= # Nonempty if Emacs can assume Mailutils is installed. with_mailutils=@with_mailutils@ +# Nonempty if Emacs can assume ctags is installed. +with_ctags=@with_ctags@ + # Directory for local state files for all programs. localstatedir=@localstatedir@ @@ -144,8 +147,8 @@ HAIKU_CFLAGS= CLIENTW = @CLIENTW@ # Things that a user might actually run, which should be installed in bindir. -INSTALLABLES = etags${EXEEXT} ctags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) \ - ebrowse${EXEEXT} +INSTALLABLES = etags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) ebrowse${EXEEXT} \ + $(if $(with_ctags), , ctags${EXEEXT}) # Things that Emacs runs internally, or during the build process, # which should not be installed in bindir. --fadts4yjf3xki6fi--