unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Re: etags name collision.
Date: Mon, 11 Apr 2022 21:19:33 +0200	[thread overview]
Message-ID: <20220411191933.wyxvmgpyd4hnpfc2@Ergus> (raw)
In-Reply-To: <83ee2360aq.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On Mon, Apr 11, 2022 at 07:40:29PM +0300, Eli Zaretskii wrote:
>> Date: Mon, 11 Apr 2022 18:19:42 +0200
>> From: Ergus <spacibba@aol.com>
>> Cc: emacs-devel@gnu.org
>>
>> On Mon, Apr 11, 2022 at 06:51:58PM +0300, Eli Zaretskii wrote:
>>
>> >The code should test whether another version of 'ctags' is already
>> >installed, and if so, that it isn't our 'ctags'.  _Then_ we could
>> >default to not installing our 'ctags'.  Your proposal doesn't make
>> >that test, so please add it.
>> >
>> >Thanks.
>> >
>> I do this tests like with mailutils and movemail:
>>
>> (ctags --version) >/dev/null 2>&1 || with_ctags=no
>>
>> Isn't this enough?
>
>No, because AFAIU this test will succeed also if the installed ctags
>is (an older version) of the program that came with (an older version)
>of Emacs.  You need to make sure the text emitted by --version does
>NOT include "GNU Emacs".
>
Now?


[-- Attachment #2: ctags.patch --]
[-- Type: text/plain, Size: 1610 bytes --]

diff --git a/configure.ac b/configure.ac
index 185e4d0862..ace80aed56 100644
--- a/configure.ac
+++ b/configure.ac
@@ -267,6 +267,19 @@ AC_DEFUN
 fi
 AC_SUBST([with_mailutils])
 
+AC_ARG_WITH([ctags],
+  [AS_HELP_STRING([--with-ctags],
+     [rely on System ctags; this is the default if Universal ctags or
+      Exuberant ctags is installed])],
+  [],
+  [with_ctags=$with_features
+   if test "$with_ctags" = yes; then
+     (ctags --version | grep "GNU Emacs") 2>/dev/null || with_ctags=no
+   fi])
+if test "$with_ctags" = no; then
+  with_ctags=
+fi
+
 AC_ARG_WITH([pop],
   [AS_HELP_STRING([--with-pop],
      [Support POP mail retrieval if Emacs movemail is used (not recommended,
diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in
index 0453b93506..ee17576686 100644
--- a/lib-src/Makefile.in
+++ b/lib-src/Makefile.in
@@ -84,6 +84,9 @@ libexecdir=
 # Nonempty if Emacs can assume Mailutils is installed.
 with_mailutils=@with_mailutils@
 
+# Nonempty if Emacs can assume ctags is installed.
+with_ctags=@with_ctags@
+
 # Directory for local state files for all programs.
 localstatedir=@localstatedir@
 
@@ -144,8 +147,8 @@ HAIKU_CFLAGS=
 CLIENTW = @CLIENTW@
 
 # Things that a user might actually run, which should be installed in bindir.
-INSTALLABLES = etags${EXEEXT} ctags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) \
-               ebrowse${EXEEXT}
+INSTALLABLES = etags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) ebrowse${EXEEXT} \
+	       $(if $(with_ctags), , ctags${EXEEXT})
 
 # Things that Emacs runs internally, or during the build process,
 #  which should not be installed in bindir.

  reply	other threads:[~2022-04-11 19:19 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220411124736.3qijvtearh6wlen7.ref@Ergus>
2022-04-11 12:47 ` etags name collision Ergus
2022-04-11 13:18   ` Eli Zaretskii
2022-04-11 13:38     ` Dmitry Gutov
2022-04-11 13:52       ` Ergus
2022-04-11 14:11         ` Eli Zaretskii
2022-04-11 14:25           ` Ergus
2022-04-12  7:16             ` Alfred M. Szmidt
2022-04-12  8:30               ` Andreas Schwab
2022-04-12 10:48               ` Ergus
2022-04-12 10:51                 ` Po Lu
2022-04-12 11:03                   ` Ergus
2022-04-12 11:13                   ` Dmitry Gutov
2022-04-12 11:28                     ` Po Lu
2022-04-12 13:45                       ` Alfred M. Szmidt
2022-04-12 14:29                         ` Dmitry Gutov
2022-04-12 15:36                           ` Óscar Fuentes
2022-04-12 17:13                           ` Ergus
2022-04-12 13:45                   ` Alfred M. Szmidt
2022-04-12 13:45                 ` Alfred M. Szmidt
2022-04-12 16:40                   ` Ergus
2022-04-12 17:21                     ` Alfred M. Szmidt
2022-04-12 17:48                       ` Ergus
2022-04-12 19:50                         ` Alfred M. Szmidt
2022-04-12 20:49                           ` Dmitry Gutov
2022-04-13  5:45                             ` Alfred M. Szmidt
2022-04-12 17:53                       ` Stefan Monnier
2022-04-11 13:59       ` Andreas Schwab
2022-04-11 14:07       ` Eli Zaretskii
2022-04-11 13:47     ` Ergus
2022-04-11 14:09       ` Eli Zaretskii
2022-04-11 14:18         ` Ergus
2022-04-11 15:46         ` [PATCH] " Ergus
2022-04-11 15:51           ` Eli Zaretskii
2022-04-11 16:19             ` Ergus
2022-04-11 16:40               ` Eli Zaretskii
2022-04-11 19:19                 ` Ergus [this message]
2022-04-11 19:39                   ` Ulrich Mueller
2022-04-11 19:53                     ` Ergus
2022-04-11 21:04                       ` Ulrich Mueller
2022-04-11 22:20                         ` Ergus
2022-04-12  7:21                           ` Alfred M. Szmidt
2022-04-12  7:34                             ` Ulrich Mueller
2022-04-12 10:53                             ` Ergus
2022-04-12  2:28                       ` Eli Zaretskii
2022-04-12  2:43                         ` Po Lu
2022-04-12  5:03                         ` Ulrich Mueller
2022-04-12 11:13                           ` Ergus
2022-04-12 11:48                             ` Eli Zaretskii
2022-04-12 11:56                               ` Eli Zaretskii
2022-04-12 12:50                             ` Ulrich Mueller
2022-04-12  7:16                         ` Alfred M. Szmidt
2022-04-12 12:15                   ` Eli Zaretskii
2022-04-11 16:46         ` Stefan Monnier
2022-04-11 17:01           ` Eli Zaretskii
2022-04-11 17:41             ` Stefan Monnier
2022-04-11 18:15               ` Eli Zaretskii
2022-04-11 19:11                 ` Ulrich Mueller
2022-04-12  7:42                 ` Thierry Volpiatto
2022-04-11 18:15               ` Ergus
2022-04-11 23:09               ` Ergus
2022-04-11 14:10     ` Andreas Schwab
2022-04-11 13:56   ` Kaushal Modi
2022-04-11 14:16     ` Óscar Fuentes
2022-04-12  3:19   ` Richard Stallman
2022-04-12  7:16     ` Alfred M. Szmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411191933.wyxvmgpyd4hnpfc2@Ergus \
    --to=spacibba@aol.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).