From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: [PATCH] Re: etags name collision. Date: Mon, 11 Apr 2022 17:46:35 +0200 Message-ID: <20220411154635.qfw2ijpdahiv5ctl@Ergus> References: <20220411124736.3qijvtearh6wlen7.ref@Ergus> <20220411124736.3qijvtearh6wlen7@Ergus> <83pmln69n0.fsf@gnu.org> <20220411134749.ps6g5ulpbamzm6ot@Ergus> <83k0bv679q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="cjjyqc6ruirykncq" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 17:47:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndwGX-00005d-Lw for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 17:47:46 +0200 Original-Received: from localhost ([::1]:49572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndwGW-0007M6-8t for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 11:47:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndwFe-0006Ym-Un for emacs-devel@gnu.org; Mon, 11 Apr 2022 11:46:51 -0400 Original-Received: from sonic304-9.consmr.mail.bf2.yahoo.com ([74.6.128.32]:36147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndwFc-00018f-8m for emacs-devel@gnu.org; Mon, 11 Apr 2022 11:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649692006; bh=lDudVAROBzoBBjNZQASVSWsSaueRvF5/fxHAD4gKqak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=mvIHFvHvB36qrybew5jN1ZySql4I3mLl+mUMgVKaJTdTEVHowqKkTfctrn2FR3mYucvXzPo9fD1yjlBGG5pcC3aFVfbEXxCwaIm27/2NX+3G72IQ7CcOGDM44w+138XnpUsiV8rGtewdFkLdL13E4QZ1hKXLYAvFURuafxos7UD3huVsHL1b3IWD7lexPq6lRcpoAHEqv0nccO76Ro0e7nDGJgLuIdx3jxobjAXO4WS6QtqTSHynqjFgxWlDfqlceG5AGTCAr1MB6TYuGL8HS7afrAtEAM/IxEQXVxwwRmlr1etU/X3Msxukmhj2POMKuA76s9vtkmvt8hzLccMdpw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649692006; bh=K2uMreFMIlOc9WiEiDnUXb8r7Y/XLYZ4SlXSABuqDRa=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=XOlXvofeug2Qtq5bcU+6wlLp2siMENDsP0DcBkdv7J9Ml+vu9v5UBqMT45ZlbnZXdlzR/UsQudiojeFVvo1ghTXZ8iANRjokkmzBfMUv/UlkJstU2uFs4jFeW+jhjjTGBU9WWm8dV5HE/B58IFeESQU6LdJZAhkLvfK1qefN96UXLYSMlIBUlJ+rAQLuRNp3j18hDPasTyoCTJAWgQ/z+KHrnhJz92WcnIQdiyuhDSa1G09yfGSQGyj3/lVBeS/vGltgaJUmOSNTWliuop216qimujZNgUNJrVMW4xoJIfWSyKSBZ0cTbyCxwxqIs8+1KDcQEPAMUv/ixgbKPTSdrw== X-YMail-OSG: fkEtjCsVM1n9Z.FVMofw6D9rgx2KKE9GeG25ENrdXkQNZpUbKWftwZwRlequMCm _QbdGNHjhGmuqaOYoo.FOiO.bOd6yQJooA5hykmoKhh6QwMRsWmP8WXvvvW.v5gBcfqruZXHAaIU pzum8jRkAB3XgHBtTT85GpkTZoktR_hG7i0fL_lt4OEDecUYzZudmA4f.9MUtHMozjIeJcThLKHS Rm5EsZJZ3pD8mi8A9bovGyMnrnzw7LsOMNqiWcuR.1L.ft8vcS0G5UbVCUlTzt08cvOMoOGy7UqM NDsT8AAa1ZwUFrHtMxDVaQmZHFSx_ZZMjlXhjF5Yazdz2X4a2tdJE6i73W6epU_8KpYj4EjTOsf9 T1S1zWHUEkqsotrlLdOaXWXE1hqiiKlJtGEdnfL8lVZ98J3Jmdrglxv4jRU3vjQkHCMwL8NYDduI P6c1ZBJmBbnCopB9pcjvfWSPFWZw5w72xuuBnPybGCeOyOviBmVuw3oVDBKkgUrh_8bXlY5Y2KfP AgPUM4qt9vOWfC1mF94vTjyYYqHk6XUKsS2CEinyJPwretfERH.hptvT_Lj6ex.SqQqyzzkpNRAB 0OdRWu_qPUydjkxkEax5eP_QUisRiWcTjQCqJjLpvnaZUrorXk5blkMgF6t7ol3BdDCKkC0ll33k slauwNn1GqWhXTfOamxtTytqawPRc8tcwoLEFkEC.ZY8cgSB49GndWjkvMNHnTwWdStYfB2QtVwc 6pnr8halNDnw0n396RAOCpfd.9nqjNCA3R2BL68_mmMq2ngTO3ETkr1d88tLUTvLLVsuRpeQ8ECN qbjV3a5Bvx2UnisNAnelSqKESM.axibhT24IHxZHse X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Mon, 11 Apr 2022 15:46:46 +0000 Original-Received: by kubenode515.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b640b52dfdb293cec9d80876e97d42a0; Mon, 11 Apr 2022 15:46:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83k0bv679q.fsf@gnu.org> X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.128.32; envelope-from=spacibba@aol.com; helo=sonic304-9.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288220 Archived-At: --cjjyqc6ruirykncq Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Mon, Apr 11, 2022 at 05:09:53PM +0300, Eli Zaretskii wrote: >> Date: Mon, 11 Apr 2022 15:47:49 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> >Emacs doesn't need ctags >> >> So we shouldn't provide ctags by default. > >I'm opposed to dropping stuff just because we can. If you want to add >an option not to install ctags if another version is installed >(similarly to what we do with movemail), that's fine. What about the attached patch? --cjjyqc6ruirykncq Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ctags.patch" diff --git a/configure.ac b/configure.ac index 185e4d0862..25e45d9ac6 100644 --- a/configure.ac +++ b/configure.ac @@ -267,6 +267,19 @@ AC_DEFUN fi AC_SUBST([with_mailutils]) +AC_ARG_WITH([ctags], + [AS_HELP_STRING([--with-ctags], + [rely on System ctags; this is the default if Universal ctags or + Exuberant ctags is installed])], + [], + [with_ctags=$with_features + if test "$with_ctags" = yes; then + (ctags --version) >/dev/null 2>&1 || with_ctags=no + fi]) +if test "$with_ctags" = no; then + with_ctags= +fi + AC_ARG_WITH([pop], [AS_HELP_STRING([--with-pop], [Support POP mail retrieval if Emacs movemail is used (not recommended, diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in index 0453b93506..ee17576686 100644 --- a/lib-src/Makefile.in +++ b/lib-src/Makefile.in @@ -84,6 +84,9 @@ libexecdir= # Nonempty if Emacs can assume Mailutils is installed. with_mailutils=@with_mailutils@ +# Nonempty if Emacs can assume ctags is installed. +with_ctags=@with_ctags@ + # Directory for local state files for all programs. localstatedir=@localstatedir@ @@ -144,8 +147,8 @@ HAIKU_CFLAGS= CLIENTW = @CLIENTW@ # Things that a user might actually run, which should be installed in bindir. -INSTALLABLES = etags${EXEEXT} ctags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) \ - ebrowse${EXEEXT} +INSTALLABLES = etags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) ebrowse${EXEEXT} \ + $(if $(with_ctags), , ctags${EXEEXT}) # Things that Emacs runs internally, or during the build process, # which should not be installed in bindir. --cjjyqc6ruirykncq--