From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Thu, 7 Apr 2022 11:08:45 +0200 Message-ID: <20220407090845.rvjzos3pp6f77qrz@Ergus> References: <4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com> <86bkxfibdo.fsf@mail.linkov.net> <20220405232013.5y5jnr4ykzqgxqla@Ergus> <86a6cyiqlt.fsf@mail.linkov.net> <20220406132108.evlofp5l3krsl5h7@Ergus> <86sfqqduon.fsf@mail.linkov.net> <20220406181339.iubahj6fviq3fyqv@Ergus> <86o81eawnv.fsf@mail.linkov.net> <91135A5B-17B9-4B1A-AFB9-40D2656313DE@aol.com> <86ee29pawb.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 07 11:11:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncOAh-00043H-8i for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Apr 2022 11:11:19 +0200 Original-Received: from localhost ([::1]:45592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncOAf-0001NM-Tl for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Apr 2022 05:11:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncO8R-0000d9-V1 for emacs-devel@gnu.org; Thu, 07 Apr 2022 05:08:59 -0400 Original-Received: from sonic301-2.consmr.mail.bf2.yahoo.com ([74.6.129.41]:37484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncO8O-0003zd-Tn for emacs-devel@gnu.org; Thu, 07 Apr 2022 05:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649322534; bh=h9ADkBAaihgWk3sbCiHXzHlKG3xfWJJU7yb+AuLj2PY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=MKZU3+QAVhtVApgubGR3T1Ydrg0EkWluZ2NbCQTF7r112RYLfEPE9u0yFcN7Jim59LUs2XEue6NsBgh5KOMQsfb7QMaxEhyQhrmyY452gMnMtIedDRkNL5LsbkvFW76396JLFxM3CO4UGnJDQMzgINxtqRr6Uiary83a1uPEPCW5GJVcP95ZHXU/BMO5BmW95BKDw9zvktHmNJOCKtngboJYvHiF3tPo7PQw4eK0zz+ed1REyiH+azpm6zsddfENq11CYDWGnir8xwt7G7NWTylSkG1Mo6syjtoAKc0TTmgbWBRCs3/oeA1VYRu+ZLyzJZMD6qwUbLcyfUWelRRA4Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649322534; bh=V0mCJJNonsfHsuPALk1IYuAiXEkpm3XwbP9DCkolUQp=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=gjuDwVpuvcVUGo3SBuHIE5ERTMFkCZ5zOak6UUl6HNBxYFb1Icg5T1N1rq6wmjG2yQUDgjJmDNs0e/DUKlpigRL1Wr8O8Q3UBIaGVAfzvptJ8z4UhDjo2AO+5UZ0hoRvLXW6sGKf3wzQyB7yVJfiYERL+oIp1ryQgw1eCQRAE/Faem792KA+Y2EbVbOs1/R7qw0hxNm/NpPorak/qPo5ZfLxcN7o4kb6KC9Ac04UttbPFd+hrg0ANGasM0GMtiwUaAQdEUqA6QJZkuWjFl6iFvm3BfcVmJEjMV8xVc40TyLjuTFfoys8wsQx9j3Pt1+ZMMGn+3sE3054HouIX5Oquw== X-YMail-OSG: LbttiMYVM1n8KfRdMN3zA1uSIcOyL9cMOKLf6tiBypr978Ov2o8mbUsX3_DBZeh gMgW9T68zTjJrukAKKF_4QxdcMisjkky0viGQ7.CqMf.wXG6zND.tiFRLe40TnpOgNmkZJ1iBW8S pfb1Xn3j_8fW0XXGtRTPYvxMYmGARCCOvMHb3YIOAYCsr1Uh6hxkNCFhhUnaVuKx40qEq90g6WmJ QZbNL3ghYDVtcwaEIUICqUiL.PEZbMd9IQ9KsUPQ8iUA74EPVHYB0hq_IIxBftseZ5L0eN0y5gM0 qDWv9SIbnJ8Fgn5S2yCMErfvcDvw8goGBmX9OS7qlKvEeFQDa_rRhRSLaKfBEphEkJTUMbqmYzE. KII2HQRoufudpn9YkqslvL7CcoJTMhMNWuePkeQeDKOW3MrKnVeLSRN5.8lBmn4tyzcbjuIPJ2zQ zHss8zJuKQZZaBS0Ao9KQlgkDvNUtXKqrvz0FrYnE5NdyZ3M5RCpYdtkyKvf8h2uRXfefB1ZSDW0 EJdA6M9a6Nu.Je0qOJ.M7wO6vvIhwF178bsoCYF2o8zsOcwtfy.hxrd.c01TW7wYTlnGKvsgmnKz pwdHDvw2UIpQLirmcVGy0FLq3FR0haTajwHHSYN0EkSdCjbWj3Gi1Qz3a2WkOTAJ15KJMFQfyhtg q8IOrrZDx9nmClLU0gLeQaOsK3JOJPOQ47iTG.Kg5VJcXotQUX3G2Kn7fuX6Rdgy94Jm_dStI5Zy d.rO6GI.7ByZPlnMQ6CFgkZfhHFhHNEaXpgMif5V_PtoivRodJmffIqBG07ILesrXUbIc3AbfiWK cjVtX07hKY5wZnA2LoHamF7hjAL6uhmKuyfxehsXcR X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Thu, 7 Apr 2022 09:08:54 +0000 Original-Received: by kubenode512.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 0214d2a0947e6914b59c65a5ff7f64be; Thu, 07 Apr 2022 09:08:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <86ee29pawb.fsf@mail.linkov.net> X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.129.41; envelope-from=spacibba@aol.com; helo=sonic301-2.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287878 Archived-At: On Thu, Apr 07, 2022 at 10:39:16AM +0300, Juri Linkov wrote: >>> Do you mean addition step is needed where first C-g/ESC will clear >>> the suffix, then another C-g/ESC will exit the minibuffer? >> >> We need a simple handy way to restore the mini-buffer as it was before >> the navigation attempt... >> >> Maybe, let's look more at zsh and similes... That's already tested to >> be intuitive so we don't need to reinvent the wheel and their users >> already know. > >C-g in the completions buffer closes the completions window, >then the second C-g in the minibuffer exits the minibuffer. > >So C-g in the minibuffer could be two-step as well: >first C-g closes the completions window and clears the suffix, >second C-g exits the minibuffer. > The most I go into this the most convinced I get that completion-auto-select and selecting the Completions windows is the simplest and cleaner way to go. >>>> 2) In tabular navigation the down arrow always goes to the first column >>>> which is wrong; maybe it should use next-line or line-move instead of >>>> forward-line? >>> >>> This is what I tried first, but byte-compiler complained next-line >>> is only for interactive use. >> >> Then it should probably be line-move but forward-line goes to column zero. > >Neither of them wraps to the beginning like next-completion does. The wrap behavior is only set for tab and backtab commands (yes, it is hardcoded there... don't blame me) not even for all next-completion uses. I prefer not to touch that code anymore or add more stuff there... At some point we will decide to fix/replace the mouse-face approach there and all this will be a nightmare to support the legacy behavior. >This means we need a new command next-completion-vertical. I already tried that in the first version of zcomplete I did long time ago. And you said (and I agreed) that it was too complicated.