From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Wed, 6 Apr 2022 20:13:39 +0200 Message-ID: <20220406181339.iubahj6fviq3fyqv@Ergus> References: <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> <86czhw4oqr.fsf@mail.linkov.net> <4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com> <86bkxfibdo.fsf@mail.linkov.net> <20220405232013.5y5jnr4ykzqgxqla@Ergus> <86a6cyiqlt.fsf@mail.linkov.net> <20220406132108.evlofp5l3krsl5h7@Ergus> <86sfqqduon.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21944"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 06 20:17:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncAE9-0005Xv-Mr for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Apr 2022 20:17:57 +0200 Original-Received: from localhost ([::1]:51624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncAE8-0006NM-IQ for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Apr 2022 14:17:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncAAD-0002XU-A7 for emacs-devel@gnu.org; Wed, 06 Apr 2022 14:13:53 -0400 Original-Received: from sonic308-2.consmr.mail.bf2.yahoo.com ([74.6.130.41]:35773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncAAA-00033v-GR for emacs-devel@gnu.org; Wed, 06 Apr 2022 14:13:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649268828; bh=Rr64Z+EqudffjqDPNh8dtS5zrKEAwE70O6y9uirr3PA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=CyN68vMGD71RYZ35TLlZJmGu/COLHeMAOvkdPTQ+l3ms5Jo55BY7QW2pxHAAolzwJd5VSORmNRCqvhQRf4skgG/R5/3WFOWRliextLJaQHucwtBF6df9IgfRMIURe3tNlG+i/HHeYQAxAz7jxBcnZMZZv7cZLR3QINnxyC2XjLuC0zJJuSYFd2HHH1iRoYLo555t5MDeKBIhgDb0xn0hrr7vUX2LpxAnv3igOSEl9UJ2Fbci1paxIGjiQDkC1FGcN0tNEsFVMKJOrjMXriFX6YlygkGG+5SsTZmLvEoreVULnR+XeJxU5nWcTw1SUX9oLPZDbNIygxBnTRIVTMrnXA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649268828; bh=i54MR4jnK4IqdCa1mF4Frun3cfv2j2iT0l0pzAtzE7M=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=uYSr1AkwzJ1FoaTrJWs+0pque/njkD+Ntv53+z1c0fU2OVldwDCcr52vqxj5XWQWeOiyL9T5ED5p0lR9dlbY2jJoBKDOaYoaqgdpkXHFzOCH5BnV8J6C/+c0wb4RXXVBF+dKVGfTSUHgxrqFY7bK7B76MP0k3UDFwgseVSJSH1y1XS71sgqb0gvhdw8OPP0Cg9mosD411uLsJSJK0zO3r3nk+OdA5Zcbsnf5yRNCUz6A/b+m99C7l6yxCfgeg9y9TiYODjp1FiWbrosGybB0FQThHio9B6WSeVLk9kTu19rQ9pgfnPVKEUthb3yTXdQXuu5ZDo3aRqfwi5xw+DxFGA== X-YMail-OSG: Uf6FCAoVM1mM_cEcohY9EdWnUd7DYPmMQXk2mju5iO.cJXpQNizUZvFo51ctLx4 qRCIPkldU1FT8gvNkENRsMq_PmGIJx3BQUk_a3VwiNs92JFKhazDm6WIC0xXBLXDZOkBsKZM6__c TUcQyU1c5Hcue5cm7XNVgWB77C_2kD3ArQZo0ZAS7yKHvzsl5FBOP6wV32UuJgprvDQHe8r75Q0m TgrrdKaupy60NJnXWvbXJCGUCCDgH7exmmeo4AAqlebj7xZ.F1IyU66kn12eR.u1cjn7EU_qEs.c Ebs92UNm_zoiUYFANfjULVCTnBM9mnOUUPr.Z9s0LxYnWe1hRrHPk3a4.E5gmYGvqx8jcrGHAfKu WyM106hKdY9JHqRuh6BlloQVI4Al5BZ7vAkCHptPEvvNmYM5DTcO3d4Pxsf6MihpaRywMnalXz2n 2Qzv6nOWHXsoiC4tNqb2tZthSUbENHcPQlWm7szOX0.NgmO5v2LmHKZF3uPLGpjRqBCfpEOWytk4 QHcyCkx354YVA.DrGZMyJNbt1Ly52Uj.dKJIVUmIED8dbPc5dUa_qAW.7boT4YJXYifQvpUO1VTr u.ejbvVu3Mx.dtwcJRGrRrBnfh6qTPewGbzKdNTo43D0.lrQp3m2_9Al2c6mGcdkBfJOkCy2E846 MfvCU203_hk5RtgV9IZKG6E49JYoxC01lKV3acQPWqbbI77zbWSt.3P6Y0ar0pfPLRqIhp6.Qfht _nIhg4se8qSEYsAu6FUC4wOsCVD8WVojo8XPJ..RDs2AmRdwD1cV3jmYE6ygZgIq3bSQXsNx2vEk EEfPyK94d.SIccRtxOhAEhRXvyzMbqFsjjl1H8CWdf X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.bf2.yahoo.com with HTTP; Wed, 6 Apr 2022 18:13:48 +0000 Original-Received: by kubenode510.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 446e64d56703a8192689ab4b6fd5d10f; Wed, 06 Apr 2022 18:13:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <86sfqqduon.fsf@mail.linkov.net> X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.130.41; envelope-from=spacibba@aol.com; helo=sonic308-2.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287849 Archived-At: > >Here is the next patch that does this and allows using all arrow keys >only when the completions window is visible: > Ok quick check :) With the new option the behavior gives a much better navigation. 1) There is still the issue with C-g or ESC canceling everything 2) In tabular navigation the down arrow always goes to the first column which is wrong; maybe it should use next-line or line-move instead of forward-line? 3) It still needs and extra binding to insert and then to another execute... RET just removes the highlight and nothing else... which is un-intuitive because the candidate in principle is already selected. I am not a good lisper, but I think that an approach with a minor mode or a transient-map could end up being simpler and more modular without adding more complexity in the existing code... WDYT? Best, And thanks again Ergus