From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Wed, 6 Apr 2022 01:20:13 +0200 Message-ID: <20220405232013.5y5jnr4ykzqgxqla@Ergus> References: <20220401153839.idrzrbfl2yfzga3y.ref@Ergus> <20220401153839.idrzrbfl2yfzga3y@Ergus> <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> <86czhw4oqr.fsf@mail.linkov.net> <4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com> <86bkxfibdo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31478"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 06 01:21:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbsUF-000812-Vl for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Apr 2022 01:21:24 +0200 Original-Received: from localhost ([::1]:60166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbsUE-0004vJ-Ej for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 19:21:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbsTJ-00049J-Ti for emacs-devel@gnu.org; Tue, 05 Apr 2022 19:20:26 -0400 Original-Received: from sonic309-14.consmr.mail.bf2.yahoo.com ([74.6.129.124]:44358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbsTH-000322-0V for emacs-devel@gnu.org; Tue, 05 Apr 2022 19:20:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649200820; bh=ASHihNcPPydD635eSya4rB7w4qAQ3YquLOcN5ttfMw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=YQ14VVikO+Sjxqab2WwLva/2X9rEx4itn5Vb1S+PZbU1KpaMTUdVYnQ04871H6+gkGGgt9Ch1PU1c+C928e8qhnsq9DB90ehGUN6wMhYNjmCo/BcclctRwVjAvkbm2PvIWbYSg+xvqMVOXSdkejJXo1/YZ/VgNIZOSDwX71wp8G86vhGk2Ni/0+DhbMl85rnpjzcPh9vIU77q1bCummtytxuFarT4cuGKtamNqcjz3LfSUCamWH5I866fyPK8isirnYnlpplILkoDbjzQx9wcXvZlU35IVnxSbUAGOzxRHCyYXy2oh9O8o2adYIJUE1XenltmheQnzOJnFzuW7y/XA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649200820; bh=Tlt8WwlM6mvDUsMXzgPw0tiIQfY6ejdi3v3+xuLwYga=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=ZMy8TZIDP/LanSKBnu7GbSVt7OZ4rQrmiQHESJJet2QDujE10wPN6qObNGPnNqIKLuzOnoqbksCspe/9QpY3dfyc5ErX7PVBJQ5xpqLnmkeKiHdGd3Ha/C4ktXiUK1c2KPU1kqn92h1Dm49Z1HwzAvSrYJ/Mylb4O6ZHcbbZ4HubEcvk68Edq88hjfIySMmJc9X2qM+AjinEKYhI9B4W/gjNCs89qZNfl1YsTb+HVwJ9wgvFwEbUERhcrKfM9udE4UQxzgWgOjAmBPrAn+3B8yMxPfggcL/8VEiwwn4vsqxRYnCo+YqAIxbsyGeKCzSlzF3xMEHRgw0fznubf2WeJA== X-YMail-OSG: caNpzwAVM1n8ZPsP7ypFetVMyO2tpWTbDKuc33OWfXrHBdhUHoPIsK7QiY9kWch g7OBXoeeycD2S64MVQchCaJHVcARLWwxZ61.H.IvA4nEwQ.6Uup20DIDON5HhJ5SDcPfNDBcxVKt OgLDqadpUdtP44FBN0.A8xRdyqlg_hJQG5hsSiRI8GLI19o862v.p4ZF.kszxs5z1y.93t7J0iG. nOt98iplbzQAnNOCQQT0uYrRVq16omt214oI5I__BAnnmqJxinVsYimd1W5GCQGHXNvYwsmKTlhB aImaJX0dodGL.OpREy1cEeLIwLti3R4RDtHKEN38PvILwE2ZmbIbHroBbohfoZqbV_jwrMIJPBd0 nCucM8Znfk8My.fcKFV0MAAhhhqNSHzFIXFPKupb5EvAEdwMWTFxcATWpg6hk2eM6X2hQ1W7h.za HmBZc6xjDQO6vZ3Pez_C65REs4gfpIQxYYeUzkH4Jjoj4XiruXf3NYW9gOBtETwXSnpq1wegaYuJ xOmbyNwlCMW_eFqTeC1apyeK5JVuFnOAz3y0kWVcSlidQQYOdo_flusAmVGNwaRpYUepbvB5L1x9 4Uplv9uHtxQvy5PNQJIQVTHne7X_FvJG28gwIGOa3RHZQq1fAQ6EYGBzr0GiLsFK3UmmvAObwg41 O46MhPLNMGNuBYBJnFngV1wKr5d67yKWwEbI2cl3zdPGYGcIXLDnOeduG1k5LQbzSY1zo9iYbodi u5pBxqj268p8YBFDfUEaVViqPFI0ELvKyz6KGtoTgTX_dHcMfL2H2YCSprOsOhDmwc0zgVo4j5vF Y7o014Czuc05GZey1iwPh4t6FBxVBQurIrfj.XV3R0 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.bf2.yahoo.com with HTTP; Tue, 5 Apr 2022 23:20:20 +0000 Original-Received: by hermes--canary-production-bf1-665cdb9985-85ftg (VZM Hermes SMTP Server) with ESMTPA ID 42c125b3a65a04a4884bebca12f67fef; Tue, 05 Apr 2022 23:20:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <86bkxfibdo.fsf@mail.linkov.net> X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.129.124; envelope-from=spacibba@aol.com; helo=sonic309-14.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287824 Archived-At: On Tue, Apr 05, 2022 at 10:22:11PM +0300, Juri Linkov wrote: >> BTW Juri. Do you finally plan to add the mini-buffer navigate completions >> features? > >Now new minibuffer completion navigation commands are pushed to master. >Hope this change doesn't break all completion frameworks. > Hi Juri: Thanks for this... Sadly after trying it for a while I find it very uncomfortable. :( maybe we can do something to improve it please?? 1) I think it is more intuitive to invert and use the M-S- minibuffer-choose-** and M- for minibuffer-{previous|next}-completion for not insert commands... Alternatively (IMHO much better one): Maybe you could consider to insert the candidate, but keep the cursor in the same place and add a shadowed suffix after the cursor in the minibuffer. So M- navigates, and inserts suffix but if the user types a letter the suffix disappears and the letter is inserted in the right place. In contrast if the user press RET, as the candidate is already inserted the current behavior is unchanged. 2) The M-/M- is not intuitive when completions are not in one-column format, and the M-/M- cannot be used because they are already taken.. Do we have any other alternative? I think there is a problem any way because 2d navigation with this is impossible... 3) I think that the bindings in the minibuffer must be enabled in the completions buffer as well, otherwise it becomes unconfortable; specially with completion-auto-select. >> May I finally add this patch to master?? >> >> I don't know, maybe Philip has no time to review your patch? >> >> On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote: >> >> Hi again... >> >> Here I attached a small patch that makes 3 small changes: > >I noticed that your patch broke some corner cases: >when using minibuffer completion navigation commands, >it fails to go to the previous completion at the top. >But since this is now in master, you can see it yourself. > My patch can only affect the TAB and backtab commands (look at the if condition)... So I don't see how it could affect you commands ;(... I will give it a look tomorrow... Best, Ergus