Re: [PATCH] Re: Other details about completion.

[Ergus <spacibba@aol.com>]

On Tue, Apr 05, 2022 at 10:22:11PM +0300, Juri Linkov wrote:
>> BTW Juri. Do you finally plan to add the mini-buffer navigate completions
>> features?
>
>Now new minibuffer completion navigation commands are pushed to master.
>Hope this change doesn't break all completion frameworks.
>
Hi Juri:

Thanks for this... Sadly after trying it for a while I find it very
uncomfortable. :( maybe we can do something to improve it please??

1) I think it is more intuitive to invert and use the M-S-<arrow>
minibuffer-choose-** and M-<arrow> for
minibuffer-{previous|next}-completion for not insert commands...

Alternatively (IMHO much better one):

Maybe you could consider to insert the candidate, but keep the cursor in
the same place and add a shadowed suffix after the cursor in the
minibuffer.  So M-<arrow> navigates, and inserts suffix but if the user
types a letter the suffix disappears and the letter is inserted in the
right place. In contrast if the user press RET, as the candidate is
already inserted the current behavior is unchanged.

2) The M-<up>/M-<down> is not intuitive when completions are not in
one-column format, and the M-<left>/M-<right> cannot be used because
they are already taken.. Do we have any other alternative? I think there
is a problem any way because 2d navigation with this is impossible...

3) I think that the bindings in the minibuffer must be enabled in the
completions buffer as well, otherwise it becomes unconfortable;
specially with completion-auto-select.

>>     May I finally add this patch to master??
>>
>> I don't know, maybe Philip has no time to review your patch?
>>
>>         On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote:
>>
>>             Hi again...
>>
>> Here I attached a small patch that makes 3 small changes:
>
>I noticed that your patch broke some corner cases:
>when using minibuffer completion navigation commands,
>it fails to go to the previous completion at the top.
>But since this is now in master, you can see it yourself.
>
My patch can only affect the TAB and backtab commands (look at the if
condition)... So I don't see how it could affect you commands ;(... I
will give it a look tomorrow...

Best,
Ergus