From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Tue, 5 Apr 2022 13:06:38 +0200 Message-ID: <20220405110638.r2jc2v2aykr5k6bu@Ergus> References: <20220401153839.idrzrbfl2yfzga3y.ref@Ergus> <20220401153839.idrzrbfl2yfzga3y@Ergus> <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> <86czhw4oqr.fsf@mail.linkov.net> <878rsky4ir.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 05 13:08:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbh2p-0006Ca-1E for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 13:08:19 +0200 Original-Received: from localhost ([::1]:39046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbh2n-0000Dy-LG for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 07:08:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbh1Q-0006Ts-CO for emacs-devel@gnu.org; Tue, 05 Apr 2022 07:06:52 -0400 Original-Received: from sonic311-13.consmr.mail.bf2.yahoo.com ([74.6.131.123]:33587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbh1N-0003XV-7U for emacs-devel@gnu.org; Tue, 05 Apr 2022 07:06:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649156807; bh=FGnB8P9/8FM74j4zU4eV5GBhhJWMWZF0hDfQ5l1bYPM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=ZIPSTg2rUJsiX7NiRjEHNpOOJWO30Qpbwh2Ds02OlSCZ1z9SOmWGvbNPnsdQgk4dYslRZIbzj5oem125+xyMo/eFbLlG9cphyAi5AQ3xwpp7AoVmE2Jwb4EDo9UwnscVH0j9tA9DsAaiQgh5AfhgUJrC4zWSdvljh/aKq4YG7HZhRBIxquFPTqBqqOUaoN9Et/RNc5ccduqSWos3DTS2j2eu7isLIyoGHRDp5J41jJFn5E/lD8QjQgdjMGooC+vlXf+uN2jbo/b6CFC2ZujoYlgyBvVYQA0Ehprsdw7YCSfRNJMDP4fchUW5+PcnDH7RKcpKh5BCbOrR/Vj15scwag== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649156807; bh=6T6dSPAYtGXMAMyy4BfuinKnFDlfZ/ShOqM91AUnLew=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=oRcsn7f3KZMF+OaSRraehYReToUS4gKPWSC2R1E//GTEs2QoPZfpzZr4PcyONxrevswxAXZI/bLTLqcwJZUdSvxbzNIEtVb7+z2oJxQYpOAAdhvV5hskuQ9FX7WogVywmWdgWsgeolTxzIJjXAYGY/xhbwKuoQpQrW0ostwrsRKC15OAak6g6PyVrNfvOd7BoIt7R4d6MAWvjLNL9n09sfiFsCqdH09dLOksy1du4kidy8wSuNvhj9WH2CgBH47BMN2cWLXuXkzvTWCRKc/J+V82s8vqLCRCP+yFMpWHBR9R+jTVYa/6qa/YKPjtUPiyhJpUCM5NzMr5hQ4IOCN+7g== X-YMail-OSG: babuFKUVM1nv_VKFDgf82zKR6fYZR4eiYGcgx9PsaPM0lAO0QKZCrDRSKgCecmv ePiUavaND498X4C958QVmej4DV8XZWSnhv8xTyo0MCE6PLRi6l6lDysUkU2kRabZLcZyQW1eKLGK HJZencMM1aDPsmpAV3p.hrTbf79tLxd18uY4NagZIiqOQfeg3Aqjrzi7QvigG1LE19.Ox6Ej_cwr EHkMeQkm5t0_43P0UB5YjVAbpbXD5P5.b2HPy_4x0_4ENNHSurW8A8aSZykIP.JM5sUuKMSvhK2f 932Ulrh1IOqWPr_cohxr._Og_EW3YOAhhrr.724d5CcKoCpyzNYaokIonYySnvOSGKKMbXq7w1ST 2N9eKSealqp.qI5OHTM6nUHbj.sl8c62MqkjbCk2yUb31iE0M0WSvEMNxSI3UAI4tFnT.Edcg4xd 9UBae_acUKq_NV._aLG9RsWNuqK6bIq6BKdJtYiwexqxMQ588LNC80No2KEEgtIeXDI9ytm8wlDg 8Oa7Bj6ONQuJ4T_iPT4HjEv8yrHG.ReVj9L.0Vg3uvbp7Zz97O8_SdMXZR9Xj6gH2mYi0YdCgNlD Mi7KV8Dfyj_LuOLQY7R1UVzIowIWSmZ9YvXyGkbSrL0RU5hiTUYKeFW5u_mICEBLhPKAs.gyZuZE WTzzelyWb31SkoxhWW4_2PJPqAZF_I37T7vnZIaFN84_TBzP0ap7x6VOwh4.r.uQK24LZhHFQu34 uxR.3s6gROwh1qEUyn2npaVJrjUZvx2XjWQs9gzZNDPQhSydhODCqk5_MpfXxgbPLFj2SraQj_V5 8OdcewgamJKV6hfSQ9dENIgWCbVeTrWo7e6R7uWLpq X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Tue, 5 Apr 2022 11:06:47 +0000 Original-Received: by hermes--canary-production-bf1-665cdb9985-wr7kv (VZM Hermes SMTP Server) with ESMTPA ID 13b58cb1a077e72fab894c1611e07cad; Tue, 05 Apr 2022 11:06:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <878rsky4ir.fsf@posteo.net> X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.131.123; envelope-from=spacibba@aol.com; helo=sonic311-13.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287805 Archived-At: On Mon, Apr 04, 2022 at 08:31:24PM +0000, Philip Kaludercic wrote: >Juri Linkov writes: > >>> May I finally add this patch to master?? >> >> I don't know, maybe Philip has no time to review your patch? > >Sorry about that (I was struck down with Corona for the last few days, >so I forgot to respond). Either way, I don't have any objections >(beyond what was discussed in bug#54374 that it might be a good idea to >rethink that mouse-face approach in general -- I already thought on this; it may be possible t do so using other text properties like intangible or similes so commands like next-completion may even disapear or fully simplified; but it may affect some specific use cases like using isearch in the buffer and I am pretty sure someone will complain about that, so we end up with duplicated code to support a custom to provide the legacy behavior... SO I am not sure it worth to try that (sadly). >but if change 2) solves >this then the issue isn't that urgent). > >>> On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote: >>>>Hi again... >>>> >>>>Here I attached a small patch that makes 3 small changes: >>>> >>>>1) Remove the trailing newline in completions one-column >>>>2) Use another condition in next-completion to jump to minibuffer. >>>> >>>>Normally next-completion with tabs at the end of the buffer needs an >>>>extra tab because it goes to the end of the last completion before >>>>jumping to the minibuffer or wrap.. That extra tab is because the >>>>condition to jump or wrap was eobp/bobp assuming that there is not text >>>>unproppertized after the last candidate. >>>> >>>>3) Remove a comment in switch-to-completions. That comment suggested that >>>>the next-completion action must be called inside >>>>minibuffer-completion-help but IMO that is not totally correct when >>>>completion-auto-select has some of the new values. >>>> >>>>Please, if anyone could review,correct and push I would be very >>>>grateful. > >-- > Philip Kaludercic >