From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Sun, 3 Apr 2022 02:39:17 +0200 Message-ID: <20220403003917.k36wm32yv4gg734o@Ergus> References: <20220401153839.idrzrbfl2yfzga3y.ref@Ergus> <20220401153839.idrzrbfl2yfzga3y@Ergus> <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <86k0c71h72.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6916"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 03 02:41:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naoIp-0001it-1c for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Apr 2022 02:41:11 +0200 Original-Received: from localhost ([::1]:47138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naoIn-0002oh-LN for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Apr 2022 20:41:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naoHE-00021o-Fs for emacs-devel@gnu.org; Sat, 02 Apr 2022 20:39:33 -0400 Original-Received: from sonic312-22.consmr.mail.bf2.yahoo.com ([74.6.128.84]:44349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naoHC-00041l-KJ for emacs-devel@gnu.org; Sat, 02 Apr 2022 20:39:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1648946364; bh=UgHq58BJ/KauNnUQ+ljxF7QBElLEC5RbOFGD7p0Jt0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=n4R3XBm/2Yn2MNn6sRxNh0z7CYlYhL7HQ+TjdBtI27+pATYM9pJv+OPpk8LmVlkK6VEQbiWPM02qUGHK5pbMcXOf4SvFvB9t38tmg1iWZXpLujZvy+i3/oDIjH7Ac3mgcaZdKGF8cU+dYbBEZAYBaZaS0rcAQ27X7D16r++7yFM8DwdPcZMz7lVcPinqsD0/BLEwMt5ORyZWeVXTMXsENa0JM9xgZsmNoac06JAvVTxdJbiqFC5bmKyVaDx885WsX77Q1MibanoxiARedtOSsITuOJ8dpN4vYm1B1UrtIRpPsqpT9DDcoMjGEPP4bH5L9sEqZEbHaIQvEYq2bOhZkA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648946364; bh=LEBLGmmvImC4FFnMImzzNBQcExK0rBRR69dwPWnxx5v=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=mLPxt91JpnWKp3lfU9Xk9Wi8T2j8+vGKmRPJuS3P4bJRvJJmxg6Aq+R0dgTBTbcAVSHfTD16cSZek/tvpHY9a804293AUx7DoW5AovYZhe0UmbSN1iD0YQlmiFXmoOcorkZn4zazFuIZcymCCO180ByYRTrgJRTWYoXGiriak2gWMYQuC1TS5YaxqHT+ayxJlg0DBSL0wn45veIM6eNMvlPJaiH+fhPpBWF1YyK5R+AB6gCK1ap+F6rxCjEh3sOpm5COs9CTUH61FGwqadlwRPM8NKCDc78OnvrIB8/Z67TpUkAJPu1pQm9IRDQ/HsEYMpYpsJZ2FUErfYrCmmfX8Q== X-YMail-OSG: Y8IPRuMVM1kOpJIE9VK3S3nYdfXZsZK4tlwNFk4_5E4miZe1xij.nr3amEAMNYV qXrFxiMV_C4xoqKlPBfgrcgT6H3CPMT4RdPt0B2araVlIxgdZ7feZi_zGGtLPQuu3bDUfLssl9Y. yWkcTCR0ritJXZVhxauwj6kZqW88osP.mERUKkJLwbe7kQTYPe9w0toSOba5CPRaJxahHd34P4Ke 6zr5Da.qZDq2Z5wzVO4OvCfcC98AHs1qxuUCOfYLbkOAiUub88GpWDt038bRYDYcV_BybjE.8chB BcavpWNWBo06KD9vU8fRKUfGOyyET3WaqesIwnakqleVaWbNxCCNDYr7xbKoT0mEAcI8ZKbpYRra YhaxsCR9aexuVIWzlKU7ZhBBJN.Yf65SiNy9X20G0H73psKKG2GnSJDap_J_BSqhfASVgkOOTWWF jqz1Byh8wLYP0Lw.3Aayq6y.hKSkzG9d7nbCtFsStcpxQtob7JYUqKteJP3TFHcjGfPtCl.dmyaC HLBkmrXDV0tGSOwq3TCbOLorTPn1d8JwwXOrx8h3ifl6Z_iixcs7eifViAEPKfizAMDHt7tjgEFo cz8ExWWREHsCXCKMqLy94RoHePJOsFxaBhVAmb.eZfH8uIPJttoHWFsWq33eMGFTKCxGQYyhRab6 R_DvOGZJRo0oJBtz6PbwIfP815nAIF5wIDeKPoHP3Ru1GLYk5jKHFMFhYZVBf4HIJUYb51tQ_FJC 5rfBA7XkuYjYmb916xLh7oz0OhjvdADKYvrB6C6j8RNsrWcH80xsACkAiH2yfnYXUKMFxYBJzF3H .rNPn9jL8y0HnUXaEzGpr.sS3VCH_401Ej7ejat64d X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Sun, 3 Apr 2022 00:39:24 +0000 Original-Received: by kubenode504.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 94989f8ebe8dae708b412a355ca78348; Sun, 03 Apr 2022 00:39:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <86k0c71h72.fsf@mail.linkov.net> X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.128.84; envelope-from=spacibba@aol.com; helo=sonic312-22.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287726 Archived-At: On Sat, Apr 02, 2022 at 09:09:29PM +0300, Juri Linkov wrote: >> Hi again... >> >> Here I attached a small patch that makes 3 small changes: >> >> 1) Remove the trailing newline in completions one-column >> 2) Use another condition in next-completion to jump to minibuffer. >> >> Normally next-completion with tabs at the end of the buffer needs an >> extra tab because it goes to the end of the last completion before >> jumping to the minibuffer or wrap.. That extra tab is because the >> condition to jump or wrap was eobp/bobp assuming that there is not text >> unproppertized after the last candidate. >> >> 3) Remove a comment in switch-to-completions. That comment suggested that >> the next-completion action must be called inside >> minibuffer-completion-help but IMO that is not totally correct when >> completion-auto-select has some of the new values. >> >> Please, if anyone could review,correct and push I would be very >> grateful. > >Do you mean that you fixed the problem reported in bug#54374? I have no idea about bug#54374 I will check when I have some time. >I hope Philip could help to verify that your patch works >smoothly with the new features completion-auto-select >and completion-wrap-movement. > Actually I use both... completion-auto-select and completion-wrap-movement ========================================== What is annoying for me is that this behavior is limited to TAB and backtab... I would like to have this same behavior for any interactive call to next/previous-completion (for example when using arrows or n/p). I tried this: In simple.el I changed previous-completion for this: (defun previous-completion (n) "Move to the previous item in the completion list. With prefix argument N, move back N items (negative N means move forward)." (interactive "p") (funcall-interactively next-completion (- n))) And then in next-completion I changed: (member (this-command-keys) '("\t" [backtab])) for this: (called-interactively-p 'any) But the second one always return false when using previous-completion... like ignoring the funcall-interactively... Is this a issue or intended?? Alternatively I could use: (memq this-command '(next-completion previous-completion)) But that may be like hiding the called-interactively-p issue under the carpet if it is an issue. Best, Ergus.