From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Tue, 22 Mar 2022 18:23:10 +0100 Message-ID: <20220322172310.f22uq4bzxrfzrqhm@Ergus> References: <87v8wl35wg.fsf@gnus.org> <86k0d06dik.fsf@mail.linkov.net> <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> <86h7817mj4.fsf@mail.linkov.net> <87ilsgx5fx.fsf@gnus.org> <86bkxz3y1h.fsf@mail.linkov.net> <875yo7p0hh.fsf@gnus.org> <86v8w675un.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8178"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 22 18:24:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWiFe-0001z0-A9 for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 18:24:58 +0100 Original-Received: from localhost ([::1]:35700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWiFd-0008QW-3k for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 13:24:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWiEg-0007Ok-4V for emacs-devel@gnu.org; Tue, 22 Mar 2022 13:23:58 -0400 Original-Received: from sonic304-9.consmr.mail.bf2.yahoo.com ([74.6.128.32]:42114) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWiEd-0005eX-Cx for emacs-devel@gnu.org; Tue, 22 Mar 2022 13:23:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1647969833; bh=PlTyq5Bq0lmLgMGeygrd+4XHqhMdznBlqhq8oLyvA0U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=NSSgDe54+5+MZObxj0efP3QMqOzpC+o9hO9doLDp3Y7LhH1k19PFENxUlh8ioHI4vwELgw9iZRNL+yJWMmQsQnr4HUpUXSRHaz6RE5eHLBFTEe/0OtBhUuH9A4tQuWm1M7IyoFfD2WBHj6zHIBrIzz+uKkg91vNys03HC2xXBgsjvnZDefEHKeT/BgbxiVN5aN7YwRzid/2Ke28CwDADQrW9BgOVwZoCl7L/r6n4QE77SsAxE2XleC5W6c6iN3gW8bqC76KK3MeoDv9DzO2YV5dtfXp67yecf4Kv0KbKAKe7kb89uWh2NuFi0lIXVN0D572bwtGvZadKKUVjHJ+zcw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647969833; bh=d1RWQPxwSPWgu7GggLZYeNuvkaeSVfBuQoTUURnSWdB=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=dzfPTHjesENGXFtOr5rTlK6+NQHjDKaGOH9Z3o8dAlcGJdb6DQMFJhPXotauvMGXZa//6fOh011GRpkxLN4Qv+A1TI01iOBDsgjUbmZDL5tiebuKd480Nm9xzKwgS64XqVPfPE5XvG75hQeiUWoWymyPxqLE4DHUi8lnkiRx+TeZd3Z5Jl1U9LjdMwmsurELpV1dF0nmXknWJPYRB9O/ijwqWoJGEU+XDteLm9slg/aLOV1VE5h+puOiaV9859bWem9huty28VS0cGV8ykjidTDSSPco6pbK6qISo2QZOUlcBDfkq7LnGWndxz3i3+j03Fs9F9Tm9R/fTpBQeCOKrQ== X-YMail-OSG: ixeP9NsVM1kFLZLywPEze5i7lF71H6QVUNIG15afqkhaEu3D.ga2U6xDpA15ipA 76tKh.j0BE3iXqn8CGFcPzHLGyKtoe2tcao..zqifeLjL81Bpt1oF4lRr7xzHAKtP7qOn.VO_pMf p4J.7os0Abh_K54q9Xa4rU8sVoGtBHfJiZSfPLJSlutJ9oDw1ZSRTm0aMkhfsIqkfYIdAS5r2Krc aNb6zsz9gf1StDQQvYvX6ksbLkbpLSr9wvRmErDhlOIRbdKP76oXe9z8Euyw0VAkJmFUwwcVW.q1 c_cumr8DD_WNmRS332TyNKZzYtAYS3F6Qz6cVDvg4aj.xlpJICbNvDZh__v_5OiyhV8T3qX_Cm4f BIVmAUpv5sAKEFLYqDGpkqraNUYY1P0r2lSWVFt57GXqexCQWo8KpRyaLj9ZYAkhwlwkndLx7qze h1httTFhmxVExBwHGPzAj_YWJoqgJFeFts8VyRhGhvSBN5klRl95LZHsmpYOmMj_KvoIMO4PIFit YsKmhEbQTfYD8VnjqJoAwrJi5yyWFEhspEYeaW1tQCFelgsLsAJv3I293jotZnoKnjFn.3FCmrj0 aT0p3vLU_Gd6.1lH1a8MbKUG2INsHKA4P.mhqozyvi3yQPdo9Si18tvan4RJ3BIJnED3HpCpi2Fw NqEoFErEvF_19wgjOmCmMGuDDJrrplopUDHBTxFeINqlolVkrrFo0XYm6TdIH3QLTx1ewXB4ciPl 6EAFtwN5QHfNYgJunOEhnojdZLJBPGz.oztQ0uYoIcW5aGCt9JbFUxAoagcRA5wgafhAlT2Ns8WF uYqvBmSX6ME4LZipKfZwsixUTGNig6HDRDnHy6g4pw X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Tue, 22 Mar 2022 17:23:53 +0000 Original-Received: by kubenode501.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 498eb727c02e6ce3492019dccf0a0588; Tue, 22 Mar 2022 17:23:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <86v8w675un.fsf@mail.linkov.net> X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.128.32; envelope-from=spacibba@aol.com; helo=sonic304-9.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287364 Archived-At: On Tue, Mar 22, 2022 at 10:24:00AM +0200, Juri Linkov wrote: >>> Since Ergus finished implementing new features in the >>> feature/completions-customs branch (and I fixed small things >>> like renaming completion-header-format to completions-header-format), >>> the branch is ready for merging to master now. After that >>> we could add more patches based on new features. >> >> Sounds good to me. > >So now the branch is merged to master. Thanks Ergus for implementing >these features. > Hi Juri: I see that setting cursor-face-highlight-nonselected-window to t by default produces a highlight a bit annoying for some users... So I think that we may disable it and problem solved. For your selection from minibuffer I am not sure how you plan to enable it, but I suppose you will make a minor mode, so instead of setq-local on every call probably you will prefer to do something like: (defun minibuffer-select-completion-setup-function () (with-current-buffer standard-output (when completions-highlight-face (setq-local cursor-face-highlight-nonselected-window t)))) (add-hook 'completion-setup-hook #'minibuffer-select-completion-setup-function) Is it fine for you?