unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Juri Linkov <juri@linkov.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: Select completions from the minibuffer
Date: Thu, 17 Mar 2022 19:47:01 +0100	[thread overview]
Message-ID: <20220317184701.ani7k3clp3impqwn@Ergus> (raw)
In-Reply-To: <86zglsiazs.fsf@mail.linkov.net>

On Mon, Mar 14, 2022 at 09:34:17PM +0200, Juri Linkov wrote:
>> Now there is a variable completions-highlight-face. When nil highlight
>> is disabled, otherwise it must be a the face to use, by default
>> completions-highlight.
>>
>> I had the mode before because I needed some initialization, but with the
>> cursor-face feature that is not needed and the code got simpler.
>
>Thanks, highlighting works correctly when the current buffer is *Completions*.
>But cursor-face is not highlighted in *Completions* when the current buffer
>is the minibuffer.  Such highlighting is necessary when completions
>are navigated from the minibuffer.
>
Please check the change and try to set
cursor-face-highlight-nonselected-window unconditionally in
*Completions* to t when using your mode.

If you could improve the initialization in order to use
cursor-in-non-selected-windows unless the user sets another value
manually it may be nicer (because in the general scenario the user could
set cursor-in-non-selected-windows latter so this variable may have an
outdated value) otherwise consider if this may be simply t or nil by
default. But at the moment it works fine for the current use cases.

Best, Ergus



  parent reply	other threads:[~2022-03-17 18:47 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 18:58 Select completions from the minibuffer Juri Linkov
2022-03-10 19:32 ` Lars Ingebrigtsen
2022-03-10 19:51   ` Juri Linkov
2022-03-10 20:32     ` Lars Ingebrigtsen
2022-03-11  8:58       ` Juri Linkov
2022-03-12 17:08         ` Lars Ingebrigtsen
2022-03-12 18:55           ` Juri Linkov
2022-03-13 14:05             ` Lars Ingebrigtsen
2022-03-13 18:05               ` Juri Linkov
2022-03-14  9:13                 ` Lars Ingebrigtsen
2022-03-21 19:28                   ` Juri Linkov
2022-03-21 19:30                     ` Lars Ingebrigtsen
2022-03-22  8:24                       ` Juri Linkov
2022-03-22 13:38                         ` Eli Zaretskii
2022-03-22 13:44                           ` Eric S Fraga
2022-03-22 14:18                           ` Ergus
2022-03-22 14:49                             ` Eli Zaretskii
2022-03-22 15:21                               ` Ergus
2022-03-22 18:38                                 ` Juri Linkov
2022-03-22 19:07                                   ` Ergus
2022-03-22 19:24                                   ` Ergus
2022-03-23  8:47                                     ` Juri Linkov
2022-03-23 12:07                                       ` Ergus
2022-03-23 18:28                                         ` Juri Linkov
2022-03-24  9:07                                           ` Ergus
2022-03-22 15:46                               ` Ergus
2022-03-22 16:59                                 ` Eli Zaretskii
2022-03-22 17:10                                   ` Ergus
2022-03-22 17:58                               ` Eli Zaretskii
2022-03-22 17:56                             ` Juri Linkov
2022-03-22 17:23                         ` Ergus
2022-03-22 17:52                           ` Juri Linkov
2022-03-22 18:31                           ` Juri Linkov
2022-03-14  8:41               ` Juri Linkov
2022-03-14  9:08                 ` Ergus
2022-03-14 18:19                   ` Juri Linkov
2022-03-14 19:46                     ` Ergus
2022-03-14 20:58                       ` Stefan Monnier
2022-03-14 22:28                         ` Ergus
2022-03-14 22:34                           ` Stefan Monnier
2022-03-15 15:22                           ` Stefan Monnier
2022-03-14 19:34                   ` Juri Linkov
2022-03-17 18:01                     ` Ergus
2022-03-17 18:47                     ` Ergus [this message]
2022-03-17 20:56                       ` Juri Linkov
2022-03-17 21:26                         ` Stefan Monnier
2022-03-17 21:33                           ` Ergus
2022-03-17 22:44                             ` Stefan Monnier
2022-03-17 22:44                         ` Ergus
2022-03-18  6:25                           ` Eli Zaretskii
2022-03-17 23:10                         ` Ergus
2022-03-18  6:28                           ` Eli Zaretskii
2022-03-18 11:16                             ` Ergus
2022-03-18 11:33                               ` Eli Zaretskii
2022-03-18 12:04                             ` Stefan Monnier
2022-03-18 12:11                               ` Eli Zaretskii
2022-03-18 12:23                                 ` Ergus
2022-03-18 12:35                                   ` Stefan Monnier
2022-03-18 12:38                                     ` Ergus
2022-03-18 12:57                                       ` Eli Zaretskii
2022-03-18  9:27                           ` Juri Linkov
2022-03-18 11:26                             ` Eli Zaretskii
2022-03-18 11:53                             ` Ergus
2022-03-18 12:06                               ` Eli Zaretskii
2022-03-18 21:31                             ` Ergus
2022-03-19 19:03                               ` Juri Linkov
2022-03-19 20:43                                 ` Ergus
2022-03-19 20:46                                 ` Ergus
2022-03-20 18:42                                   ` Juri Linkov
2022-03-20 22:00                                     ` Ergus
2022-03-21  8:32                                       ` Juri Linkov
2022-03-18 12:08                           ` Stefan Monnier
2022-03-18 12:13                             ` Eli Zaretskii
2022-03-12  0:14       ` Ergus
2022-03-12 17:04         ` Lars Ingebrigtsen
2022-03-12 17:29           ` Eli Zaretskii
2022-03-12 17:37             ` Ergus
2022-03-12 18:14               ` Eli Zaretskii
2022-03-12 19:30                 ` Ergus
2022-03-12 19:39                   ` Eli Zaretskii
2022-03-13 18:55                     ` Ergus
2022-03-13 17:47                   ` Juri Linkov
2022-03-13 18:52                     ` Ergus
2022-03-12 19:11         ` [External] : " Drew Adams
2022-03-10 19:55   ` Drew Adams
2022-03-10 19:59     ` Juri Linkov
2022-03-10 23:13       ` Drew Adams
2022-03-10 19:58 ` Eli Zaretskii
2022-03-10 20:23   ` Lars Ingebrigtsen
2022-03-10 20:38     ` Eli Zaretskii
2022-03-12 18:52       ` Juri Linkov
2022-03-12 19:16         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317184701.ani7k3clp3impqwn@Ergus \
    --to=spacibba@aol.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).