From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Mon, 14 Mar 2022 10:08:26 +0100 Message-ID: <20220314090826.gyc42227jpvh4efa@Ergus> References: <86v8wlprc0.fsf@mail.linkov.net> <874k454n84.fsf@gnus.org> <86ilslmvql.fsf@mail.linkov.net> <87v8wl35wg.fsf@gnus.org> <86k0d06dik.fsf@mail.linkov.net> <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> <86ee357wob.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8577"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 14 10:10:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTgiz-00025k-On for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Mar 2022 10:10:45 +0100 Original-Received: from localhost ([::1]:37880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTgiy-000563-DZ for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Mar 2022 05:10:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTghZ-0003hR-8Q for emacs-devel@gnu.org; Mon, 14 Mar 2022 05:09:17 -0400 Original-Received: from sonic312-20.consmr.mail.bf2.yahoo.com ([74.6.128.82]:32848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTghW-0004Ng-Sl for emacs-devel@gnu.org; Mon, 14 Mar 2022 05:09:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1647248949; bh=KK/pOPPyfv6YWAYX/HoAUPtEr7U+ZbZZ/5qH0oG07N8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=Woms0S2OG3PyOUlIu5Ny5IaZ94lP34YcOUrlJMsYP2Ohhyfz4C6pp7BPSi9Pcq0QnK9QexHO21A7YOFjhD/CyF4OVgB14lpzC7+Xx36GVLY/ddi3BHwYdSXnK7qk8DbnriikCpTKqGjsL6N9HQacB+nKzAlevGV1tZEc4gREPXf+r9cGlS6SbhCG01X6e3E+ZayT85jHc4OukkPOJ1BxQ6PjQRF4MnS1bkBsgd9i0L1iDvHCybtxhXC6q9VUt+XnsAsxz0EZ64Sean2efuYnZor880JSpc2z6vKIwwFQLJgMWHm0q+M5nOcC3XQ/Dj3sgtlBXCNqsq4abxecI6hKvQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647248949; bh=0SQ9dZ7JHLh/DhpEjdvJCqjdI2UFz3x3INeaT0esFHa=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=Psbottg19M3hN0FhaCKf9gYHSbMC2/aIwWlJB5F6XZ7dmNeJ3L4Mpz44ehDdWPQFWzfrhdp1HHrlW5YAorEJipJSSWzMKqSqIIU7tr49p9Z6rJ/RIMUJL+/Z4k9OpXyHf48fEldLIPAss0Q/lJ5fqlb/WhfLnjucWMmZNh7aKGfINMWuQVQL+bmXf7v7PJ+Uo0mNe+/24LQdsWBeLKNXhocpLbcvJDH+8UjI/3r+V3ByIaPa53m2WE0Pb/2Dvp6sYIAtA8igk6ZQBi5BuIDmMYWKR4ST4ejRJAR3NNReNhcqberOmN+qc4cZIPY5Uuk400xCVy4l3xgWNfICmBL2Hw== X-YMail-OSG: aAOHvEEVM1lMdI28GxmwQZ7FcJgRzGbYxV9u7m2rZ2F0Ia_GXb7JJHs9F4HNVt3 Da1aG_RBAtZjy22VCMnh0btjJdcqBoNXSzo6GapsTSJaZIW9qnE9w0OTXcVnMjBrqthb2id_Jilo ExxKD5UEQuhMyjxr94G5UMNt3KHUwsX_LY2KZAeRW0M0v9117fQEpZhPoas1JKbM6IXzEt9ZVMS7 fYO85VkKnls2Bv604R_r5GxhffFFVO1vsWir_3rCWReZ73ftveGMmQz9OiFPkmX71iZJf8UsSHbT 7YT2gJXJh2_fIih9ZITsRPLME5JLGwpwbsDR9w.dTux81dKk0ksLP8sDFqF6zfHWDB9BZupk9ERZ MqX0MESLQfosYSGlF6qea4FQgLXDJWy4p8zHj58XWN5NNN9lzOfNVT1.64Bs5i4pLlVtQKeB3te9 7NM034aqjDja0IqxYUDILxJhp7_N9czI1yrFxU9_4bKtCLTOlKn32OS.zjDD0IuF7R1G2VSWWQkE 9EUoKBn4GTIJx0HrEg0BBxjNyyAG2MaL6zvNGmbz1JBvPGo5vN2Z4VdIoQSMBs2h5cf3eusyZJh3 Wu3Q3VDF9tmx5v5n9Nwg7dMcT9MGEWUINSWuF0LaGIhY.uH2YA3D1nDMERxTOwBRzC7SE2_klIYS .vn7N34oO5mn6kNqIsGqZT3n7ZbuHPcuIBqMfxgikn.x1fuHOpzfmdEj.HCud5aVW0rQQ28Fj980 J7VDVRo..G.ytlKN7GFbjdUuoFo4wRHgtEwwQZfg.wpRY_PPrKsx6DKA4ALSCz.OnRZF208YH4qM 2Jp46ki3kQZp4mszi4xJbdRbpexdiMVx9hjop4cq5w X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Mon, 14 Mar 2022 09:09:09 +0000 Original-Received: by kubenode501.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 380776741b4866ad115bac0990e96654; Mon, 14 Mar 2022 09:09:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <86ee357wob.fsf@mail.linkov.net> X-Mailer: WebService/1.1.19878 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.128.82; envelope-from=spacibba@aol.com; helo=sonic312-20.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287118 Archived-At: Hi: Now there is a variable completions-highlight-face. When nil highlight is disabled, otherwise it must be a the face to use, by default completions-highlight. I had the mode before because I needed some initialization, but with the cursor-face feature that is not needed and the code got simpler. If anyone knows how to modify redisplay--update-cursor-face-highlight to enable cursor-face to accept cons and plists (as the documentation of mouse-face indicates it should) please just add it there. On Mon, Mar 14, 2022 at 10:41:56AM +0200, Juri Linkov wrote: >>> `M-' in bug#49931 let-binds the new user option, >>> so it could let-bind completions-highlight-mode as well. >> >> Yes. > >Alas, after the last commit c1ea52f4ad in the feature/completions-customs branch >this is not possible anymore. > >Before this commit we were able to let-bind >`cursor-face-highlight-mode' in the new command: > >``` >(defun minibuffer-previous-completion (&optional n) > "Run `previous-completion' from the minibuffer in its completions window." > (interactive "p") > (with-minibuffer-completions-window > (let ((cursor-face-highlight-mode t)) > (previous-completion n)))) >``` > >because 'redisplay--update-cursor-face-highlight' was always >presented in `pre-redisplay-functions', and the mode was checked with > > (when cursor-face-highlight-mode > >But now the hook is added only when mode is enabled. And it is always added to completions during the setup when completions-highlight-face is non-nil.