unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Juri Linkov <juri@linkov.net>
Cc: Po Lu <luangruo@yahoo.com>, Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Question about completion behavior
Date: Sun, 13 Mar 2022 19:50:56 +0100	[thread overview]
Message-ID: <20220313185056.h5xm6b26zrltn7ty@Ergus> (raw)
In-Reply-To: <86pmmpahdm.fsf@mail.linkov.net>

On Sun, Mar 13, 2022 at 07:44:49PM +0200, Juri Linkov wrote:
>>> Maybe better to have the whole string with all text properties
>>> as the default value of 'completion-header-text-property-list'
>>> that then could be renamed to e.g. 'completion-header-string'?
>>>
>> I don't know a simple way for creating a string with the properties in a
>> single call.  We may need a sort of wrapper function that initializes
>> the string and call set properties in a single call otherwise the user
>> may need to do it manually... Something like:
>>
>> (defun make-text-with-properties (string properties)
>>        (let ((out string))
>>             (set-text-properties ...)
>>             out))
>>
>> Any better idea?
>
>Something like
>
>  (defvar completion-header-format
>    (propertize "%s possible completions:"
>                'face 'shadow
>                :help "Please select a completion")
>    "Format of completion header.")
>
Interesting... I couldn't find the propertize function in the text
property section of the manual... Done.

>> The other detail is that there are 2 strings: "Possible completions are"
>> and "There are no possible completions of what you have typed."
>
>In case of no completions it will be formatted to: "0 possible completions".
>
I am perfectly fine with that I was just wondering is anyone will
complain just becaus the previous message changed.

>>> Regarding 'completion-lazy-count': it would be even better to allow
>>> customization of this format like in 'icomplete-matches-format'
>>> that was recently added in 28.1.
>>>
>> Probably the best is to join the two variables in
>> completion-header-string and allow it to have a %s for a count... I will
>> go in that way.
>>
>> Is it OK?
>
>It's OK, like above.

Thanks, please check/correct it.



  reply	other threads:[~2022-03-13 18:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220309001013.gxyh2uasbuxiz6ww.ref@Ergus>
2022-03-09  0:10 ` Question about completion behavior Ergus
2022-03-09  0:22   ` Stefan Monnier
2022-03-09  1:46     ` Ergus
2022-03-09  3:05       ` Stefan Monnier
2022-03-09  3:37         ` Eli Zaretskii
2022-03-09 10:11           ` Ergus
2022-03-09 11:46             ` Ergus
2022-03-09 13:16               ` Eli Zaretskii
2022-03-09 13:46                 ` Po Lu
2022-03-09 17:32                   ` Stefan Monnier
2022-03-09 17:41                     ` Ergus
2022-03-10  0:42                     ` Po Lu
2022-03-10 10:21                       ` Ergus
2022-03-10 11:15                         ` Po Lu
2022-03-10 14:03                           ` Ergus
2022-03-10 18:50                             ` Juri Linkov
2022-03-10 22:35                               ` Ergus
2022-03-12 18:31                                 ` Juri Linkov
2022-03-13 14:58                                   ` Ergus
2022-03-12  0:17                               ` Ergus
2022-03-12 18:34                                 ` Juri Linkov
2022-03-13 11:21                                   ` Ergus
2022-03-13 17:44                                     ` Juri Linkov
2022-03-13 18:50                                       ` Ergus [this message]
2022-03-13 18:57                                         ` Eli Zaretskii
2022-03-13 19:49                                           ` Ergus
2022-03-13 20:48                                       ` [External] : " Drew Adams
2022-03-13 21:15                                         ` Ergus
2022-03-13 23:14                                           ` Drew Adams
2022-03-13 23:38                                             ` Ergus
2022-03-14  2:23                                               ` Drew Adams
2022-03-12 20:25                             ` Drew Adams
2022-03-09 14:30                 ` Ergus
2022-03-09 16:14                   ` [PATCH] " Ergus
2022-03-09 16:56                   ` Eli Zaretskii
2022-03-09 13:10             ` Eli Zaretskii
2022-03-09 14:22               ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220313185056.h5xm6b26zrltn7ty@Ergus \
    --to=spacibba@aol.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=luangruo@yahoo.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).