unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Question about completion behavior
Date: Wed, 9 Mar 2022 02:46:19 +0100	[thread overview]
Message-ID: <20220309014619.bptamkv47xdiyhzp@Ergus> (raw)
In-Reply-To: <jwvee3cdlm9.fsf-monnier+emacs@gnu.org>

On Tue, Mar 08, 2022 at 07:22:11PM -0500, Stefan Monnier wrote:
>Ergus [2022-03-09 01:10:13] wrote:
>> In the code that hides the completions there is actually a comment about
>> this:
>>
>> ;; We could also decide to refresh the completions,
>> ;; if they're displayed (and assuming there are
>> ;; completions left).
>>
>> Is anyone working on this?
>
>When I wrote that code (and that comment), my main goal was to rewrite
>the C code into ELisp, introduce the `completion-styles` system and add
>`partial-completion` to the default.
>
>To maximize the chances that it be accepted, I made every effort to try
>and preserve the old behavior w.r.t everything else.
>
>> Was all this behavior intended or how do you propose to solve this?
>
>I think this can be changed.
>Patches welcome.
>
I am struggling how to preserve the old behavior indeed, because what I
find a bit confusing is actually the default behavior.

We could just add an extra custom to change this detail on demand, but
my initial concert was about the inconsistency itself in the default
behavior. For me it seems like the hide-completions may be inside the
if.

Something like:

```
(completed
        (when exact
          (minibuffer-hide-completions)
          ;; If completion did not put point at end of field,
          ;; it's a sign that completion is not finished.
          (completion--done completion
                            (if (< comp-pos (length completion))
                                'exact 'unknown))
          ))
```

gives a consistent behavior IMO.

But as I know that changing a behavior may be impossible maybe we need
another custom with something like:


```
(completed
        (when (or exact the-new-custom)
             (minibuffer-hide-completions))
        (when exact
            ;; If completion did not put point at end of field,
            ;; it's a sign that completion is not finished.
          (completion--done completion
                            (if (< comp-pos (length completion))
                                'exact 'unknown))))
```

Do think that you any of those may be valid? Some side effect I am not
aware of?


>
>        Stefan
>
Thanks,
Ergus



  reply	other threads:[~2022-03-09  1:46 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220309001013.gxyh2uasbuxiz6ww.ref@Ergus>
2022-03-09  0:10 ` Question about completion behavior Ergus
2022-03-09  0:22   ` Stefan Monnier
2022-03-09  1:46     ` Ergus [this message]
2022-03-09  3:05       ` Stefan Monnier
2022-03-09  3:37         ` Eli Zaretskii
2022-03-09 10:11           ` Ergus
2022-03-09 11:46             ` Ergus
2022-03-09 13:16               ` Eli Zaretskii
2022-03-09 13:46                 ` Po Lu
2022-03-09 17:32                   ` Stefan Monnier
2022-03-09 17:41                     ` Ergus
2022-03-10  0:42                     ` Po Lu
2022-03-10 10:21                       ` Ergus
2022-03-10 11:15                         ` Po Lu
2022-03-10 14:03                           ` Ergus
2022-03-10 18:50                             ` Juri Linkov
2022-03-10 22:35                               ` Ergus
2022-03-12 18:31                                 ` Juri Linkov
2022-03-13 14:58                                   ` Ergus
2022-03-12  0:17                               ` Ergus
2022-03-12 18:34                                 ` Juri Linkov
2022-03-13 11:21                                   ` Ergus
2022-03-13 17:44                                     ` Juri Linkov
2022-03-13 18:50                                       ` Ergus
2022-03-13 18:57                                         ` Eli Zaretskii
2022-03-13 19:49                                           ` Ergus
2022-03-13 20:48                                       ` [External] : " Drew Adams
2022-03-13 21:15                                         ` Ergus
2022-03-13 23:14                                           ` Drew Adams
2022-03-13 23:38                                             ` Ergus
2022-03-14  2:23                                               ` Drew Adams
2022-03-12 20:25                             ` Drew Adams
2022-03-09 14:30                 ` Ergus
2022-03-09 16:14                   ` [PATCH] " Ergus
2022-03-09 16:56                   ` Eli Zaretskii
2022-03-09 13:10             ` Eli Zaretskii
2022-03-09 14:22               ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220309014619.bptamkv47xdiyhzp@Ergus \
    --to=spacibba@aol.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).