From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] completions-max-height Date: Tue, 8 Mar 2022 14:29:10 +0100 Message-ID: <20220308132910.iatgy7fzqkbgw4df@Ergus> References: <20220307210740.veiocemir46mmerk.ref@Ergus> <20220307210740.veiocemir46mmerk@Ergus> <87v8wpxvkj.fsf@posteo.net> <87fsntvxg6.fsf@protesilaos.com> <3723C952-ECE7-467B-AE89-73EB0819B7F0@aol.com> <878rtk3k6m.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Protesilaos Stavrou , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 08 14:32:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRZxF-0000yp-U3 for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Mar 2022 14:32:46 +0100 Original-Received: from localhost ([::1]:43542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRZxE-0007h7-GG for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Mar 2022 08:32:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRZuY-0006ol-Vz for emacs-devel@gnu.org; Tue, 08 Mar 2022 08:29:59 -0500 Original-Received: from sonic302-2.consmr.mail.bf2.yahoo.com ([74.6.135.41]:37419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRZuW-00016R-Mi for emacs-devel@gnu.org; Tue, 08 Mar 2022 08:29:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1646746194; bh=wJAqcPVsCBAPHkZzfurT/UAWplM+vleh66Wwr2QJD5k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=FDu8POfJ5VWVrMy/4yrjMF0Lc8FIowCg1HQ+ASUoo+DkSS4SngXPvUdFiVHNaFuXebQWSI2acV27CXcf+kw0XSgPUqk6FzCRXfCUmqOTRSZzd+By6ulHUfEjE2MZIDPFubuPXTSFGH4Tk13OvQV1wobKTLk4sZdGzFh36mArAu8d6qBPcbXxuvOWpUXhQTHCHck7VoLvepRz1njw804t6vKWtt+6cD+mKNdbQKbu9qB1YzzV0Ph/T8tVLKWwXW+lERIaQXRx1njqp8VSwRfFrbKkadn0K4JbRKc3t2RHNGsioYdkggUnJxCtcGcVqaqUouTKx8rYZon+H2jmrTbtIQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646746194; bh=mBax/qfAnvtZvHRvvo630KOCcRgpQD4tQaH9REXMFwa=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=KjxH7CpkCl4foL0QHNl9UG/xZOwvcXzmVSUYcY3exmKWK52DB7gva7oX/U5mUbK/jY9Ysm/lrKo4q8OgiwAFFQpUl76/OHKSRbANJ+bjMh5npnBQST5sD4MuGctJ4Pczt6GvjATn2RlW9ksStwMLAguqI53MpewXXxD/wviPaL1AX6OZJddT3M9hwXEUyw/73AjCEpX2WMxY4QjF8r9Lp3QAyMwEbemTXcqTsbM2l9GmAFoXBo+hj+hPgrK+3T9rnC/YQognHWkcli8F06NLuq7kzdjs6/rZO+AACK3S+Fy4cmO3ZV/xeRWDTJeW+BTxYLtAGm1IVa1zZrw2282cfQ== X-YMail-OSG: z18xamMVM1nNfE5wFUmY8F.PI5msFzl4aM94bywFW0AVVf5ZSX8fL_FKnK.V65x 4xe7yfsSBOoNb1AgNW10wEthwUQQK8LmSeejIY77JqkL_QEdbVLmBYNlv51Qh_6CqJAX.LC93tiN ZHVhWyYTytFd0x5zeYnyEGFccMFfkyA3ny73dILUUBtuI38hMcmj8Fggycat_gq1DredPwr2csOh YsxpFGpx0QEAUxdxZ2oFgGsOa1buskG4Q7dgGpE52cCuZLozmceRu6k_GbMBzfs34tp72M6ld9Yp aS7vXxz.Cg56wSyAofJyj7dj.5SjLgmO4n1q.RFTppKfz6k3v1pFmeQTiV5ONMrQ9.6lm3EalGSd 4qfSIveyVzCHhDGExJI_QX5geMAXFC_BhJrSQ9599c.6NpeMJodZSIpXjvBmQatSp4ix.GBW.6cJ j0_EDDenCWxtDs.FKqyAS40zCuX6PyCt3uUj3ifYnZ1gMPdqGA2lAjvJbwPaBOt0KSR7uSqvKASH UVPD0XJgW6cC7GPiTGRBTWLmSpnM.rIFgGgH_LFOaKZR0hE_6lqJOvyswbSoBdbUTLZlhUnv9aqE AWhTEgtfOYpIVeVzdqhnq1y27rtfjOzfsy7yCgUFooj20YwH_3OJdhCBYcZ82wxD9FCK1duZP05T xFED3zhOoMO_0Q_4s7vZBkOiz2cJDXw7C9E98h0fa9s1qPFnveTPUf0AkQD_w3SLYm3RklIH5IEh J4cAw8A2YCVuLPEAyy71GMmHhXgH08ltiLX6EMTDwvxXYhOPJhVFf1wUgzlpnN5sW7qW_NxMQjHB YJaANwWbbUHzi2RTJmhxnUdn3.GGsg7HvIGSfDMjzI X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.bf2.yahoo.com with HTTP; Tue, 8 Mar 2022 13:29:54 +0000 Original-Received: by kubenode516.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ed00bde0a4c32aafd8953fca90c9bede; Tue, 08 Mar 2022 13:29:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <878rtk3k6m.fsf@posteo.net> X-Mailer: WebService/1.1.19797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.135.41; envelope-from=spacibba@aol.com; helo=sonic302-2.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286923 Archived-At: On Tue, Mar 08, 2022 at 08:47:13AM +0000, Philip Kaludercic wrote: >Ergus writes: > >> I understand your intention, but in practice making this more complex >> is useless. The mini buffer is always down and making the completions >> to move somewhere else is uncomfortable and may require more >> lisp/emacs knowledge to change the default behavior from the >> user. Which is completely the opposite to my intention. Actually this >> same result may be reached with an advise as I discussed on yesterday >> on emacs help. But a simple custom is better. >> >> I am totally fine if you propose something else more general if that don't forces the user to write a function to change a simple height. > >What I proposed would just require something like > > (setq completion-display-buffer-option '(display-buffer-at-bottom (window-height . 10))) > This just works: (setq display-buffer-alist '(("^\\*Completions\\*$" . (display-buffer-at-bottom (window-height . 10))))) For the simplest case this works... But there is not a way to handle the conditionals without affecting some users. For example when using inline completion or the ones using resize-temp-buffer-window We can use a function instead, but in that case the user customization may need a more complex approach instead of just a setq. Maybe a better lisper could propose something better that allows to set this without a defun, an advise or defining a tricky alist that may conflict with something else?