unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Protesilaos Stavrou <info@protesilaos.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] completions-max-height
Date: Tue, 8 Mar 2022 14:29:10 +0100	[thread overview]
Message-ID: <20220308132910.iatgy7fzqkbgw4df@Ergus> (raw)
In-Reply-To: <878rtk3k6m.fsf@posteo.net>

On Tue, Mar 08, 2022 at 08:47:13AM +0000, Philip Kaludercic wrote:
>Ergus <spacibba@aol.com> writes:
>
>> I understand your intention, but in practice making this more complex
>> is useless. The mini buffer is always down and making the completions
>> to move somewhere else is uncomfortable and may require more
>> lisp/emacs knowledge to change the default behavior from the
>> user. Which is completely the opposite to my intention. Actually this
>> same result may be reached with an advise as I discussed on yesterday
>> on emacs help. But a simple custom is better.
>>
>> I am totally fine if you propose something else more general if that don't forces the user to write a function to change a simple height.
>
>What I proposed would just require something like
>
>    (setq completion-display-buffer-option '(display-buffer-at-bottom (window-height . 10)))
>

This just works:

(setq display-buffer-alist '(("^\\*Completions\\*$" .
			      (display-buffer-at-bottom
			       (window-height . 10)))))

For the simplest case this works... But there is not a way to handle the
conditionals without affecting some users. For example when using inline
completion or the ones using resize-temp-buffer-window

We can use a function instead, but in that case the user customization
may need a more complex approach instead of just a setq.

Maybe a better lisper could propose something better that allows to set
this without a defun, an advise or defining a tricky alist that may
conflict with something else?




  parent reply	other threads:[~2022-03-08 13:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220307210740.veiocemir46mmerk.ref@Ergus>
2022-03-07 21:07 ` [PATCH] completions-max-height Ergus
2022-03-07 22:10   ` Philip Kaludercic
2022-03-08  5:13     ` Protesilaos Stavrou
2022-03-08  8:05       ` Ergus
2022-03-08  8:47         ` Philip Kaludercic
2022-03-08 10:32           ` Ergus
2022-03-08 13:29           ` Ergus [this message]
2022-03-09 11:34             ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220308132910.iatgy7fzqkbgw4df@Ergus \
    --to=spacibba@aol.com \
    --cc=emacs-devel@gnu.org \
    --cc=info@protesilaos.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).