From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Madhu Newsgroups: gmane.emacs.devel Subject: Re: Deiconifying GTK frames on GNOME shell Date: Wed, 08 Dec 2021 22:03:28 +0530 (IST) Message-ID: <20211208.220328.997529211206116189.enometh@meer.net> References: <20211206.210507.1015981090870439275.enometh@meer.net> <42555c74-d13d-64eb-d0ff-fd775ee97b8a@gmx.at> <87ilvze4k5.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32695"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, masm+emacs@masm11.me, emacs-devel@gnu.org To: luangruo@yahoo.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 08 17:35:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muzuL-0008Gz-Af for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Dec 2021 17:35:05 +0100 Original-Received: from localhost ([::1]:45432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muzuK-0007RP-6I for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Dec 2021 11:35:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muzt1-0006DK-T8 for emacs-devel@gnu.org; Wed, 08 Dec 2021 11:33:44 -0500 Original-Received: from smtp6.ctinetworks.com ([205.166.61.199]:55172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muzt0-0007Qi-H5 for emacs-devel@gnu.org; Wed, 08 Dec 2021 11:33:43 -0500 Original-Received: from localhost (unknown [117.254.34.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp6.ctinetworks.com (Postfix) with ESMTPSA id 63D1584C2C; Wed, 8 Dec 2021 11:33:31 -0500 (EST) In-Reply-To: <87ilvze4k5.fsf@yahoo.com> X-Mailer: Mew version 6.8 on Emacs 29.0.50 X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: 63D1584C2C.A7220 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-Watermark: 1639845218.83901@4LqfkQGt29vraZQBMo2twQ Received-SPF: pass client-ip=205.166.61.199; envelope-from=enometh@meer.net; helo=smtp6.ctinetworks.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281367 Archived-At: * Po Lu <87ilvze4k5.fsf@yahoo.com> Wrote on Wed, 08 Dec 2021 19:09:30 +0800 > martin rudalics writes: >> Yuuki Harano, Po Lu - any comments on that patch? > Could you explain what it is supposed to fix? Hello, it is meant to make (select-frame-set-input-focus) "work" on wayland for the time being. It is not a correct fix. (x-focus-frame $a t) will raise the frame when it should not be raised. > I thought the reason frames couldn't be raised under PGTK was that > `frame_raise_lower_hook' is unimplemented there, which someone will > certainly get to soon. The problem I believe is that the gdk/gtk apis to raise/lower windows just doesn't work on wayland. Implementing frame_raise_lower_hook with, say gdk_window_raise (gtk_widget_get_window (GTK_WIDGET (FRAME_GTK_OUTER_WIDGET (f)))); has no effect. I linked to two urls pointing to the bug reports on frame stacking order. (Maybe I'm misunderstanding but there are at least a dozen more reports) it is a wrong fix, but on the other hand select-frame-set-input-focus seems to be crucial (for me) for using more than 2 frames >> + gtk_window_present_with_time (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)), g_get_monotonic_time () / 1000L); > > I think GDK_CURRENT_TIME should work equally well here, right? I'll check shortly, Thanks, ---Best Regards Madhu