From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuuki Harano Newsgroups: gmane.emacs.devel Subject: Re: Merging the pgtk branch Date: Mon, 06 Dec 2021 01:01:17 +0900 (JST) Organization: Ingage Inc. Message-ID: <20211206.010117.1221729564949074065.masm@luna.pink.masm11.me> References: <20210811.001515.1312870178782255892.masm@luna.pink.masm11.me> <20211130.004115.1186997531521134959.masm@luna.pink.masm11.me> <83tufn2lh6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: eliz@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 05 17:02:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mttyL-0008bx-P3 for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Dec 2021 17:02:42 +0100 Original-Received: from localhost ([::1]:33310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mttyJ-00071n-Oj for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Dec 2021 11:02:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mttx9-0006KT-Mo for emacs-devel@gnu.org; Sun, 05 Dec 2021 11:01:28 -0500 Original-Received: from shiro.masm11.me ([150.95.182.25]:56410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mttx7-0003SF-0X; Sun, 05 Dec 2021 11:01:27 -0500 Original-Received: from luna.pink.masm11.me (i153-144-34-242.s41.a033.ap.plala.or.jp [153.144.34.242]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id 2CD29C014E; Mon, 6 Dec 2021 01:01:18 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1638720078; bh=KfzBB5A4x4u6FBP62jQxrb5BSIjjs9uNDtdBdc28qfo=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=Os2JaWwyYxb9KtL16CvJRhcH+q3+JPuBinkQ+gPBKlXpsJmLUnK9NcGAlAcH2Buko Y7LzWb5DLRfGXYiIWmdKOMaHJ3ycHEBG8hUiG0LMTKGyrlfS2G+HFY+ieXIyNcqm3h dcnhI/mzW3hY0uJ98iQvQgVSqCAbGYqynR07l/Ls= In-Reply-To: <83tufn2lh6.fsf@gnu.org> X-Mailer: Mew version 6.8 on Emacs 29.0 Received-SPF: pass client-ip=150.95.182.25; envelope-from=masm@masm11.me; helo=shiro.masm11.me X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281008 Archived-At: On Sun, 05 Dec 2021 16:08:05 +0200, Eli Zaretskii wrote: >> I thought that gui_set_border_width could change the border width of a frame. >> But there is the code: >> --- >> if (FRAME_NATIVE_WINDOW (f) != 0) >> error ("Cannot change the border width of a frame"); >> --- >> I was confused, and added #ifndef around it. >> >> I don't know about the function. >> What is it for? > > It's for setting the width of the "external border" of the frame, > something that window managers generally disallow. Doesn't PGTK > define FRAME_NATIVE_WINDOW to return non-zero for any GUI frame? If > so, you don't have to #ifdef this, it will work as with any other > window-system. Thanks. I reverted those changes. And I think I did all the fixes which are necessary by review comments by you. -- Yuuki Harano